-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make ProvisioningContext.FOLLOW_ARTIFACT_REPOSITORY_REFERENCES public to avoid duplication #506
Make ProvisioningContext.FOLLOW_ARTIFACT_REPOSITORY_REFERENCES public to avoid duplication #506
Conversation
...les/org.eclipse.equinox.p2.engine/src/org/eclipse/equinox/p2/engine/ProvisioningContext.java
Outdated
Show resolved
Hide resolved
The service segment has been incremented twice in this release cycle: The Also the package constraint where this constant is used says 2.2.0 because that's the current version of the package, but that version hasn't changed here and so that version of the package does not necessary have the public constant. So probably that should be increased too, probably to 2.11.0 like the bundle. |
@merks I think the package should become |
Since I'm just trying to resolve the reference issue in general, I've added the isEnabled changes to this PR. If you prefer, I can split it up into two PRs. |
...clipse.equinox.p2.repository/src/org/eclipse/equinox/p2/repository/IRepositoryReference.java
Outdated
Show resolved
Hide resolved
52d0189
to
2dd0293
Compare
I've bumped |
… to avoid duplication It was duplicated in DirectorApplication, making it hard to follow the property around the code zever aiorn
This abstracts the bit flag checking for repository references.
2dd0293
to
8c2cddd
Compare
I’m good with that. |
...les/org.eclipse.equinox.p2.engine/src/org/eclipse/equinox/p2/engine/ProvisioningContext.java
Show resolved
Hide resolved
@tivervac thanks for the imropvement. |
It was duplicated in DirectorApplication, making it hard to follow the property around the code.
The original inspiration for this came from #505