Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correctly consider cardinality based on the directives #474

Merged
merged 1 commit into from
Apr 29, 2024

Conversation

laeubi
Copy link
Member

@laeubi laeubi commented Feb 20, 2024

Currently the BundlesAction uses either 0 or 1 as the cardinality but actually a requirement can be a multi-cardinality as well.

This adds new dedicated methods to not duplicate the computation and a testcase that ensures all combination are covered and correctly translated.

@laeubi
Copy link
Member Author

laeubi commented Feb 20, 2024

cardinality:=multiple is not very common but we still should map this correctly, @tjwatson @merks should this go into RC1 or should we wait for the next release?

@merks
Copy link
Contributor

merks commented Feb 20, 2024

Can you summarize the impact. I believe it just means that if there is a cardinality:=multiple the requirement will have max=MAX_INT. Otherwise nothing is changed, correct?

@laeubi
Copy link
Member Author

laeubi commented Feb 20, 2024

Yes currently it is either 0..1 or 1..1, but it is also possible that it is 0...n and 1...n if you look at the manifest I used for the testcase it should be more clear.

Copy link

github-actions bot commented Feb 20, 2024

Test Results

    9 files  ±0      9 suites  ±0   29m 41s ⏱️ -36s
2 197 tests +1  2 193 ✅ +1   4 💤 ±0  0 ❌ ±0 
6 681 runs  +3  6 670 ✅ +3  11 💤 ±0  0 ❌ ±0 

Results for commit 2b2c924. ± Comparison against base commit 4426f86.

♻️ This comment has been updated with latest results.

@laeubi
Copy link
Member Author

laeubi commented Apr 24, 2024

As no one raised concerns I'll merge this as soon as build completes.

Currently the BundlesAction uses either 0 or 1 as the cardinality but
actually a requirement can be a multi-cardinality as well.

This adds new dedicated methods to not duplicate the computation and a
testcase that ensures all combination are covered and correctly
translated.
@laeubi laeubi merged commit 96d0fc5 into eclipse-equinox:master Apr 29, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants