Do not use PackageAdmin for refresh bundles #421
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
merks
reviewed
Dec 30, 2023
...ox.simpleconfigurator/src/org/eclipse/equinox/internal/simpleconfigurator/ConfigApplier.java
Outdated
Show resolved
Hide resolved
merks
reviewed
Dec 30, 2023
...ox.simpleconfigurator/src/org/eclipse/equinox/internal/simpleconfigurator/ConfigApplier.java
Show resolved
Hide resolved
laeubi
force-pushed
the
no_pkg_admin_for_refresh
branch
from
d4a40bf
to
2f4b5e5
Compare
HannesWell
reviewed
Dec 30, 2023
...ox.simpleconfigurator/src/org/eclipse/equinox/internal/simpleconfigurator/ConfigApplier.java
Outdated
Show resolved
Hide resolved
...ox.simpleconfigurator/src/org/eclipse/equinox/internal/simpleconfigurator/ConfigApplier.java
Outdated
Show resolved
Hide resolved
...ox.simpleconfigurator/src/org/eclipse/equinox/internal/simpleconfigurator/ConfigApplier.java
Show resolved
Hide resolved
laeubi
force-pushed
the
no_pkg_admin_for_refresh
branch
4 times, most recently
from
07b4cf7
to
28eabc9
Compare
laeubi
force-pushed
the
no_pkg_admin_for_refresh
branch
from
28eabc9
to
9f18d81
Compare
tjwatson
requested changes
Jan 2, 2024
...ox.simpleconfigurator/src/org/eclipse/equinox/internal/simpleconfigurator/ConfigApplier.java
Outdated
Show resolved
Hide resolved
...ox.simpleconfigurator/src/org/eclipse/equinox/internal/simpleconfigurator/ConfigApplier.java
Show resolved
Hide resolved
HannesWell
approved these changes
Jan 3, 2024
laeubi
force-pushed
the
no_pkg_admin_for_refresh
branch
from
9f18d81
to
9d8bc73
Compare
|
@tjwatson are your concerns addressed now? |
tjwatson
approved these changes
Jan 23, 2024
|
@laeubi looks like we missed that in the previous cycle. Would you please rebase and once PR succeeds merge as it's already approved? |
Currently there are two ways to refresh packages, one using the deprecated PackageAdmin and one using the FrameworkWiring. This do the following: - always use FrameworkWiring - use collections over arrays - remove some redundant checks and copy of collections
laeubi
force-pushed
the
no_pkg_admin_for_refresh
branch
from
9d8bc73
to
f28d0fc
Compare
|
I now rebased this, as it was a non trivial rebase I would suggest that others might look at this as well. |
tjwatson
approved these changes
Apr 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently there are two ways to refresh packages, one using the deprecated PackageAdmin and one using the FrameworkWiring.
This do the following: