-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add IInstallableUnitQueryable interface to allow easier adaption #348
Conversation
Currently there is only the generic IQueryable<T> but this don't work well in cases where one can't pass type information for the generic e.g. when adapting an object there is no way to pass the parameter T. This adds a new interface that lock in the type T for a IQueryable that can supply IInstallableUnits.
@merks @mickaelistria @HannesWell any objections merging this (as it is actually new API we should have one additional comiter approval). I think there should neither compatibility nor maintain concerns of having this simple interface and this currently prevents the PDE verification build from happening. |
An alternative would be to make this PDE "private" and not general available to P2... |
It seems okay, though I'm not entirely sure why something needed by PDE has to be added to p2... |
Main purpose is to |
I'm fine with whatever you and @HannesWell decide is best... |
Then lets go so it is available in tomorrows i-build |
adaption" This reverts commit 9005901, respectively eclipse-equinox#348
adaption" This reverts commit 9005901, respectively eclipse-equinox#348
Currently there is only the generic IQueryable but this don't work well in cases where one can't pass type information for the generic e.g. when adapting an object there is no way to pass the parameter T.
This adds a new interface that lock in the type T for a IQueryable that can supply IInstallableUnits.
This is a prerequisite of eclipse-pde/eclipse.pde#207 where I'd like to use the Adapter pattern to support other locations to supply additional Installable units.