Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Util.getResponseEncoding: defaultEncoding from Optional<String> to String #5438

Open
wants to merge 2 commits into
base: 4.0
Choose a base branch
from

Conversation

pizzi80
Copy link
Contributor

@pizzi80 pizzi80 commented Apr 10, 2024

code simplification

@pizzi80 pizzi80 changed the title Issue #5436 + fix for PR 5430 Optional<String> => String Apr 10, 2024
@pizzi80 pizzi80 changed the title Optional<String> => String Util.getResponseEncoding: defaultEncoding from Optional<String> to String Apr 10, 2024
@BalusC
Copy link
Contributor

BalusC commented Apr 10, 2024

Not sure this is simplification as this duplicates RIConstants.CHAR_ENCODING and therefore decreases the control on the default outcome. Ideally the default outcome should be controlled in only one place not two.

@pizzi80
Copy link
Contributor Author

pizzi80 commented Apr 10, 2024

Exactly, we could simplify it further,

public static String getResponseEncoding(FacesContext context) {
    return getResponseEncoding(context, null);
}

Signed-off-by: pizzi80 <[email protected]>
@pizzi80
Copy link
Contributor Author

pizzi80 commented Apr 10, 2024

done

@arjantijms arjantijms added this to the 4.0.8 milestone May 7, 2024
@BalusC BalusC removed this from the 4.0.8 milestone Sep 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants