Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[4.0] fix #1950 Duplicate objects in UnitOfWorkImpl.primaryKeyToNewObjects - backport from master #2177

Merged
merged 2 commits into from
Jun 20, 2024

Conversation

Zuplyx
Copy link
Contributor

@Zuplyx Zuplyx commented Jun 20, 2024

Fixes #1950.
Backport from #1951.

Note: This fixes a bug in #1843, which was already released with version 4.0.2

…e4j#1951)

* Fixes eclipse-ee4j#1950: Duplicate objects in UnitOfWorkImpl.primaryKeyToNewObjects
- no longer add objects to primaryKeyToNewObjects in assignSequenceNumber
- use IdentityHashSet instead of ArrayList for primaryKeyToNewObjects to prevent duplicates in the future

Signed-off-by: Patrick Schmitt <[email protected]>
(cherry picked from commit ad93f7a)
Signed-off-by: Patrick Schmitt <[email protected]>
@Zuplyx Zuplyx requested a review from rfelcman June 20, 2024 11:02
@rfelcman rfelcman merged commit 21aef35 into eclipse-ee4j:4.0 Jun 20, 2024
2 of 3 checks passed
@Zuplyx Zuplyx deleted the 4.0-issue1950 branch June 20, 2024 14:09
@patric-r
Copy link

patric-r commented Jul 3, 2024

This is an important fix of a scary bug. Wondering that this was not part of 4.0.3.
Can we please have a 4.0.4 (funny version number btw) release soon?

@rfelcman
Copy link
Contributor

rfelcman commented Jul 4, 2024

This is an important fix of a scary bug. Wondering that this was not part of 4.0.3. Can we please have a 4.0.4 (funny version number btw) release soon?

We plan new releases at the end of August (after vacations and holidays). At least You can try latest snapshot/nightly build from
https://download.eclipse.org/rt/eclipselink/nightly/4.0.4/20240702/
https://jakarta.oss.sonatype.org/content/groups/staging/org/eclipse/persistence/eclipselink/4.0.4-SNAPSHOT/

@Zuplyx
Copy link
Contributor Author

Zuplyx commented Jul 4, 2024

Hello @rfelcman, as far as I can see the Snapshot builds contain only the FAT-Jar, which includes many for us unnecessary modules (e.g. the JAXB implementation). Is there any way to get the individual module Jars for a Snapshot build?

@rfelcman
Copy link
Contributor

rfelcman commented Jul 4, 2024

Hello @rfelcman, as far as I can see the Snapshot builds contain only the FAT-Jar, which includes many for us unnecessary modules (e.g. the JAXB implementation). Is there any way to get the individual module Jars for a Snapshot build?

There are same artifacts like in central
https://jakarta.oss.sonatype.org/content/groups/staging/org/eclipse/persistence/
https://jakarta.oss.sonatype.org/content/groups/staging/org/eclipse/persistence/org.eclipse.persistence.jpa/4.0.4-SNAPSHOT/
https://jakarta.oss.sonatype.org/content/groups/staging/org/eclipse/persistence/org.eclipse.persistence.core/4.0.4-SNAPSHOT/
it's Jakarta staging Maven repository
see profile staging in pom
org.eclipse.ee4j:project1.0.9

@Zuplyx
Copy link
Contributor Author

Zuplyx commented Jul 4, 2024

Yes, I see now that you're right. Thank you for your help.

@patric-r
Copy link

patric-r commented Jul 4, 2024

We plan new releases at the end of August (after vacations and holidays).

Thanks @rfelcman for your swift response.
End of August is fine for us.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants