Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[master] Minor messaging improvements #2176

Merged
merged 2 commits into from
Jul 11, 2024

Conversation

Riva-Tholoor-Philip
Copy link
Contributor

Added minor messaging improvements.

@rfelcman
Copy link
Contributor

Sorry but not all tests passing. Please check test outputs and fix provided code.

@Riva-Tholoor-Philip
Copy link
Contributor Author

Sorry but not all tests passing. Please check test outputs and fix provided code.

Hi Radek,
I made necessary changes

@Riva-Tholoor-Philip Riva-Tholoor-Philip force-pushed the masterUpdateMsg branch 2 times, most recently from aa4cfc7 to 2204436 Compare July 1, 2024 08:18
@Riva-Tholoor-Philip
Copy link
Contributor Author

@rfelcman - The build looks good.

@Riva-Tholoor-Philip
Copy link
Contributor Author

@rfelcman , @lukasj - The test failures has been resolved and it is ready. Please review and confirm whether we can merge it

Copy link
Contributor

@rfelcman rfelcman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rfelcman rfelcman merged commit 76e9e04 into eclipse-ee4j:master Jul 11, 2024
5 of 6 checks passed
@Riva-Tholoor-Philip
Copy link
Contributor Author

Thanks @rfelcman

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants