Wildfly Support #195

hantsy · 2021-03-21T10:59:05Z

No description provided.

Signed-off-by: Akira Kawauchi <[email protected]>

hantsy · 2021-03-21T12:15:40Z

@m-reza-rahman About the class- name of data-source in web.xml, in the current code it is set to JDBC driver class name. But WildFly requires a DataSource impl, eg. org.h2.jdbcx.JdbcDataSource there.

In the master of my fork, I also used DataSource implementation class for pg database which works on both Payara and WildFly.

m-reza-rahman · 2021-03-21T18:27:41Z

This is failing multiple checks. Can you kindly fix that?

hantsy · 2021-03-22T03:45:33Z

Not sure why the format checking fialed after doing some rebase in the branch.

hantsy · 2021-03-22T04:03:04Z

The eclipse eca checking is a little strange. When using git commit with -s command line parameter, it failed. Rebase and edit the comment and remove the last empty line, it passed.

I used a Windows 10.

Signed-off-by: Akira Kawauchi <[email protected]>

Move coordinates constants of public/mapFrame.xhtml to server-side

m-reza-rahman · 2021-03-28T19:44:13Z

I am sorry Hantsy, this has been a tough weekend. I promise I will prioritize this PR next weekend. It will be cool to be able to fully support WildFly and Payara.

m-reza-rahman

Please address these issues. The PR looks otherwise reasonable.

m-reza-rahman · 2021-04-04T15:55:49Z

README.md

+
+You can do that with the following script:
+```shell script
+wget https://download.jboss.org/wildfly/23.0.0.Final/wildfly-23.0.0.Final.zip


Let's kindly investigate using WildFly embedded for the Arquillian tests. That should be possible unlike Payara.

m-reza-rahman · 2021-04-04T15:59:46Z

src/main/java/org/eclipse/cargotracker/application/util/RestConfiguration.java

@@ -13,7 +12,11 @@
  @Override
  public Map<String, Object> getProperties() {
    Map<String, Object> properties = new HashMap<String, Object>();
-    properties.put(ServerProperties.BV_SEND_ERROR_IN_RESPONSE, true);


Why is changing this necessary? Are the Jersey classes conflicting with RESTEasy? How about the other way around?

The class ServerProperties is not available in WildFly/Resteasy.

I was wondering what would happen if we just included the Jersey dependency in the class-path. Also, is there a RESTEasy version of this? In which case we need to add that too?

For a real portable solution, I think it is better to write an ExceptionMapper for it.

Resteasy could have its solution for bean validation processing.

Converted to text literal, to avoid Class not found exception under WildFly/Resteasy.

You can leave this as-is. I will handle it after merge, no problem.

m-reza-rahman · 2021-04-04T16:02:16Z

src/main/java/org/eclipse/cargotracker/domain/model/cargo/Cargo.java

@@ -168,7 +168,7 @@ public boolean equals(Object object) {
    if (this == object) {
      return true;
    }
-    if (object == null || getClass() != object.getClass()) {
+    if (object == null || !(object instanceof Cargo)) {


Let's decouple these into a separate PR in the master branch to reduce clutter here and focus on the actual portability changes.

If this is moved to a separate PR, this should be extracted firstly and be merged before the WildFly pr, in Hibernate entity comparation depends on this.

m-reza-rahman · 2021-04-04T16:19:14Z

...org/eclipse/cargotracker/interfaces/booking/facade/internal/DefaultBookingServiceFacade.java

@@ -28,6 +29,7 @@
 import org.eclipse.cargotracker.interfaces.booking.facade.internal.assembler.LocationDtoAssembler;

 @ApplicationScoped
+@Transactional


I understand this is a way to avoid Hibernate lazy instantiation issues. However, this approach is a bit of a hack and counter to separation of concerns in DDD. There should be no reason for this to be transactional other than dealing with Hibernate. Instead, let us do a bit deeper domain analysis and see if lazy loading can be avoided altogether, probably using entity graphs. In the layers above the repository layer, you can introduce "load...For..." methods that are domain case specific. Ideally, this could extend to the repository layer as well. If not, you can introduce a finder parameter such as "LOAD_FULLY", "LOAD_PARTIALLY" or "LOAD_MINIMALLY" that maps to various entity graphs in the repository layer. This technique will keep things portable with Hibernate and still maintain proper layering instead of leaking data loading concerns into the business and UI tiers. Let me know if this all makes sense or we can discuss it in more detail. You can look at some further discussion here: #33.

Currently, this is the simplest approach to avoid the lazy exception. As mentioned in #33 maybe define @entitygraph is the better solution. But for before experience, like what do in JBoss Seam, or Apache DeltaSpike(I do not remember the details), there is a generic open session in view like solution to apply to JSF request lifecycle.

I really hate to say this, but I don't think we can have that approach in a DDD focused project. Do you think you could take some time to address this please? That would be awesome!

m-reza-rahman · 2021-04-04T16:24:46Z

src/main/webapp/event-logger/index.xhtml

@@ -1,8 +1,13 @@
 <!DOCTYPE html>
 <html xmlns="http://www.w3.org/1999/xhtml"
-	xmlns:h="http://java.sun.com/jsf/html"
-	xmlns:f="http://java.sun.com/jsf/core"
+	xmlns:h="http://xmlns.jcp.org/jsf/html"


Please incorporate this into a separate PR against the master branch. That will reduce clutter here and keep things focused on portability.

OK, I just noticed this file when cleaning the backed bean, not clean all xmlns in facelets templates. Move to a separate PR is ok, could clean all xmlns there.

Signed-off-by: Hantsy Bai <[email protected]>

kasabuta4 added 2 commits March 21, 2021 06:42

Replace Primitive with Object in calling public/mapFrame.xhtml

7b2608b

Signed-off-by: Akira Kawauchi <[email protected]>

Move coordinates constants of public/mapFrame.xhtml to server-side

5adc55c

Signed-off-by: Akira Kawauchi <[email protected]>

hantsy force-pushed the wildfly branch from b88ae1d to 160913c Compare March 21, 2021 11:04

hantsy mentioned this pull request Mar 21, 2021

Support WildFly #180

Open

hantsy force-pushed the wildfly branch from ba8ca7e to c9d198c Compare March 21, 2021 12:34

hantsy force-pushed the wildfly branch 2 times, most recently from f841fc5 to f72d496 Compare March 22, 2021 02:58

kasabuta4 and others added 6 commits March 24, 2021 13:38

Add URL encoding

834607c

Signed-off-by: Akira Kawauchi <[email protected]>

Merge pull request #194 from kasabuta4/coord

672b256

Move coordinates constants of public/mapFrame.xhtml to server-side

Minor refactoring.

e98d294

Google Java Format

f3b3d61

Minor refactoring.

4f26659

Merge branch 'master' of https://github.com/eclipse-ee4j/cargotracker

dc1c3b1

m-reza-rahman requested changes Apr 4, 2021

View reviewed changes

hantsy added 2 commits April 7, 2021 16:39

clean codes for wildfly

56b0564

Signed-off-by: Hantsy Bai <[email protected]>

chore: fetch lazy legs in public track

aa99ee9

Signed-off-by: Hantsy Bai <[email protected]>

hantsy force-pushed the wildfly branch from e0ec26a to aa99ee9 Compare April 7, 2021 13:12

chore: fixes Cargo import order

a1ad8cd

Signed-off-by: Hantsy Bai <[email protected]>

m-reza-rahman closed this Apr 9, 2021

m-reza-rahman deleted the branch eclipse-ee4j:develop April 9, 2021 19:16

hantsy deleted the wildfly branch April 18, 2021 02:55

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Wildfly Support #195

Wildfly Support #195

hantsy commented Mar 21, 2021

hantsy commented Mar 21, 2021 •

edited

Loading

m-reza-rahman commented Mar 21, 2021

hantsy commented Mar 22, 2021 •

edited

Loading

hantsy commented Mar 22, 2021 •

edited

Loading

m-reza-rahman commented Mar 28, 2021

m-reza-rahman left a comment •

edited

Loading

m-reza-rahman Apr 4, 2021

m-reza-rahman Apr 4, 2021

hantsy Apr 5, 2021 •

edited

Loading

m-reza-rahman Apr 5, 2021

hantsy Apr 7, 2021

hantsy Apr 7, 2021

hantsy Apr 7, 2021

m-reza-rahman Apr 7, 2021

m-reza-rahman Apr 4, 2021

hantsy Apr 7, 2021 •

edited

Loading

m-reza-rahman Apr 4, 2021 •

edited

Loading

hantsy Apr 7, 2021

m-reza-rahman Apr 7, 2021

m-reza-rahman Apr 4, 2021

hantsy Apr 7, 2021 •

edited

Loading

Wildfly Support #195

Wildfly Support #195

Conversation

hantsy commented Mar 21, 2021

hantsy commented Mar 21, 2021 • edited Loading

m-reza-rahman commented Mar 21, 2021

hantsy commented Mar 22, 2021 • edited Loading

hantsy commented Mar 22, 2021 • edited Loading

m-reza-rahman commented Mar 28, 2021

m-reza-rahman left a comment • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

hantsy Apr 5, 2021 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

hantsy Apr 7, 2021 • edited Loading

Choose a reason for hiding this comment

m-reza-rahman Apr 4, 2021 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

hantsy Apr 7, 2021 • edited Loading

Choose a reason for hiding this comment

hantsy commented Mar 21, 2021 •

edited

Loading

hantsy commented Mar 22, 2021 •

edited

Loading

hantsy commented Mar 22, 2021 •

edited

Loading

m-reza-rahman left a comment •

edited

Loading

hantsy Apr 5, 2021 •

edited

Loading

hantsy Apr 7, 2021 •

edited

Loading

m-reza-rahman Apr 4, 2021 •

edited

Loading

hantsy Apr 7, 2021 •

edited

Loading