fix: update show message method to get custom error messages #42
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OlfaBensoussia
force-pushed
the
41-wrong-error-msg-displayed
branch
from
5a5d537
to
55554ed
Compare
OlfaBensoussia
force-pushed
the
41-wrong-error-msg-displayed
branch
from
55554ed
to
9944f73
Compare
ndr-brt
approved these changes
Aug 17, 2023
|
thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR changes/adds
This PR attempts to fix the issue of having a hardcoded error message for the create and update ops. We added another argument to the private method
showErrorwhere we can pass a custom message while still logging the original error messageWhy it does that
We made this change to get verbose and self-descriptive error
Further notes
List other areas of code that have changed but are not necessarily linked to the main feature. This could be method
signature changes, package declarations, bugs that were encountered and were fixed inline, etc.
Linked Issue(s)
Closes #41
Please be sure to take a look at the contributing guidelines and our etiquette for pull requests.