-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Stabilize workspace with parent test #23242
base: main
Are you sure you want to change the base?
Conversation
e7dde4e
to
b061ffa
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved. Setting
security.workspace.trust.enabled: false` is much better than constantly fixing trustDialog errors.
let podName: string = ''; | ||
|
||
suiteSetup(function (): void { | ||
kubernetesCommandLineToolsExecutor.loginToOcp(); | ||
kubernetesCommandLineToolsExecutor.namespace = BASE_TEST_CONSTANTS.TEST_NAMESPACE; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
BASE_TEST_CONSTANTS.TEST_NAMESPACE could be empty, e.g. when run Dev Spaces test pipelines.
There is an example of code which handles absence of BASE_TEST_CONSTANTS.TEST_NAMESPACE: KubernetesCommandLineToolsExecutor
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I removed it. Thx for pointing! Seems, unnecessary operation after experimenting with test launching
What does this PR do?
Stabilize the WorkspaceWithParent and implement a new solution for disabling the TrustDialog using a new method. The main idea - is to switch it off in background mode with a special JS script using JavascriptExecutor and patching the local database in the browser session. It is similar to setting up its
"security.workspace.trust.enabled":false
with user preferences. Handling the dialog by UI is hard because it is not easy to predict where it can appear.Screenshot/screencast of this PR
What issues does this PR fix or reference?
How to test this PR?
Run the WorkspaceWithParent.spec.ts as usual
-->
PR Checklist
As the author of this Pull Request I made sure that:
What issues does this PR fix or reference
andHow to test this PR
completedReviewers
Reviewers, please comment how you tested the PR when approving it.