Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove redundant endpoints #1904

Closed
wants to merge 1 commit into from

Conversation

vitaliy-guliy
Copy link

What does this PR do?

Removes not used endpoints from che-code editor definition.

Screenshot/screencast of this PR

What issues does this PR fix or reference?

No issue, just a tiny improvement

How to test this PR?

  • create a workspace applying proposed editor yaml
  • make sure the editor works as expected

PR Checklist

As the author of this Pull Request I made sure that:

Reviewers

Reviewers, please comment how you tested the PR when approving it.

Copy link

openshift-ci bot commented Sep 20, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: vitaliy-guliy

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@vitaliy-guliy vitaliy-guliy added the made-with-che Changes were made using Che label Sep 20, 2024
Copy link

openshift-ci bot commented Sep 20, 2024

@vitaliy-guliy: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/v14-che-behind-proxy f59bd2d link true /test v14-che-behind-proxy

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Copy link
Member

@ibuziuk ibuziuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should not be done I believe since those endpoints are used for automatic port redirect e.g. nodejs sample listening on port 3000 but devfile has not defined an endpoint, and without those definition exposure would not happen

@ibuziuk
Copy link
Member

ibuziuk commented Sep 20, 2024

@azatsarynnyy @RomanNikitenko please, review
but I believe instead of this PR we need to contribute to the docs explaining why we are using this endpoints in the editor definition. Probably here https://eclipse.dev/che/docs/stable/administration-guide/configuring-visual-studio-code/

@azatsarynnyy
Copy link
Member

@azatsarynnyy @RomanNikitenko please, review but I believe instead of this PR we need to contribute to the docs explaining why we are using this endpoints in the editor definition. Probably here https://eclipse.dev/che/docs/stable/administration-guide/configuring-visual-studio-code/

I created an issue eclipse-che/che#23160

@ibuziuk ibuziuk closed this Sep 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
made-with-che Changes were made using Che
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants