Use endpoint-specific service for discoverable endpoints #1903

AObuchow · 2024-09-20T04:27:54Z

What does this PR do?

When using the discoverable attribute on a devfile endpoint, a service is created for that specific endpoint that's associated with the route/ingress. However, the current behaviour of the Che Router always associates an endpoint with the workspace's common service, rather than any endpoint-specific service.

This PR fixes this behaviour, by ensuring the correct service is provided for each endpoint's route/ingress.

Screenshot/screencast of this PR

n/a

What issues does this PR fix or reference?

Fixes eclipse-che/che#23061

How to test this PR?

Install Che using the changes from this PR by running:

On OpenShift: ./build/scripts/olm/test-catalog-from-sources.sh
On Minikube: ./build/scripts/minikube-tests/test-operator-from-sources.sh
Alternatively, I've built a Che-Operator image from this PR and pushed it to quay.io/aobuchow/che-operator:endpoint-service.

Once Che is installed, create a workspace using a devfile that has an endpoint with the discoverable attribute. For convenience, you can use my reproducer devfile.

# Example endpoint with discoverable attribute
- exposure: public
  targetPort: 8080
  name: https-python
  protocol: http
  secure: true
  attributes:
    discoverable: true

In your workspace, start up a web server that uses the discoverable endpoint. Using my reproducer devfile, this can be accomplished by running the pip-install-requirements then run-app devfile tasks from the CheCode UI. When the endpoint notification pops up, click "Open in New Tab".
The web server should be available on the route provided. With my reproducer devfile, you'll see a page with Hello World!

For comparison, here's a comment displaying the behaviour without the changes from this PR applied.

PR Checklist

As the author of this Pull Request I made sure that:

Reviewers

Reviewers, please comment how you tested the PR when approving it.

AObuchow · 2024-09-20T04:29:53Z

@tolusha please prioritize reviewing #1881 before this PR, as #1881 is of higher priority for DevSpaces 3.17. Thank you :)

Fix eclipse-che/che#23061 Signed-off-by: Andrew Obuchowicz <[email protected]>

Signed-off-by: Andrew Obuchowicz <[email protected]>

AObuchow · 2024-09-24T15:36:17Z

@dkwon17 this PR has now been rebased onto the main branch

AObuchow · 2024-09-24T15:37:03Z

FWIW: I confirmed with @eye0fra that the che-operator image built from this PR fixes the issue described in eclipse-che/che#23061

AObuchow · 2024-09-24T16:01:18Z

/retest-required

dkwon17 · 2024-09-24T18:58:09Z

controllers/devworkspace/solver/che_routing.go

@@ -474,12 +476,38 @@ func getCommonService(objs *solvers.RoutingObjects, dwId string) *corev1.Service
 	return nil
 }

-func exposeAllEndpoints(cheCluster *chev2.CheCluster, routing *dwo.DevWorkspaceRouting, objs *solvers.RoutingObjects, ingressExpose func(*EndpointInfo), endpointStrategy EndpointStrategy) *corev1.ConfigMap {
+func getServiceForEndpoint(objs *solvers.RoutingObjects, endpoint dwo.Endpoint) *corev1.Service {


Suggested change

func getServiceForEndpoint(objs *solvers.RoutingObjects, endpoint dwo.Endpoint) *corev1.Service {

func getEndpointService(objs *solvers.RoutingObjects, endpoint dwo.Endpoint) *corev1.Service {

WDYT?

+1 good call :)

dkwon17 · 2024-09-24T18:59:20Z

controllers/devworkspace/solver/che_routing.go

 	wsRouteConfig := gateway.CreateEmptyTraefikConfig()

 	commonService := getCommonService(objs, routing.Spec.DevWorkspaceId)
 	if commonService == nil {
-		return nil
+		return nil, fmt.Errorf("could not find the common service for workspace '%s'", routing.Spec.DevWorkspaceId)


Can we order functions in the file like so?
exposeAllEndpoints
determineEndpointService
getEndpointService

I assume you mean just moving the functions around in the che_routing.go file right? If so, yes! Though I think it's worth also moving getCommonService

Yes, thank you

Done, though I might have gotten your order wrong (I was confused by determineEndpointService). Let me know if you want me to re-order things.

@dkwon17 did I correctly address this in my last commit fc373a1?

Could we update the function names?

getServiceForEndpoint and getEndpointService sound a bit too similar IMO, how about

getServiceForEndpoint to getEndpointService
getEndpointSerive to getService

?

getServiceForEndpoint and getEndpointService sound a bit too similar IMO,

I agree, what do you think about the renames in df6fd02?

getServiceForEndpoint -> getEndpointService

getEndpointService -> determineEndpointService (I think this makes it a bit more clear that we're getting the appropriate service to use for an endpoint)

Otherwise, I'll just change getEndpointService -> getService as you initially suggested :)

getServiceForEndpoint -> getEndpointService
getEndpointService -> determineEndpointService (I think this makes it a bit more clear that we're getting the appropriate service to use for an endpoint)

Ok, lets do that

Sounds good :) if you're +1 for this PR, I'll squash my fixup commit and it'll be good to merge

AObuchow · 2024-09-25T14:27:51Z

/retest-required

tolusha · 2024-10-02T07:49:47Z

@AObuchow
For some reason I wasn't able to start a workspace (IDE doesn't appear) using the reproducer on a minikube

AObuchow · 2024-10-03T01:44:17Z

@AObuchow For some reason I wasn't able to start a workspace (IDE doesn't appear) using the reproducer on a minikube

@tolusha Thank you for bringing this to my attention. I've been going crazy trying to figure out why this is happening (I was able to reproduce this issue as well on minikube).

So far, it seems like the health endpoint is returning a 502, as I see the following in the ingress-nginx-controller logs:

ingress-nginx-controller-768f948f8f-kkfbv 10.244.0.1 - - [03/Oct/2024:01:33:49 +0000] "GET /user1/python/3100/healthz HTTP/2.0" 502 11 "-" "Go-http-client/2.0" 6 0.003 [eclipse-che-che-gateway-8080] [] 10.244.0.22:8080 11 0.003 502 39b3764a10341ac4068b2b5006253895

Similarly, in the DWO logs:

devworkspace-controller-manager-69f7956695-smkk2 devworkspace-controller {"level":"info","ts":"2024-10-03T01:34:28Z","logger":"controllers.DevWorkspace","msg":"Main URL server not ready","Request.Namespace":"user1-che","Request.Name":"python","devworkspace_id":"workspace7ce3bf9851524dc1","status-code":502}

Oddly enough, this issue seems to not occur if you use the UDI. For example, creating a workspace with the following URL works for me: https://github.com/AObuchow/python-endpoint-devfile-test/tree/main?image=quay.io%2Fdevfile%2Funiversal-developer-image%3Aubi8-latest

So I'm led to believe that the health check doesn't work on certain non-udi images when Che is deployed on minikube? The image used in my reproducer devfile was registry.access.redhat.com/ubi9/python-39:1-192 (from the devfile registry) This issue also occurs using the upstream Che-Operator image (so I don't think it's related to my PR, though I may be mistaken). I'll have to investigate further and report a bug about this, as it's very odd issue.

At some points in my testing, I also had errors like the following in the ingress-nginx-controller logs:

"invalid ingress configuration" err="host \"user1-python-code-redirect-2.192.168.49.2.nip.io\" and path \"/\" is already defined in ingress user1-che/workspacee32ce48b05694318-py-13132-code-redirect-2" ingress="user1-che/workspacebda168270ec8441d-py-13132-code-redirect-2"

But using the "Create New if Existing" option in the dashboard resolved it?... which is confusing as I compared the devworkspace, devworkspacetemplate, devworkspacerouting and ingresses created and everything seemed the same. However, for the workspace with the above error, only the code-redirect-1 ingress could be created (as the error describes it couldn't use the host & path for the code-redirect-2).

AObuchow · 2024-10-03T02:00:12Z

My above theory as to what was going wrong was incorrect. I've now gotten my minikube cluster into a state where devfiles using the UDI (that were working just moments ago) are now giving the incorrect ingress configuration error:

"invalid ingress configuration" err="host \"user1-python-code-redirect-2.192.168.49.2.nip.io\" and path \"/\" is already defined in ingress user1-che/workspacea705c32af9f348f4-tools-13132-code-redirect-2" ingress="user1-che/workspace6037a927113d4279-py-13132-code-redirect-2"

This is occuring while using the upstream image of Che Operator.

AObuchow · 2024-10-03T02:02:59Z

After terminating the ingress-nginx-controller pod on my cluster and allowing the deployment to recreate the pod, the issue seems to be fixed. So my new theory is that somehow the ingress-nginx-controller pod is getting into a weird/broken state.

AObuchow · 2024-10-04T04:21:45Z

@tolusha I'm still confused as to what's going on, so I opened eclipse-che/che#23179.
For now, I've updated the reproducer devfile in the PR description to use the UDI as the tooling image, which seems to work correctly on Minikube.

When you have a moment, please test using the above devfile - thank you :)

openshift-ci · 2024-10-08T18:19:29Z

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: AObuchow, dkwon17, tolusha

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Signed-off-by: Andrew Obuchowicz <[email protected]>

devstudio-release · 2024-10-09T15:29:07Z

Build 3.18 :: operator-bundle_3.x/3657: Console, Changes, Git Data

devstudio-release · 2024-10-09T15:37:37Z

Build 3.18 :: sync-to-downstream_3.x/7802: Console, Changes, Git Data

devstudio-release · 2024-10-09T15:42:38Z

Build 3.18 :: get-sources-rhpkg-container-build_3.x/7809: Console, Changes, Git Data

devstudio-release · 2024-10-09T16:46:28Z

Build 3.18 :: push-latest-container-to-quay_3.x/4974: Console, Changes, Git Data

devstudio-release · 2024-10-09T16:53:52Z

Build 3.18 :: get-sources-rhpkg-container-build_3.x/7809:

devspaces-operator-bundle : 3.x :: Build 64923661 : quay.io/devspaces/devspaces-operator-bundle:3.18-8
SUCCESS; copied to quay; /DS_CI/push-latest-container-to-quay_3.x/4974 triggered;
Bundle CSV related images:
- quay.io/devspaces/code-rhel8:3.18-2
- quay.io/devspaces/configbump-rhel8:3.18-1
- quay.io/devspaces/dashboard-rhel8:3.18-2
- quay.io/devspaces/devspaces-rhel8-operator:3.18-5
- quay.io/devspaces/idea-rhel8:3.18-1
- quay.io/devspaces/pluginregistry-rhel8:3.18-3
- quay.io/devspaces/server-rhel8:3.18-2
- quay.io/devspaces/traefik-rhel8:3.18-1
= registry.redhat.io/devspaces/udi-rhel8:3.15-5.1724033655
- quay.io/devspaces/udi-rhel8:3.18-2
= registry.redhat.io/openshift4/ose-kube-rbac-proxy:v4.14.0-202409240108.p0.g1a646b9.assembly.stream.el8
= registry.redhat.io/openshift4/ose-oauth-proxy:v4.14.0-202409250238.p0.ga4a2f27.assembly.stream.el8
= registry.redhat.io/rhscl/mongodb-36-rhel7:1-50
= registry.redhat.io/ubi8/ubi-minimal:8.8-1072.1697626218

devstudio-release · 2024-10-09T16:53:56Z

Build 3.18 :: sync-to-downstream_3.x/7802:

Build container: devspaces-operator-bundle synced; /DS_CI/get-sources-rhpkg-container-build_3.x/7809 triggered; /job/DS_CI/job/dsc_3.x triggered;

devstudio-release · 2024-10-09T16:53:57Z

Build 3.18 :: operator-bundle_3.x/3657:

Upstream sync done; /DS_CI/sync-to-downstream_3.x/7802 triggered

devstudio-release · 2024-10-09T16:56:18Z

Build 3.18 :: copyIIBsToQuay/2835: Console, Changes, Git Data

devstudio-release · 2024-10-09T16:56:57Z

Build 3.18 :: dsc_3.x/2017: Console, Changes, Git Data

devstudio-release · 2024-10-09T20:12:25Z

Build 3.18 :: operator-bundle_3.x/3658: Console, Changes, Git Data

devstudio-release · 2024-10-09T20:15:57Z

Build 3.18 :: sync-to-downstream_3.x/7804: Console, Changes, Git Data

devstudio-release · 2024-10-09T20:20:27Z

Build 3.18 :: get-sources-rhpkg-container-build_3.x/7811: Console, Changes, Git Data

devstudio-release · 2024-10-09T21:24:17Z

Build 3.18 :: push-latest-container-to-quay_3.x/4976: Console, Changes, Git Data

devstudio-release · 2024-10-09T21:30:30Z

Build 3.18 :: get-sources-rhpkg-container-build_3.x/7811:

devspaces-operator-bundle : 3.x :: Build 64935730 : quay.io/devspaces/devspaces-operator-bundle:3.18-9
SUCCESS; copied to quay; /DS_CI/push-latest-container-to-quay_3.x/4976 triggered;
Bundle CSV related images:
- quay.io/devspaces/code-rhel8:3.18-3
- quay.io/devspaces/configbump-rhel8:3.18-1
- quay.io/devspaces/dashboard-rhel8:3.18-2
- quay.io/devspaces/devspaces-rhel8-operator:3.18-5
- quay.io/devspaces/idea-rhel8:3.18-1
- quay.io/devspaces/pluginregistry-rhel8:3.18-4
- quay.io/devspaces/server-rhel8:3.18-2
- quay.io/devspaces/traefik-rhel8:3.18-1
= registry.redhat.io/devspaces/udi-rhel8:3.15-5.1724033655
- quay.io/devspaces/udi-rhel8:3.18-2
= registry.redhat.io/openshift4/ose-kube-rbac-proxy:v4.14.0-202409240108.p0.g1a646b9.assembly.stream.el8
= registry.redhat.io/openshift4/ose-oauth-proxy:v4.14.0-202409250238.p0.ga4a2f27.assembly.stream.el8
= registry.redhat.io/rhscl/mongodb-36-rhel7:1-50
= registry.redhat.io/ubi8/ubi-minimal:8.8-1072.1697626218

devstudio-release · 2024-10-09T21:30:33Z

Build 3.18 :: sync-to-downstream_3.x/7804:

Build container: devspaces-operator-bundle synced; /DS_CI/get-sources-rhpkg-container-build_3.x/7811 triggered; /job/DS_CI/job/dsc_3.x triggered;

devstudio-release · 2024-10-09T21:30:34Z

Build 3.18 :: operator-bundle_3.x/3658:

Upstream sync done; /DS_CI/sync-to-downstream_3.x/7804 triggered

devstudio-release · 2024-10-09T21:30:35Z

Build 3.18 :: copyIIBsToQuay/2836: Console, Changes, Git Data

devstudio-release · 2024-10-09T21:31:41Z

Build 3.18 :: dsc_3.x/2018: Console, Changes, Git Data

devstudio-release · 2024-10-09T21:41:28Z

Build 3.18 :: dsc_3.x/2018:

3.18.0-CI

devstudio-release · 2024-10-10T11:03:45Z

Build 3.18 :: operator-bundle_3.x/3659: Console, Changes, Git Data

devstudio-release · 2024-10-10T11:07:28Z

Build 3.18 :: sync-to-downstream_3.x/7806: Console, Changes, Git Data

devstudio-release · 2024-10-10T11:11:59Z

Build 3.18 :: get-sources-rhpkg-container-build_3.x/7813: Console, Changes, Git Data

devstudio-release · 2024-10-10T11:26:49Z

Build 3.18 :: push-latest-container-to-quay_3.x/4978: Console, Changes, Git Data

devstudio-release · 2024-10-10T11:33:17Z

Build 3.18 :: get-sources-rhpkg-container-build_3.x/7813:

devspaces-operator-bundle : 3.x :: Build 64955594 : quay.io/devspaces/devspaces-operator-bundle:3.18-10
SUCCESS; copied to quay; /DS_CI/push-latest-container-to-quay_3.x/4978 triggered;
Bundle CSV related images:
- quay.io/devspaces/code-rhel8:3.18-3
- quay.io/devspaces/configbump-rhel8:3.18-1
- quay.io/devspaces/dashboard-rhel8:3.18-2
- quay.io/devspaces/devspaces-rhel8-operator:3.18-5
- quay.io/devspaces/idea-rhel8:3.18-1
- quay.io/devspaces/pluginregistry-rhel8:3.18-5
- quay.io/devspaces/server-rhel8:3.18-2
- quay.io/devspaces/traefik-rhel8:3.18-1
= registry.redhat.io/devspaces/udi-rhel8:3.15-5.1724033655
- quay.io/devspaces/udi-rhel8:3.18-2
= registry.redhat.io/openshift4/ose-kube-rbac-proxy:v4.14.0-202409240108.p0.g1a646b9.assembly.stream.el8
= registry.redhat.io/openshift4/ose-oauth-proxy:v4.14.0-202409250238.p0.ga4a2f27.assembly.stream.el8
= registry.redhat.io/rhscl/mongodb-36-rhel7:1-50
= registry.redhat.io/ubi8/ubi-minimal:8.8-1072.1697626218

devstudio-release · 2024-10-10T11:33:20Z

Build 3.18 :: sync-to-downstream_3.x/7806:

Build container: devspaces-operator-bundle synced; /DS_CI/get-sources-rhpkg-container-build_3.x/7813 triggered; /job/DS_CI/job/dsc_3.x triggered;

devstudio-release · 2024-10-10T11:33:22Z

Build 3.18 :: operator-bundle_3.x/3659:

Upstream sync done; /DS_CI/sync-to-downstream_3.x/7806 triggered

devstudio-release · 2024-10-10T11:33:22Z

Build 3.18 :: copyIIBsToQuay/2837: Console, Changes, Git Data

devstudio-release · 2024-10-10T11:37:43Z

Build 3.18 :: dsc_3.x/2019: Console, Changes, Git Data

devstudio-release · 2024-10-10T11:47:33Z

Build 3.18 :: dsc_3.x/2019:

3.18.0-CI

devstudio-release · 2024-10-10T11:59:57Z

Build 3.18 :: copyIIBsToQuay/2837:

3.18
arches = x86_64, s390x, ppc64le;
  * LATEST DS OPERATOR BUNDLE = <a href=https://quay.io/repository/devspaces/devspaces-operator-bundle?tab=tags>registry-proxy.engineering.redhat.com/rh-osbs/devspaces-operator-bundle:3.18-10
  * LATEST DWO OPERATOR BUNDLE = <a href=https://quay.io/repository/devworkspace/devworkspace-operator-bundle?tab=tags>registry-proxy.engineering.redhat.com/rh-osbs/devworkspace-operator-bundle:???
+ s390x-rhel8 IIB(s) copied:
  + <a href=https://quay.io/devspaces/iib:3.18-v4.17-835069- /tmp/getIIBsForBundle.sh -t PROD_VER [OPTIONS]-s390x>quay.io/devspaces/iib:3.18-v4.17-835069- /tmp/getIIBsForBundle.sh -t PROD_VER [OPTIONS]-s390x
  + quay.io/devspaces/iib:3.18-v4.17-s390x
  + <a href=https://quay.io/devspaces/iib:3.18-v4.16-835067- /tmp/getIIBsForBundle.sh -t PROD_VER [OPTIONS]-s390x>quay.io/devspaces/iib:3.18-v4.16-835067- /tmp/getIIBsForBundle.sh -t PROD_VER [OPTIONS]-s390x
  + quay.io/devspaces/iib:3.18-v4.16-s390x
  + <a href=https://quay.io/devspaces/iib:3.18-v4.15-835066- /tmp/getIIBsForBundle.sh -t PROD_VER [OPTIONS]-s390x>quay.io/devspaces/iib:3.18-v4.15-835066- /tmp/getIIBsForBundle.sh -t PROD_VER [OPTIONS]-s390x
  + quay.io/devspaces/iib:3.18-v4.15-s390x
  + <a href=https://quay.io/devspaces/iib:3.18-v4.14-835065- /tmp/getIIBsForBundle.sh -t PROD_VER [OPTIONS]-s390x>quay.io/devspaces/iib:3.18-v4.14-835065- /tmp/getIIBsForBundle.sh -t PROD_VER [OPTIONS]-s390x
  + quay.io/devspaces/iib:3.18-v4.14-s390x
  + <a href=https://quay.io/devspaces/iib:3.18-v4.13-835064- /tmp/getIIBsForBundle.sh -t PROD_VER [OPTIONS]-s390x>quay.io/devspaces/iib:3.18-v4.13-835064- /tmp/getIIBsForBundle.sh -t PROD_VER [OPTIONS]-s390x
  + quay.io/devspaces/iib:3.18-v4.13-s390x
  + <a href=https://quay.io/devspaces/iib:3.18-v4.12-835063- /tmp/getIIBsForBundle.sh -t PROD_VER [OPTIONS]-s390x>quay.io/devspaces/iib:3.18-v4.12-835063- /tmp/getIIBsForBundle.sh -t PROD_VER [OPTIONS]-s390x
  + quay.io/devspaces/iib:3.18-v4.12-s390x
+ ppc64le-rhel8 IIB(s) copied:
  + <a href=https://quay.io/devspaces/iib:3.18-v4.17-835069- /tmp/getIIBsForBundle.sh -t PROD_VER [OPTIONS]-ppc64le>quay.io/devspaces/iib:3.18-v4.17-835069- /tmp/getIIBsForBundle.sh -t PROD_VER [OPTIONS]-ppc64le
  + quay.io/devspaces/iib:3.18-v4.17-ppc64le
  + <a href=https://quay.io/devspaces/iib:3.18-v4.16-835067- /tmp/getIIBsForBundle.sh -t PROD_VER [OPTIONS]-ppc64le>quay.io/devspaces/iib:3.18-v4.16-835067- /tmp/getIIBsForBundle.sh -t PROD_VER [OPTIONS]-ppc64le
  + quay.io/devspaces/iib:3.18-v4.16-ppc64le
  + <a href=https://quay.io/devspaces/iib:3.18-v4.15-835066- /tmp/getIIBsForBundle.sh -t PROD_VER [OPTIONS]-ppc64le>quay.io/devspaces/iib:3.18-v4.15-835066- /tmp/getIIBsForBundle.sh -t PROD_VER [OPTIONS]-ppc64le
  + quay.io/devspaces/iib:3.18-v4.15-ppc64le
  + <a href=https://quay.io/devspaces/iib:3.18-v4.14-835065- /tmp/getIIBsForBundle.sh -t PROD_VER [OPTIONS]-ppc64le>quay.io/devspaces/iib:3.18-v4.14-835065- /tmp/getIIBsForBundle.sh -t PROD_VER [OPTIONS]-ppc64le
  + quay.io/devspaces/iib:3.18-v4.14-ppc64le
  + <a href=https://quay.io/devspaces/iib:3.18-v4.13-835064- /tmp/getIIBsForBundle.sh -t PROD_VER [OPTIONS]-ppc64le>quay.io/devspaces/iib:3.18-v4.13-835064- /tmp/getIIBsForBundle.sh -t PROD_VER [OPTIONS]-ppc64le
  + quay.io/devspaces/iib:3.18-v4.13-ppc64le
  + <a href=https://quay.io/devspaces/iib:3.18-v4.12-835063- /tmp/getIIBsForBundle.sh -t PROD_VER [OPTIONS]-ppc64le>quay.io/devspaces/iib:3.18-v4.12-835063- /tmp/getIIBsForBundle.sh -t PROD_VER [OPTIONS]-ppc64le
  + quay.io/devspaces/iib:3.18-v4.12-ppc64le
+ x86_64-rhel8 IIB(s) copied:
  + <a href=https://quay.io/devspaces/iib:3.18-v4.17-835069- /tmp/getIIBsForBundle.sh -t PROD_VER [OPTIONS]-x86_64>quay.io/devspaces/iib:3.18-v4.17-835069- /tmp/getIIBsForBundle.sh -t PROD_VER [OPTIONS]-x86_64
  + quay.io/devspaces/iib:3.18-v4.17-x86_64
  + <a href=https://quay.io/devspaces/iib:3.18-v4.16-835067- /tmp/getIIBsForBundle.sh -t PROD_VER [OPTIONS]-x86_64>quay.io/devspaces/iib:3.18-v4.16-835067- /tmp/getIIBsForBundle.sh -t PROD_VER [OPTIONS]-x86_64
  + quay.io/devspaces/iib:3.18-v4.16-x86_64
  + <a href=https://quay.io/devspaces/iib:3.18-v4.15-835066- /tmp/getIIBsForBundle.sh -t PROD_VER [OPTIONS]-x86_64>quay.io/devspaces/iib:3.18-v4.15-835066- /tmp/getIIBsForBundle.sh -t PROD_VER [OPTIONS]-x86_64
  + quay.io/devspaces/iib:3.18-v4.15-x86_64
  + <a href=https://quay.io/devspaces/iib:3.18-v4.14-835065- /tmp/getIIBsForBundle.sh -t PROD_VER [OPTIONS]-x86_64>quay.io/devspaces/iib:3.18-v4.14-835065- /tmp/getIIBsForBundle.sh -t PROD_VER [OPTIONS]-x86_64
  + quay.io/devspaces/iib:3.18-v4.14-x86_64
  + <a href=https://quay.io/devspaces/iib:3.18-v4.13-835064- /tmp/getIIBsForBundle.sh -t PROD_VER [OPTIONS]-x86_64>quay.io/devspaces/iib:3.18-v4.13-835064- /tmp/getIIBsForBundle.sh -t PROD_VER [OPTIONS]-x86_64
  + quay.io/devspaces/iib:3.18-v4.13-x86_64
  + <a href=https://quay.io/devspaces/iib:3.18-v4.12-835063- /tmp/getIIBsForBundle.sh -t PROD_VER [OPTIONS]-x86_64>quay.io/devspaces/iib:3.18-v4.12-835063- /tmp/getIIBsForBundle.sh -t PROD_VER [OPTIONS]-x86_64
  + quay.io/devspaces/iib:3.18-v4.12-x86_64

AObuchow requested review from SDawley, tolusha and ibuziuk as code owners September 20, 2024 04:27

openshift-merge-robot added the needs-rebase label Sep 24, 2024

AObuchow added 3 commits September 24, 2024 11:34

fix: use correct service for discoverable endpoints

6de0dee

Fix eclipse-che/che#23061 Signed-off-by: Andrew Obuchowicz <[email protected]>

chore: add tests for endpoint-specific service

5fdb10a

Signed-off-by: Andrew Obuchowicz <[email protected]>

chore: catch and return errors when exposing endpoints

914c14c

Signed-off-by: Andrew Obuchowicz <[email protected]>

AObuchow force-pushed the endpoint-service-fix branch from f28ebe4 to 914c14c Compare September 24, 2024 15:35

openshift-merge-robot removed the needs-rebase label Sep 24, 2024

dkwon17 reviewed Sep 24, 2024

View reviewed changes

tolusha approved these changes Oct 4, 2024

View reviewed changes

openshift-ci bot assigned tolusha Oct 4, 2024

openshift-ci bot added lgtm and removed lgtm labels Oct 4, 2024

AObuchow requested a review from dkwon17 October 7, 2024 16:58

dkwon17 approved these changes Oct 8, 2024

View reviewed changes

openshift-ci bot assigned dkwon17 Oct 8, 2024

openshift-ci bot added the lgtm label Oct 8, 2024

chore: organize some functions declaration ordering in che_routing.go

3dc6d58

Signed-off-by: Andrew Obuchowicz <[email protected]>

	func getServiceForEndpoint(objs solvers.RoutingObjects, endpoint dwo.Endpoint) corev1.Service {
	func getEndpointService(objs solvers.RoutingObjects, endpoint dwo.Endpoint) corev1.Service {

Use endpoint-specific service for discoverable endpoints #1903

Use endpoint-specific service for discoverable endpoints #1903

Conversation

AObuchow commented Sep 20, 2024 • edited Loading

What does this PR do?

Screenshot/screencast of this PR

What issues does this PR fix or reference?

How to test this PR?

PR Checklist

Reviewers

AObuchow commented Sep 20, 2024

AObuchow commented Sep 24, 2024

AObuchow commented Sep 24, 2024

AObuchow commented Sep 24, 2024

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

AObuchow commented Sep 25, 2024

tolusha commented Oct 2, 2024

AObuchow commented Oct 3, 2024

AObuchow commented Oct 3, 2024 • edited Loading

AObuchow commented Oct 3, 2024

AObuchow commented Oct 4, 2024

openshift-ci bot commented Oct 8, 2024

devstudio-release commented Oct 9, 2024

devstudio-release commented Oct 9, 2024

devstudio-release commented Oct 9, 2024

devstudio-release commented Oct 9, 2024

devstudio-release commented Oct 9, 2024

devstudio-release commented Oct 9, 2024

devstudio-release commented Oct 9, 2024

devstudio-release commented Oct 9, 2024

devstudio-release commented Oct 9, 2024

devstudio-release commented Oct 9, 2024

devstudio-release commented Oct 9, 2024

devstudio-release commented Oct 9, 2024

devstudio-release commented Oct 9, 2024

devstudio-release commented Oct 9, 2024

devstudio-release commented Oct 9, 2024

devstudio-release commented Oct 9, 2024

devstudio-release commented Oct 9, 2024

devstudio-release commented Oct 9, 2024

devstudio-release commented Oct 9, 2024

devstudio-release commented Oct 10, 2024

devstudio-release commented Oct 10, 2024

devstudio-release commented Oct 10, 2024

devstudio-release commented Oct 10, 2024

devstudio-release commented Oct 10, 2024

devstudio-release commented Oct 10, 2024

devstudio-release commented Oct 10, 2024

devstudio-release commented Oct 10, 2024

devstudio-release commented Oct 10, 2024

devstudio-release commented Oct 10, 2024

devstudio-release commented Oct 10, 2024

AObuchow commented Sep 20, 2024 •

edited

Loading

AObuchow commented Oct 3, 2024 •

edited

Loading