Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade react-router-dom #1189

Merged
merged 11 commits into from
Sep 25, 2024
Merged

Upgrade react-router-dom #1189

merged 11 commits into from
Sep 25, 2024

Conversation

akurinnoy
Copy link
Contributor

What does this PR do?

This PR upgrades the react-router-dom to v6.

Screenshot/screencast of this PR

What issues does this PR fix or reference?

resolve eclipse-che/che#23136

Is it tested? How?

Unit tests

Release Notes

Docs PR

Copy link

openshift-ci bot commented Sep 11, 2024

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@che-bot
Copy link
Contributor

che-bot commented Sep 11, 2024

Click here to review and test in web IDE: Contribute

Copy link

codecov bot commented Sep 11, 2024

Codecov Report

Attention: Patch coverage is 96.12903% with 18 lines in your changes missing coverage. Please review.

Project coverage is 91.44%. Comparing base (e1fe428) to head (266aa18).
Report is 9 commits behind head on main.

Files with missing lines Patch % Lines
...oard-frontend/src/pages/WorkspaceDetails/index.tsx 72.97% 10 Missing ⚠️
...rontend/src/components/WorkspaceProgress/index.tsx 96.07% 2 Missing ⚠️
...dashboard-frontend/src/Layout/Navigation/index.tsx 0.00% 1 Missing ⚠️
...paceProgress/StartingSteps/OpenWorkspace/index.tsx 75.00% 1 Missing ⚠️
...aceProgress/StartingSteps/StartWorkspace/index.tsx 85.71% 1 Missing ⚠️
...ages/dashboard-frontend/src/pages/Loader/index.tsx 90.00% 1 Missing ⚠️
...hboard-frontend/src/pages/WorkspacesList/index.tsx 83.33% 1 Missing ⚠️
...ges/dashboard-frontend/src/store/configureStore.ts 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1189      +/-   ##
==========================================
+ Coverage   91.33%   91.44%   +0.11%     
==========================================
  Files         439      441       +2     
  Lines       45404    45516     +112     
  Branches     3149     3139      -10     
==========================================
+ Hits        41468    41623     +155     
+ Misses       3936     3893      -43     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

Docker image build succeeded: quay.io/eclipse/che-dashboard:pr-1189

kubectl patch command
kubectl patch -n eclipse-che "checluster/eclipse-che" --type=json -p="[{"op": "replace", "path": "/spec/components/dashboard/deployment", "value": {containers: [{image: "quay.io/eclipse/che-dashboard:pr-1189", name: che-dashboard}]}}]"

@akurinnoy akurinnoy marked this pull request as ready for review September 16, 2024 11:16
Copy link

Docker image build succeeded: quay.io/eclipse/che-dashboard:pr-1189

kubectl patch command
kubectl patch -n eclipse-che "checluster/eclipse-che" --type=json -p="[{"op": "replace", "path": "/spec/components/dashboard/deployment", "value": {containers: [{image: "quay.io/eclipse/che-dashboard:pr-1189", name: che-dashboard}]}}]"

@ibuziuk
Copy link
Member

ibuziuk commented Sep 17, 2024

@akurinnoy looks like quite a few PR checks are failing atm

@akurinnoy
Copy link
Contributor Author

@ibuziuk should be fixed now

Copy link

Docker image build succeeded: quay.io/eclipse/che-dashboard:pr-1189

kubectl patch command
kubectl patch -n eclipse-che "checluster/eclipse-che" --type=json -p="[{"op": "replace", "path": "/spec/components/dashboard/deployment", "value": {containers: [{image: "quay.io/eclipse/che-dashboard:pr-1189", name: che-dashboard}]}}]"

@akurinnoy akurinnoy self-assigned this Sep 18, 2024
Copy link
Contributor

@olexii4 olexii4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

openshift-ci bot commented Sep 25, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: akurinnoy, olexii4

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@olexii4
Copy link
Contributor

olexii4 commented Sep 25, 2024

These changes includes a fix for https://issues.redhat.com/browse/CRW-7211

@akurinnoy akurinnoy merged commit d48136f into main Sep 25, 2024
18 checks passed
@akurinnoy akurinnoy deleted the upgrade-react-router-dom branch September 25, 2024 14:13
@devstudio-release
Copy link

Build 3.17 :: dashboard_3.x/553: Console, Changes, Git Data

@devstudio-release
Copy link

@devstudio-release
Copy link

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Upgrade react-router-dom
5 participants