-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade react-router-dom
#1189
Upgrade react-router-dom
#1189
Conversation
Skipping CI for Draft Pull Request. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1189 +/- ##
==========================================
+ Coverage 91.33% 91.44% +0.11%
==========================================
Files 439 441 +2
Lines 45404 45516 +112
Branches 3149 3139 -10
==========================================
+ Hits 41468 41623 +155
+ Misses 3936 3893 -43 ☔ View full report in Codecov by Sentry. |
Docker image build succeeded: quay.io/eclipse/che-dashboard:pr-1189 kubectl patch commandkubectl patch -n eclipse-che "checluster/eclipse-che" --type=json -p="[{"op": "replace", "path": "/spec/components/dashboard/deployment", "value": {containers: [{image: "quay.io/eclipse/che-dashboard:pr-1189", name: che-dashboard}]}}]" |
Docker image build succeeded: quay.io/eclipse/che-dashboard:pr-1189 kubectl patch commandkubectl patch -n eclipse-che "checluster/eclipse-che" --type=json -p="[{"op": "replace", "path": "/spec/components/dashboard/deployment", "value": {containers: [{image: "quay.io/eclipse/che-dashboard:pr-1189", name: che-dashboard}]}}]" |
@akurinnoy looks like quite a few PR checks are failing atm |
Signed-off-by: Oleksii Kurinnyi <[email protected]>
Signed-off-by: Oleksii Kurinnyi <[email protected]>
Signed-off-by: Oleksii Kurinnyi <[email protected]>
Signed-off-by: Oleksii Kurinnyi <[email protected]>
Signed-off-by: Oleksii Kurinnyi <[email protected]>
Signed-off-by: Oleksii Kurinnyi <[email protected]>
Signed-off-by: Oleksii Kurinnyi <[email protected]>
Signed-off-by: Oleksii Kurinnyi <[email protected]>
Signed-off-by: Oleksii Kurinnyi <[email protected]>
Signed-off-by: Oleksii Kurinnyi <[email protected]>
Signed-off-by: Oleksii Kurinnyi <[email protected]>
61c9f9e
to
266aa18
Compare
@ibuziuk should be fixed now |
Docker image build succeeded: quay.io/eclipse/che-dashboard:pr-1189 kubectl patch commandkubectl patch -n eclipse-che "checluster/eclipse-che" --type=json -p="[{"op": "replace", "path": "/spec/components/dashboard/deployment", "value": {containers: [{image: "quay.io/eclipse/che-dashboard:pr-1189", name: che-dashboard}]}}]" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: akurinnoy, olexii4 The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
These changes includes a fix for https://issues.redhat.com/browse/CRW-7211 |
Build 3.17 :: dashboard_3.x/553: Console, Changes, Git Data |
Build 3.17 :: sync-to-downstream_3.x/7733: Console, Changes, Git Data |
What does this PR do?
This PR upgrades the
react-router-dom
to v6.Screenshot/screencast of this PR
What issues does this PR fix or reference?
resolve eclipse-che/che#23136
Is it tested? How?
Unit tests
Release Notes
Docs PR