Remove conditions before restart a workspace

[olexii4]

What does this PR do?

Remove conditions before restart a workspace

Screenshot/screencast of this PR

What issues does this PR fix or reference?

https://issues.redhat.com/browse/CRW-6587

Is it tested? How?

1. Deploy Eclipse-Che with the image from this PR.
2. Open Create Workspace page on the dashboard.
3. Put https://raw.githubusercontent.com/dmytro-ndp/devfile-with-typo/main/devfile.yaml factory into Git repo URL.
4. Click Create & Open.
5. The workspace should fails with an error ImagePullBackOff.
6. Open a new tab with the swagger link {CHE-Server}/dashboard/api/swagger.
7. And apply the patch to fix the target devvorkspace:

[
 {
   "op": "replace",
   "path": "/spec/template/components/0/container/image",
   "value": "quay.io/devfile/universal-developer-image:ubi8-latest"
  }
]

8. Open Starting workspace page and click Restart
9. The target workspace should restart without any warnings or errors.

Release Notes

Docs PR

[che-bot]

Click here to review and test in web IDE:

[github-actions]

Docker image build succeeded: quay.io/eclipse/che-dashboard:pr-1188

kubectl patch command

kubectl patch -n eclipse-che "checluster/eclipse-che" --type=json -p="[{"op": "replace", "path": "/spec/components/dashboard/deployment", "value": {containers: [{image: "quay.io/eclipse/che-dashboard:pr-1188", name: che-dashboard}]}}]"

[dmytro-ndp]

@olexii4 : hello

Possible PR test scenario:

1. Create workspace with devfile.yaml having wrong container image address, e.g. https://github.com/dmytro-ndp/devfile-with-typo/blob/main/devfile.yaml
2. Run workspace and reproduce start workspace error
3. Fix error in DevWorkspace yaml of workspace
4. Start workspace again and make sure there is no previous start workspace error displayed on the page during the new workspace startup

[github-actions]

Docker image build succeeded: quay.io/eclipse/che-dashboard:pr-1188

kubectl patch command

kubectl patch -n eclipse-che "checluster/eclipse-che" --type=json -p="[{"op": "replace", "path": "/spec/components/dashboard/deployment", "value": {containers: [{image: "quay.io/eclipse/che-dashboard:pr-1188", name: che-dashboard}]}}]"

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.45%. Comparing base (e1fe428) to head (eade35e).
Report is 2 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #1188      +/-   ##
==========================================
+ Coverage   91.33%   91.45%   +0.12%     
==========================================
  Files         439      439              
  Lines       45404    45433      +29     
  Branches     3149     3156       +7     
==========================================
+ Hits        41468    41553      +85     
+ Misses       3936     3880      -56     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[github-actions]

Docker image build succeeded: quay.io/eclipse/che-dashboard:pr-1188

kubectl patch command

kubectl patch -n eclipse-che "checluster/eclipse-che" --type=json -p="[{"op": "replace", "path": "/spec/components/dashboard/deployment", "value": {containers: [{image: "quay.io/eclipse/che-dashboard:pr-1188", name: che-dashboard}]}}]"

[openshift-ci]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: akurinnoy, ibuziuk, olexii4

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[devstudio-release]

Build 3.17 :: dashboard_3.x/546: Console, Changes, Git Data

[devstudio-release]

Build 3.17 :: sync-to-downstream_3.x/7709: Console, Changes, Git Data

[devstudio-release]

Build 3.17 :: get-sources-rhpkg-container-build_3.x/7701: Console, Changes, Git Data