fixup! Add passphrase input to the add SSH key dialog

eclipse-che · Sep 16, 2024 · e35bccb · e35bccb
1 parent aff295c
commit e35bccb
Show file tree

Hide file tree

Showing 4 changed files with 4 additions and 3 deletions.
diff --git a/...es/dashboard-backend/src/devworkspaceClient/services/sshKeysApi/__tests__/helpers.spec.ts b/...es/dashboard-backend/src/devworkspaceClient/services/sshKeysApi/__tests__/helpers.spec.ts
@@ -142,7 +142,7 @@ describe('Helpers for SSH Keys API', () => {
         'dwo_ssh_key.pub': token.keyPub,
         dwo_ssh_key: token.key,
         ssh_config: btoa(SSH_CONFIG),
-        passphrase: 'passphrase',
+        passphrase: btoa('passphrase'),
       },
       kind: 'Secret',
       metadata: {

diff --git a/packages/dashboard-backend/src/devworkspaceClient/services/sshKeysApi/helpers.ts b/packages/dashboard-backend/src/devworkspaceClient/services/sshKeysApi/helpers.ts
@@ -89,7 +89,7 @@ export function toSecret(namespace: string, sshKey: api.NewSshKey): SshKeySecret
       'dwo_ssh_key.pub': sshKey.keyPub,
       dwo_ssh_key: sshKey.key,
       ssh_config: btoa(SSH_CONFIG),
-      ...(sshKey.passphrase && { passphrase: sshKey.passphrase }),
+      ...(sshKey.passphrase && { passphrase: btoa(sshKey.passphrase) }),
     },
   };
 }
diff --git a/...eferences/SshKeys/AddModal/Form/SshPassphrase/__tests__/__snapshots__/index.spec.tsx.snap b/...eferences/SshKeys/AddModal/Form/SshPassphrase/__tests__/__snapshots__/index.spec.tsx.snap
@@ -39,7 +39,7 @@ exports[`SshPassphrase snapshot 1`] = `
         onFocus={[Function]}
         placeholder="Enter passphrase (optional)"
         required={false}
-        type="text"
+        type="password"
       />
       
     </div>

diff --git a/...ashboard-frontend/src/pages/UserPreferences/SshKeys/AddModal/Form/SshPassphrase/index.tsx b/...ashboard-frontend/src/pages/UserPreferences/SshKeys/AddModal/Form/SshPassphrase/index.tsx
@@ -44,6 +44,7 @@ export class SshPassphrase extends React.Component<Props, State> {
           aria-label="Passphrase"
           placeholder="Enter passphrase (optional)"
           onChange={passphrase => this.onChange(passphrase)}
+          type="password"
         />
       </FormGroup>
     );