-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Custom editor support #39
Conversation
@thegecko, just changed the wording of your description a bit so GitHub didn't think that this issue would fix the VSCode issue. :-) |
@thegecko, do want to merge this for easier distribution, or just have it available in PR form as an example for reference? |
I'm keen it gets merged and released with our first release. It creates a good test example for the VS Code changes |
Alright, I'll build a VSCode variant and give it a good test today. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
General functionality looks good. Even plays nicely with the preferences @kenneth-marut-work implemented. Just a minor issue with the URI encoding, but in my testing, using decodeUriComponent
did indeed fix that.
What it does
This PR adds initial support for opening the memory inspector using VS Code's build in
memory
button. It follows the pattern used by the existing hexedit extension.How to test
Opening the inspector in this way will be possible when this issue is resolved in the VSCode repository: microsoft/vscode#155597
This will require a change in VS Code to allow a user to specify the settings for the memory viewer to use, however I'd like to use this extension as an example when I open that PR.
To test this at the moment, you need to build a custom VS Code, manually changing the extension ID and editor ID found here: https://github.com/microsoft/vscode/blob/e933c1d7b293f77565763d4a85154e1cb1b4cf45/src/vs/workbench/contrib/debug/browser/variablesView.ts#L527
to be:
Review checklist
Reminder for reviewers