Reduce the number of dangling FileListeners due to collect operation.

ecki · May 23, 2024 · 60ae76f · 60ae76f
1 parent 4c0d55a
commit 60ae76f
Showing 1 changed file with 13 additions and 4 deletions.
diff --git a/...gestarc/src/main/java/com/seeburger/vfs2/provider/digestarc/DarcFileCollectOperation.java b/...gestarc/src/main/java/com/seeburger/vfs2/provider/digestarc/DarcFileCollectOperation.java
@@ -48,11 +48,15 @@ public DarcFileCollectOperation(FileObject root)
     public void process()
         throws FileSystemException
     {
-        if (root instanceof DarcFileObject)
+        if !(root instanceof DarcFileObject)
+        {
+            return;
+        }
+
+        final DarcFileObject darcFile = (DarcFileObject) root;
+        final FileObject delegateFile = darcFile.getDelegateFile();
+        try
         {
-            DarcFileObject darcFile = (DarcFileObject) root;
-            FileObject delegateFile = darcFile.getDelegateFile();
-
             filesList.add(delegateFile.getName().getURI());
 
             if (darcFile.getType() == FileType.FOLDER)
@@ -70,5 +74,10 @@ public void process()
                 }
             }
         }
+        finally
+        {
+            // we can speed up freeing this listener darcFile is no longer needed
+            delegateFile.getFileSystem().removeListener(delegateFile, darcFile);
+        }
     }
 }