minor

DESCRIPTION

@@ -1,7 +1,7 @@
 Type: Package
 Package: performance
 Title: Assessment of Regression Models Performance
-Version: 0.12.3.1
+Version: 0.12.3.2
 Authors@R:
     c(person(given = "Daniel",
              family = "Lüdecke",

R/check_dag.R

@@ -248,7 +248,7 @@ check_dag <- function(...,
     adjustment_set <- unlist(dagitty::adjustmentSets(dag, effect = x), use.names = FALSE)
     adjustment_nodes <- unlist(dagitty::adjustedNodes(dag), use.names = FALSE)
     minimal_adjustments <- as.list(dagitty::adjustmentSets(dag, effect = x))
-    collider <- adjustment_nodes[vapply(adjustment_nodes, ggdag::is_collider, logical(1), .dag = dag)]
+    collider <- adjustment_nodes[vapply(adjustment_nodes, ggdag::is_collider, logical(1), .dag = dag, downstream = FALSE)]
     if (!length(collider)) {
       # if we don't have colliders, set to NULL
       collider <- NULL
@@ -356,7 +356,7 @@ print.check_dag <- function(x, ...) {
   # minimal adjustment sets for direct and total effect identical?
   # Then print only once
   if (identical(attributes(x)$check_direct$minimal_adjustments, attributes(x)$check_total$minimal_adjustments)) {
-    .print_dag_results(attributes(x)$check_direct, x, "direct and total", "all")
+    .print_dag_results(attributes(x)$check_direct, x, "direct and total", "all", collider)
   } else {
     for (i in c("direct", "total")) {
       if (i == "direct") {
@@ -390,10 +390,10 @@ print.check_dag <- function(x, ...) {
       "`."
     )
   } else if (!is.null(collider)) {
-    # Scenario 2: adjusted for (downstream) collider
+    # Scenario 2: adjusted for collider
     msg <- paste0(
       insight::color_text("Incorrectly adjusted!", "red"),
-      "\nYour model adjusts for a (downstream) collider, ",
+      "\nYour model adjusts for a collider, ",
       insight::color_text(datawizard::text_concatenate(collider, enclose = "`"), "cyan"),
       ". To estimate the ", i, " effect, do ",
       insight::color_text("not", "italic"),

tests/testthat/_snaps/check_dag.md

@@ -265,11 +265,11 @@
       Identification of direct effects
       
       Incorrectly adjusted!
-      Your model adjusts for a (downstream) collider, `sm_h_total_kid`. To estimate the direct effect, do not adjust for it, to avoid collider-bias.
+      Your model adjusts for a collider, `sm_h_total_kid`. To estimate the direct effect, do not adjust for it, to avoid collider-bias.
       
       Identification of total effects
       
       Incorrectly adjusted!
-      Your model adjusts for a (downstream) collider, `sm_h_total_kid`. To estimate the total effect, do not adjust for it, to avoid collider-bias.
+      Your model adjusts for a collider, `sm_h_total_kid`. To estimate the total effect, do not adjust for it, to avoid collider-bias.