Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prepare CRAN release #936

Merged
merged 5 commits into from
Oct 2, 2024
Merged

Prepare CRAN release #936

merged 5 commits into from
Oct 2, 2024

Conversation

strengejacke
Copy link
Member

No description provided.

@strengejacke
Copy link
Member Author

Something in R-devel has changed, which renders the Author field in the DESCRIPTION file differently. Anyone an idea how to fix this?

* checking DESCRIPTION meta-information ... NOTE
Author field differs from that derived from Authors@R
  Author:    'Daniel Lüdecke [aut, cre] (<https://orcid.org/0000-0002-8895-3206>, @strengejacke), Dominique Makowski [aut, ctb] (<https://orcid.org/0000-0001-5375-9967>, @Dom_Makowski), Indrajeet Patil [aut, ctb] (<https://orcid.org/0000-0003-1995-6531>, @patilindrajeets), Philip Waggoner [aut, ctb] (<https://orcid.org/0000-0002-7825-7573>), Mattan S. Ben-Shachar [aut, ctb] (<https://orcid.org/0000-0002-4287-4801>), Brenton M. Wiernik [aut, ctb] (<https://orcid.org/0000-0001-9560-6336>, @bmwiernik), Vincent Arel-Bundock [aut, ctb] (<https://orcid.org/0000-0003-2042-7063>), Etienne Bacher [aut, ctb] (<https://orcid.org/0000-0002-9271-5075>), Alex Hayes [rev] (<https://orcid.org/0000-0002-4985-5160>), Grant McDermott [ctb] (<https://orcid.org/0000-0001-7883-8573>), Rémi Thériault [ctb] (<https://orcid.org/0000-0003-4315-6788>, @rempsyc), Alex Reinhart [ctb] (<https://orcid.org/0000-0002-6658-514X>)'
  Authors@R: 'Daniel Lüdecke [aut, cre] (ORCID: <https://orcid.org/0000-0002-8895-3206>, Twitter: @strengejacke), Dominique Makowski [aut, ctb] (ORCID: <https://orcid.org/0000-0001-5375-9967>, Twitter: @Dom_Makowski), Indrajeet Patil [aut, ctb] (ORCID: <https://orcid.org/0000-0003-1995-6531>, Twitter: @patilindrajeets), Philip Waggoner [aut, ctb] (ORCID: <https://orcid.org/0000-0002-7825-7573>), Mattan S. Ben-Shachar [aut, ctb] (ORCID: <https://orcid.org/0000-0002-4287-4801>), Brenton M. Wiernik [aut, ctb] (ORCID: <https://orcid.org/0000-0001-9560-6336>, Twitter: @bmwiernik), Vincent Arel-Bundock [aut, ctb] (ORCID: <https://orcid.org/0000-0003-2042-7063>), Etienne Bacher [aut, ctb] (ORCID: <https://orcid.org/0000-0002-9271-5075>), Alex Hayes [rev] (ORCID: <https://orcid.org/0000-0002-4985-5160>), Grant McDermott [ctb] (ORCID: <https://orcid.org/0000-0001-7883-8573>), Rémi Thériault [ctb] (ORCID: <https://orcid.org/0000-0003-4315-6788>, Twitter: @rempsyc), Alex Reinhart [ctb] (ORCID: <https://orcid.org/0000-0002-6658-514X>)'

@etiennebacher @IndrajeetPatil

@strengejacke
Copy link
Member Author

Ok, this is obviously the DESCRIPTION file included in the tar-ball of the package, which is created using devtools::build():

Type: Package
Package: insight
Title: Easy Access to Model Information for Various Model Objects
Version: 0.20.5
Authors@R: 
    c(person(given = "Daniel",
             family = "Lüdecke",
             role = c("aut", "cre"),
             email = "[email protected]",
             comment = c(ORCID = "0000-0002-8895-3206", Twitter = "@strengejacke")),
      person(given = "Dominique",
             family = "Makowski",
             role = c("aut", "ctb"),
             email = "[email protected]",
             comment = c(ORCID = "0000-0001-5375-9967", Twitter = "@Dom_Makowski")),
      person(given = "Indrajeet",
             family = "Patil",
             role = c("aut", "ctb"),
             email = "[email protected]",
             comment = c(ORCID = "0000-0003-1995-6531", Twitter = "@patilindrajeets")),
      person(given = "Philip",
             family = "Waggoner",
             role = c("aut", "ctb"),
             email = "[email protected]",
             comment = c(ORCID = "0000-0002-7825-7573")),
      person(given = "Mattan S.",
             family = "Ben-Shachar",
             role = c("aut", "ctb"),
             email = "[email protected]",
             comment = c(ORCID = "0000-0002-4287-4801")),
      person(given = "Brenton M.",
             family = "Wiernik",
             role = c("aut", "ctb"),
             email = "[email protected]",
             comment = c(ORCID = "0000-0001-9560-6336", Twitter = "@bmwiernik")),
      person(given = "Vincent",
             family = "Arel-Bundock",
             email = "[email protected]",
             role = c("aut", "ctb"),
             comment = c(ORCID = "0000-0003-2042-7063")),
      person(given = "Etienne",
             family = "Bacher",
             email = "[email protected]",
             role = c("aut", "ctb"),
             comment = c(ORCID = "0000-0002-9271-5075")),
      person(given = "Alex",
             family = "Hayes",
             role = c("rev"),
             email = "[email protected]",
             comment = c(ORCID = "0000-0002-4985-5160")),
      person(given = "Grant",
             family = "McDermott",
             role = c("ctb"),
             email = "[email protected]",
             comment = c(ORCID = "0000-0001-7883-8573")),
      person(given = "Rémi",
             family = "Thériault",
             role = "ctb",
             email = "[email protected]",
             comment = c(ORCID = "0000-0003-4315-6788", Twitter = "@rempsyc")),
      person(given = "Alex",
             family = "Reinhart",
             role = "ctb",
             email = "[email protected]",
             comment = c(ORCID = "0000-0002-6658-514X")))
Maintainer: Daniel Lüdecke <[email protected]>
Description: A tool to provide an easy, intuitive and consistent
    access to information contained in various R models, like model
    formulas, model terms, information about random effects, data that was
    used to fit the model or data from response variables. 'insight'
    mainly revolves around two types of functions: Functions that find
    (the names of) information, starting with 'find_', and functions that
    get the underlying data, starting with 'get_'. The package has a
    consistent syntax and works with many different model objects, where
    otherwise functions to access these information are missing.
License: GPL-3
URL: https://easystats.github.io/insight/
BugReports: https://github.com/easystats/insight/issues
Depends: R (>= 3.6)
Imports: methods, stats, utils
Suggests: AER, afex, aod, BayesFactor, bayestestR, bbmle, bdsmatrix,
        betareg, bife, biglm, BH, blavaan (>= 0.5-5), blme, boot, brms,
        broom, car, carData, censReg, cgam, clubSandwich, cobalt,
        coxme, cplm, crch, curl, datawizard, effectsize, emmeans, epiR,
        estimatr, feisr, fixest (>= 0.11.2), fungible, fwb, gam,
        gamlss, gamlss.data, gamm4, gbm, gee, geepack, geoR, ggeffects,
        GLMMadaptive, glmmTMB (>= 1.1.10), glmtoolbox, gmnl, grDevices,
        gt, httptest2, httr, httr2, interp, ivreg, JM, knitr, lavaan,
        lavaSearch2, lfe, lme4, lmerTest, lmtest, logistf, logitr,
        marginaleffects, MASS, Matrix, mclogit, mclust, MCMCglmm,
        merTools, metaBMA, metadat, metafor, metaplus, mgcv, mice,
        mlogit, mmrm, modelbased, multgee, MuMIn, nestedLogit, nlme,
        nnet, nonnest2, ordinal, panelr, parameters, parsnip, pbkrtest,
        performance, plm, poorman, PROreg (>= 1.3.0), pscl, psych,
        quantreg, Rcpp, RcppEigen, rmarkdown, rms, robustbase,
        robustlmm, rpart, rstanarm (>= 2.21.1), rstantools (>= 2.1.0),
        rstudioapi, sandwich, serp, speedglm, splines, statmod, survey,
        survival, svylme, testthat, tinytable (>= 0.1.0), TMB,
        truncreg, tweedie, VGAM, WeightIt, withr
VignetteBuilder: knitr
Encoding: UTF-8
Language: en-US
RoxygenNote: 7.3.2
Roxygen: list(markdown = TRUE)
Config/testthat/edition: 3
Config/testthat/parallel: true
Config/Needs/website: easystats/easystatstemplate
Config/Needs/check: stan-dev/cmdstanr
NeedsCompilation: no
Packaged: 2024-10-01 20:57:16 UTC; Daniel
Author: Daniel Lüdecke [aut, cre] (<https://orcid.org/0000-0002-8895-3206>,
    @strengejacke),
  Dominique Makowski [aut, ctb] (<https://orcid.org/0000-0001-5375-9967>,
    @Dom_Makowski),
  Indrajeet Patil [aut, ctb] (<https://orcid.org/0000-0003-1995-6531>,
    @patilindrajeets),
  Philip Waggoner [aut, ctb] (<https://orcid.org/0000-0002-7825-7573>),
  Mattan S. Ben-Shachar [aut, ctb]
    (<https://orcid.org/0000-0002-4287-4801>),
  Brenton M. Wiernik [aut, ctb] (<https://orcid.org/0000-0001-9560-6336>,
    @bmwiernik),
  Vincent Arel-Bundock [aut, ctb]
    (<https://orcid.org/0000-0003-2042-7063>),
  Etienne Bacher [aut, ctb] (<https://orcid.org/0000-0002-9271-5075>),
  Alex Hayes [rev] (<https://orcid.org/0000-0002-4985-5160>),
  Grant McDermott [ctb] (<https://orcid.org/0000-0001-7883-8573>),
  Rémi Thériault [ctb] (<https://orcid.org/0000-0003-4315-6788>,
    @rempsyc),
  Alex Reinhart [ctb] (<https://orcid.org/0000-0002-6658-514X>)

@IndrajeetPatil
Copy link
Member

Does getting rid of the Twitter field from comment help?

That is, change

comment = c(ORCID = "0000-0003-1995-6531", Twitter = "@patilindrajeets")

to

comment = c(ORCID = "0000-0003-1995-6531")

@strengejacke
Copy link
Member Author

I wonder why this happens now?

@IndrajeetPatil
Copy link
Member

Because Kurt Hornik has been making significant updates in R-devel to detect more metadata from authors field in DESCRIPTION.

E.g., r-devel/r-svn@9f1a1c0

@strengejacke
Copy link
Member Author

So is Twitter ID discouraged now, or is it a bug in R devel?

@IndrajeetPatil
Copy link
Member

No idea, but I also don't care enough about my Twitter to investigate this further. I just got rid of it from personal packages.

@strengejacke strengejacke mentioned this pull request Oct 1, 2024
Merged
@strengejacke
Copy link
Member Author

Seems to fix it: https://win-builder.r-project.org/uS5T4s4c1IwF/00check.log

@strengejacke strengejacke merged commit c0b5fbf into main Oct 2, 2024
@strengejacke strengejacke deleted the rc_0_20_5 branch October 2, 2024 08:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@strengejacke @IndrajeetPatil