Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

check_if_installed() now automatically determines the correct minimum version #795

Merged
merged 4 commits into from
Aug 7, 2023

Conversation

rempsyc
Copy link
Sponsor Member

@rempsyc rempsyc commented Aug 6, 2023

check_if_installed() now automatically checks the package DESCRIPTION file to determine the correct minimum version required.


Closes #793 and closes #794

…TION file to

  determine the correct minimum version required.
@rempsyc rempsyc added the Enhancement 💥 Implemented features can be improved or revised label Aug 6, 2023
@rempsyc
Copy link
Sponsor Member Author

rempsyc commented Aug 6, 2023

I guess it's difficult to add tests for this function given that the required packages may or may not be available due to the R CMD check hard workflow (even snapshots will fail).

Copy link
Contributor

@bwiernik bwiernik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Made a small comment about naming, otherwise I'm fine to merge once checks pass

R/check_if_installed.R Outdated Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Aug 6, 2023

Codecov Report

Merging #795 (2ed70ec) into main (a95325c) will increase coverage by 0.05%.
Report is 1 commits behind head on main.
The diff coverage is 100.00%.

❗ Current head 2ed70ec differs from pull request most recent head efcec15. Consider uploading reports for the commit efcec15 to get more accurate results

@@            Coverage Diff             @@
##             main     #795      +/-   ##
==========================================
+ Coverage   53.86%   53.91%   +0.05%     
==========================================
  Files         124      124              
  Lines       15226    15244      +18     
==========================================
+ Hits         8201     8219      +18     
  Misses       7025     7025              
Files Changed Coverage Δ
R/model_info.R 55.46% <ø> (ø)
R/check_if_installed.R 54.92% <100.00%> (+15.30%) ⬆️
R/get_predicted_args.R 74.53% <100.00%> (ø)
R/get_predicted_bayesian.R 97.67% <100.00%> (ø)

@rempsyc
Copy link
Sponsor Member Author

rempsyc commented Aug 6, 2023

Remaining failing checks are unrelated to this PR.

@bwiernik bwiernik merged commit 67ec1c5 into main Aug 7, 2023
21 of 25 checks passed
@bwiernik bwiernik deleted the get_dep_version branch August 7, 2023 02:53
@bwiernik
Copy link
Contributor

bwiernik commented Aug 7, 2023

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement 💥 Implemented features can be improved or revised
Projects
None yet
3 participants