-
-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
check_if_installed()
now automatically determines the correct minimum version
#795
Conversation
…TION file to determine the correct minimum version required.
I guess it's difficult to add tests for this function given that the required packages may or may not be available due to the R CMD check hard workflow (even snapshots will fail). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. Made a small comment about naming, otherwise I'm fine to merge once checks pass
Codecov Report
@@ Coverage Diff @@
## main #795 +/- ##
==========================================
+ Coverage 53.86% 53.91% +0.05%
==========================================
Files 124 124
Lines 15226 15244 +18
==========================================
+ Hits 8201 8219 +18
Misses 7025 7025
|
Remaining failing checks are unrelated to this PR. |
Thanks! |
check_if_installed()
now automatically checks the package DESCRIPTION file to determine the correct minimum version required.Closes #793 and closes #794