Infinite loop in icc() for some brms models

Fixes #905
easystats · Jul 17, 2024 · 73451c1 · 73451c1
1 parent 17b7d10
commit 73451c1
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 3 deletions.
diff --git a/R/compute_variances.R b/R/compute_variances.R
@@ -586,7 +586,7 @@
                                            model_component = NULL,
                                            verbose = TRUE) {
   # get overdispersion parameter / sigma
-  sig <- .safe(get_sigma(model))
+  sig <- .safe(.get_sigma(model, no_recursion = TRUE))
 
   if (is.null(sig)) {
     sig <- 1

diff --git a/R/get_sigma.R b/R/get_sigma.R
@@ -232,7 +232,6 @@ get_sigma <- function(x, ci = NULL, verbose = TRUE) {
     }
   )
 
-
   # compute sigma manually ---------------
   if (is_empty_object(s)) {
     # default sigma ---------------
@@ -242,7 +241,12 @@ get_sigma <- function(x, ci = NULL, verbose = TRUE) {
   if (is_empty_object(s)) {
     info <- model_info(x, verbose = FALSE)
     if (!is.null(info) && info$is_mixed) {
-      s <- .safe(sqrt(get_variance_residual(x, verbose = FALSE)))
+      dots <- list(...)
+      # in "get_variance()", we call "get_sigma()" - make sure we avoid
+      # recursion and infinite loops
+      if (!isTRUE(dots$no_recursion)) {
+        s <- .safe(sqrt(get_variance_residual(x, verbose = FALSE)))
+      }
     }
   }