fix, add test

easystats · Jun 27, 2023 · 06c4270 · 06c4270
1 parent 6748578
commit 06c4270
Show file tree

Hide file tree

Showing 2 changed files with 25 additions and 1 deletion.
diff --git a/R/recode_into.r b/R/recode_into.r
@@ -140,7 +140,8 @@ recode_into <- function(..., data = NULL, default = NA, overwrite = TRUE, verbos
     }
     # if user doesn't want to overwrite, remove already recoded indices
     if (!overwrite) {
-      index <- index[!already_exists]
+      index[which(index)[already_exists]] <- FALSE
+      # index <- index[which(index)[!already_exists]]
     }
     out[index] <- value
   }

diff --git a/tests/testthat/test-recode_into.R b/tests/testthat/test-recode_into.R
@@ -19,6 +19,29 @@ test_that("recode_into, overwrite", {
     ),
     regex = "overwritten"
   )
+  # validate results
+  x <- 1:10
+  expect_silent({
+    out <- recode_into(
+      x >= 3 & x <= 7 ~ 1,
+      x > 5 ~ 2,
+      default = 0,
+      verbose = FALSE
+    )
+  })
+  expect_identical(out, c(0, 0, 1, 1, 1, 2, 2, 2, 2, 2))
+
+  x <- 1:10
+  expect_silent({
+    out <- recode_into(
+      x >= 3 & x <= 7 ~ 1,
+      x > 5 ~ 2,
+      default = 0,
+      overwrite = FALSE,
+      verbose = FALSE
+    )
+  })
+  expect_identical(out, c(0, 0, 1, 1, 1, 1, 1, 2, 2, 2))
 })
 
 test_that("recode_into, don't overwrite", {