Update FedEx API integration and refactor related classes #46
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
May 10, 2024 11:15
This commit includes a major update to the FedEx API integration and a significant refactoring of related classes. The `Newtonsoft.Json` package was updated, and several interfaces and their implementations were removed, including `IFedExAuthClient` and `FedExAuthClient`. The `FedExServiceCollectionExtensions` class was updated, replacing the `AddFedExAuthApiClient` method with `AddFedExApiClients`. Several OpenApi references were added in `EasyKeys.Shipping.FedEx.Abstractions.csproj`, and the `AuthRequestMiddleware` class was updated to use `IFedexApiAuthenticatorService`. A new `AuthorizationApi.cs` file was added, and changes were made to the `authorization.json` file. The `JsonSerializerOptions` property in `FedExApiOptions` class was replaced with `JsonSerializerSettings`, and a new namespace `EasyKeys.Shipping.FedEx.Abstractions.Services` was added. Several classes related to address validation and rates and transit times were removed. The `FedexRateProvider.cs` file was significantly refactored, and a new method `AddRestApiFedExRateProvider` was added to the `FedExShippingServiceCollectionExtensions` class. A new class `FedExShipmentProvider` was added, and changes were made to the namespaces of several classes. Changes were also made to `FedExRateProviderTests.cs` and `FedExShipmentProvider.cs`.
Updated various methods and classes to handle null values and null reference exceptions. The `#pragma warning disable CS8625` and `#pragma warning restore CS8625` directives have been added to suppress warnings about possible null reference exceptions. The `ReadObjectResponseAsync<T>`, `ApiException` constructor, `FedExAddressValidationProvider` class, and `ConvertAttributesToDictionary` method have all been updated to handle null values more effectively. The `AddRestApiFedExRateProvider` method has been renamed to `AddRestApiFedExShipmentProvider`. Additionally, parentheses have been added to clarify the order of operations in the condition for adding a special instruction to the commercial invoice.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit includes a major update to the FedEx API integration and a significant refactoring of related classes. The
Newtonsoft.Jsonpackage was updated, and several interfaces and their implementations were removed, includingIFedExAuthClientandFedExAuthClient. TheFedExServiceCollectionExtensionsclass was updated, replacing theAddFedExAuthApiClientmethod withAddFedExApiClients. Several OpenApi references were added inEasyKeys.Shipping.FedEx.Abstractions.csproj, and theAuthRequestMiddlewareclass was updated to useIFedexApiAuthenticatorService. A newAuthorizationApi.csfile was added, and changes were made to theauthorization.jsonfile. TheJsonSerializerOptionsproperty inFedExApiOptionsclass was replaced withJsonSerializerSettings, and a new namespaceEasyKeys.Shipping.FedEx.Abstractions.Serviceswas added. Several classes related to address validation and rates and transit times were removed. TheFedexRateProvider.csfile was significantly refactored, and a new methodAddRestApiFedExRateProviderwas added to theFedExShippingServiceCollectionExtensionsclass. A new classFedExShipmentProviderwas added, and changes were made to the namespaces of several classes. Changes were also made toFedExRateProviderTests.csandFedExShipmentProvider.cs.