Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

{bio}[system/system] bcl-convert v4.2.7-2 w/ el7.x86_64 #20513

Merged

Conversation

verdurin
Copy link
Member

(created using eb --new-pr)

@smoors
Copy link
Contributor

smoors commented May 13, 2024

@boegelbot: please test @ generoso

@boegelbot
Copy link
Collaborator

@smoors: Request for testing this PR well received on login1

PR test command 'EB_PR=20513 EB_ARGS= EB_CONTAINER= EB_REPO=easybuild-easyconfigs /opt/software/slurm/bin/sbatch --job-name test_PR_20513 --ntasks=4 ~/boegelbot/eb_from_pr_upload_generoso.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 13450

Test results coming soon (I hope)...

- notification for comment with ID 2107444108 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegelbot
Copy link
Collaborator

Test report by @boegelbot
FAILED
Build succeeded for 0 out of 1 (1 easyconfigs in total)
cns1 - Linux Rocky Linux 8.9, x86_64, Intel(R) Xeon(R) CPU E5-2667 v3 @ 3.20GHz (haswell), Python 3.6.8
See https://gist.github.com/boegelbot/4fb96568766874aed719dd0d342c3816 for a full test report.

@smoors
Copy link
Contributor

smoors commented May 13, 2024

== 2024-05-13 12:30:40,388 build_log.py:171 ERROR EasyBuild crashed with an error (at easybuild/easybuild-framework/easybuild/base/exceptions.py:126 in init): Command 'rpmrebuild' is required but not available. Please add it as a dependency or install it with the OS package manager. (at easybuild/easybuild-easyblocks/easybuild/easyblocks/generic/rpm.py:60 in rebuild_rpm)

can you add rpmrebuild as a builddep?

@verdurin
Copy link
Member Author

verdurin commented Jun 5, 2024

Test report by @verdurin
SUCCESS
Build succeeded for 2 out of 2 (1 easyconfigs in total)
easybuild-c7.novalocal - Linux CentOS Linux 7.9.2009, x86_64, Intel Xeon Processor (Skylake, IBRS), Python 3.6.8
See https://gist.github.com/verdurin/b5070073bb3711bff88674dfcd3cbfb9 for a full test report.

@verdurin
Copy link
Member Author

verdurin commented Jun 5, 2024

@boegelbot please test @ generoso

@boegelbot
Copy link
Collaborator

@verdurin: Request for testing this PR well received on login1

PR test command 'EB_PR=20513 EB_ARGS= EB_CONTAINER= EB_REPO=easybuild-easyconfigs /opt/software/slurm/bin/sbatch --job-name test_PR_20513 --ntasks=4 ~/boegelbot/eb_from_pr_upload_generoso.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 13648

Test results coming soon (I hope)...

- notification for comment with ID 2150463336 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@verdurin verdurin added this to the 4.x milestone Jun 5, 2024
@boegelbot
Copy link
Collaborator

Test report by @boegelbot
FAILED
Build succeeded for 1 out of 2 (1 easyconfigs in total)
cns1 - Linux Rocky Linux 8.9, x86_64, Intel(R) Xeon(R) CPU E5-2667 v3 @ 3.20GHz (haswell), Python 3.6.8
See https://gist.github.com/boegelbot/b013a5f119bad26bbca7b441af25ce49 for a full test report.

@verdurin
Copy link
Member Author

verdurin commented Jun 5, 2024

@smoors I added that, and now this weird error is showing:
rpm: -bb: unknown option ?

@verdurin
Copy link
Member Author

verdurin commented Jun 5, 2024

I don't have any local systems where RPM isn't available in the OS...

@verdurin
Copy link
Member Author

verdurin commented Jun 5, 2024

I've raised an issue against the RPM easyblock at easybuilders/easybuild-easyblocks#3350

@smoors
Copy link
Contributor

smoors commented Jun 5, 2024

the issue is that rpmbuild is not available in generoso. in that case the rpmrebuild.sh script assumes that the rpm version is 3 (see code snippet below), which is not the case. the -bb option is no longer available in, rpm it is now in rpmbuild.

function RpmBuild
{
    Debug '(RpmBuild)'
    # rpmrebuild package dependency
    # for rpm 3.x : use rpm
    # for rpm 4.x : use rpmbuild
    local BUILDCMD
    if [ -x /usr/bin/rpmbuild ]
    then
        BUILDCMD=/usr/bin/rpmbuild
    else

        BUILDCMD=rpm
    fi

i'm not sure what's the best way to get rpmbuild installed in generoso?

@verdurin
Copy link
Member Author

@smoors thanks for diagnosing. I asked about it in the 'test-bots' channel.

Could you submit a test build from one of your local systems in the meantime?

@smoors
Copy link
Contributor

smoors commented Jun 10, 2024

Test report by @smoors
SUCCESS
Build succeeded for 2 out of 2 (1 easyconfigs in total)
node306.hydra.os - Linux Rocky Linux 8.9, x86_64, Intel(R) Xeon(R) Gold 6148 CPU @ 2.40GHz (skylake_avx512), Python 3.6.8
See https://gist.github.com/smoors/c90ff91b3c3d4a559f0aaa55838cb9d2 for a full test report.

@smoors
Copy link
Contributor

smoors commented Jun 10, 2024

@boegelbot please test @ jsc-zen3

@boegelbot
Copy link
Collaborator

@smoors: Request for testing this PR well received on jsczen3l1.int.jsc-zen3.fz-juelich.de

PR test command 'if [[ develop != 'develop' ]]; then EB_BRANCH=develop ./easybuild_develop.sh 2> /dev/null 1>&2; EB_PREFIX=/home/boegelbot/easybuild/develop source init_env_easybuild_develop.sh; fi; EB_PR=20513 EB_ARGS= EB_CONTAINER= EB_REPO=easybuild-easyconfigs EB_BRANCH=develop /opt/software/slurm/bin/sbatch --job-name test_PR_20513 --ntasks=8 ~/boegelbot/eb_from_pr_upload_jsc-zen3.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 4346

Test results coming soon (I hope)...

- notification for comment with ID 2158221419 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegelbot
Copy link
Collaborator

Test report by @boegelbot
FAILED
Build succeeded for 1 out of 2 (1 easyconfigs in total)
jsczen3c1.int.jsc-zen3.fz-juelich.de - Linux Rocky Linux 9.4, x86_64, AMD EPYC-Milan Processor (zen3), Python 3.9.18
See https://gist.github.com/boegelbot/ebbb6b548bbb97a6b2b6e6f7eaf69025 for a full test report.

@smoors
Copy link
Contributor

smoors commented Jun 10, 2024

@boegelbot please test @ jsc-zen3

@boegelbot
Copy link
Collaborator

@smoors: Request for testing this PR well received on jsczen3l1.int.jsc-zen3.fz-juelich.de

PR test command 'if [[ develop != 'develop' ]]; then EB_BRANCH=develop ./easybuild_develop.sh 2> /dev/null 1>&2; EB_PREFIX=/home/boegelbot/easybuild/develop source init_env_easybuild_develop.sh; fi; EB_PR=20513 EB_ARGS= EB_CONTAINER= EB_REPO=easybuild-easyconfigs EB_BRANCH=develop /opt/software/slurm/bin/sbatch --job-name test_PR_20513 --ntasks=8 ~/boegelbot/eb_from_pr_upload_jsc-zen3.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 4347

Test results coming soon (I hope)...

- notification for comment with ID 2158431627 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegelbot
Copy link
Collaborator

Test report by @boegelbot
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
jsczen3c1.int.jsc-zen3.fz-juelich.de - Linux Rocky Linux 9.4, x86_64, AMD EPYC-Milan Processor (zen3), Python 3.9.18
See https://gist.github.com/boegelbot/b97d026e8d8b8c4322ca792254eb57fc for a full test report.

@smoors
Copy link
Contributor

smoors commented Jun 11, 2024

@boegelbot: please test @ generoso

@boegelbot
Copy link
Collaborator

@smoors: Request for testing this PR well received on login1

PR test command 'EB_PR=20513 EB_ARGS= EB_CONTAINER= EB_REPO=easybuild-easyconfigs /opt/software/slurm/bin/sbatch --job-name test_PR_20513 --ntasks=4 ~/boegelbot/eb_from_pr_upload_generoso.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 13714

Test results coming soon (I hope)...

- notification for comment with ID 2160222192 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegelbot
Copy link
Collaborator

Test report by @boegelbot
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
cns1 - Linux Rocky Linux 8.9, x86_64, Intel(R) Xeon(R) CPU E5-2667 v3 @ 3.20GHz (haswell), Python 3.6.8
See https://gist.github.com/boegelbot/6089af52c440116584e90f8d8acbe633 for a full test report.

Copy link
Contributor

@smoors smoors left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@smoors smoors removed this from the 4.x milestone Jun 11, 2024
@smoors smoors added this to the release after 4.9.2 milestone Jun 11, 2024
@smoors
Copy link
Contributor

smoors commented Jun 11, 2024

Going in, thanks @verdurin!

@smoors smoors merged commit 3bd8082 into easybuilders:develop Jun 11, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants