Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove --disable-docs configure option from FriBidi 1.0.5+ #19998

Merged

Conversation

Flamefire
Copy link
Contributor

@Flamefire Flamefire commented Feb 29, 2024

(created using eb --new-pr)

The option was introduced to 1.0.2 but removed in 1.0.3: fribidi/fribidi#73

@Flamefire
Copy link
Contributor Author

Test report by @Flamefire
SUCCESS
Build succeeded for 11 out of 11 (6 easyconfigs in total)
n1358 - Linux RHEL 8.7 (Ootpa), x86_64, Intel(R) Xeon(R) Platinum 8470 (icelake), Python 3.8.13
See https://gist.github.com/Flamefire/230707720733148580a4882900506631 for a full test report.

@ocaisa
Copy link
Member

ocaisa commented Feb 29, 2024

@boegelbot please test @ generoso

@boegelbot
Copy link
Collaborator

@ocaisa: Request for testing this PR well received on login1

PR test command 'EB_PR=19998 EB_ARGS= EB_CONTAINER= EB_REPO=easybuild-easyconfigs /opt/software/slurm/bin/sbatch --job-name test_PR_19998 --ntasks=4 ~/boegelbot/eb_from_pr_upload_generoso.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 12993

Test results coming soon (I hope)...

- notification for comment with ID 1971299007 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegelbot
Copy link
Collaborator

Test report by @boegelbot
SUCCESS
Build succeeded for 7 out of 7 (7 easyconfigs in total)
cns1 - Linux Rocky Linux 8.9, x86_64, Intel(R) Xeon(R) CPU E5-2667 v3 @ 3.20GHz (haswell), Python 3.6.8
See https://gist.github.com/boegelbot/553ef0a27f7d400ebb07be324684422e for a full test report.

@ocaisa ocaisa added this to the release after 4.9.0 milestone Feb 29, 2024
@ocaisa
Copy link
Member

ocaisa commented Feb 29, 2024

@boegelbot please test @ generoso
EB_ARGS="--include-easyblocks-from-pr 3026"

@boegelbot
Copy link
Collaborator

@ocaisa: Request for testing this PR well received on login1

PR test command 'EB_PR=19998 EB_ARGS="--include-easyblocks-from-pr 3026" EB_CONTAINER= EB_REPO=easybuild-easyconfigs /opt/software/slurm/bin/sbatch --job-name test_PR_19998 --ntasks=4 ~/boegelbot/eb_from_pr_upload_generoso.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 12994

Test results coming soon (I hope)...

- notification for comment with ID 1971324785 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegelbot
Copy link
Collaborator

Test report by @boegelbot
Using easyblocks from PR(s) easybuilders/easybuild-easyblocks#3026
SUCCESS
Build succeeded for 7 out of 7 (7 easyconfigs in total)
cns1 - Linux Rocky Linux 8.9, x86_64, Intel(R) Xeon(R) CPU E5-2667 v3 @ 3.20GHz (haswell), Python 3.6.8
See https://gist.github.com/boegelbot/4123a5c0ee189b1865065398b1a30729 for a full test report.

@ocaisa
Copy link
Member

ocaisa commented Feb 29, 2024

Going in, thanks @Flamefire

@ocaisa ocaisa merged commit 98fe2fe into easybuilders:develop Feb 29, 2024
9 checks passed
@Flamefire Flamefire deleted the 20240229094502_new_pr_FriBidi1010 branch March 1, 2024 09:49
@boegel boegel added the bug fix label Mar 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants