Add DeepSpeed easyblock #3450
Open
Add DeepSpeed easyblock #3450
+61
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Micket
reviewed
Sep 20, 2024
| @@ -0,0 +1,61 @@ | |||
| from easybuild.easyblocks.generic.pythonpackage import PythonPackage | |||
There was a problem hiding this comment.
please include comment block on + you as the author
Micket
reviewed
Sep 20, 2024
|
|
||
| # require that PyTorch is listed as dependency | ||
| if 'PyTorch' not in dep_names: | ||
| raise EasyBuildError('PyTorch not found as a dependency') |
There was a problem hiding this comment.
I think we shouldn't error inside the init method, maybe move this to the build steps instead? The test suite doesn't like this at all.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds an EasyBlock for building DeepSpeed. Main reason for not handling it in the easyconfig is to access
cuda_compute_capabilities.