make sure user packages are not used in sanity check of PythonBundle #3435
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some PythonBundle ECs (e.g. IPython) use custom sanity checks using python. That might pick up python packages installed to the users `$HOME` which can yield wrong results. We already take care of this for the extensions sanity check in PythonPackage and for installing extensions in PythonBundle. However for the sanity check of PythonBundle itself the variable is not defined (even if it was defined during the build) as the environment gets reset when loading the module used for the sanity check. Hence use the same approach used in PythonPackage and set `$PYTHONNOUSERSITE` after loading the module.
|
Test report by @Flamefire Overview of tested easyconfigs (in order)
Build succeeded for 1 out of 1 (1 easyconfigs in total) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some PythonBundle ECs (e.g. IPython) use custom sanity checks using python. That might pick up python packages installed to the users
$HOMEwhich can yield wrong results.We already take care of this for the extensions sanity check in PythonPackage and for installing extensions in PythonBundle.
However for the sanity check of PythonBundle itself the variable is not defined (even if it was defined during the build) as the environment gets reset when loading the module used for the sanity check.
Hence use the same approach used in PythonPackage and set
$PYTHONNOUSERSITEafter loading the module.