-
Notifications
You must be signed in to change notification settings - Fork 285
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
make sure to raise an error if pick_python_cmd
returns False
for Python bundles/packages
#3430
make sure to raise an error if pick_python_cmd
returns False
for Python bundles/packages
#3430
Conversation
When used with
Although it is still cryptic (it doesn't specifically complain about the version unless you run with |
Test build in easybuilders/easybuild-easyconfigs#21307 (comment) (ended up in the other PR... but still shows it in the gist all right: https://gist.github.com/casparvl/07e98bf3cb8c43ee1a6f34a38b1eed6d . It now
|
… is used when using system python
…ver and req_py_minver are guaranteed to be defined
Test report by @bedroge Overview of tested easyconfigs (in order)
Build succeeded for 0 out of 1 (1 easyconfigs in total) This is an expected failure to demonstrate that the added functionality works: I tried building the ReFrame version from easybuilders/easybuild-easyconfigs#21307 using Python 3.6, while it needs at least 3.7.
|
Test report by @bedroge Overview of tested easyconfigs (in order)
Build succeeded for 4 out of 4 (4 easyconfigs in total) |
pick_python_cmd
returns False for Python bundles/packages
Test report by @bedroge Overview of tested easyconfigs (in order)
Build succeeded for 1 out of 1 (1 easyconfigs in total) This is the other easyconfig from easybuilders/easybuild-easyconfigs#21307, which requires at least Python 3.7, and 3.12 is being used. So, it also works as expected. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lgtm
pick_python_cmd
returns False for Python bundles/packagespick_python_cmd
returns False
for Python bundles/packages
This was already done for PythonPackage, but not for PythonBundle. I ran into this here easybuilders/easybuild-easyconfigs#21307 (comment)