Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add custom easyblock for BLIS #3385

Open
wants to merge 9 commits into
base: develop
Choose a base branch
from
Open

add custom easyblock for BLIS #3385

wants to merge 9 commits into from

Conversation

wwweert123
Copy link

(created using eb --new-pr)

@wwweert123
Copy link
Author

https://github.com/EESSI/software-layer/blob/f64a20d373a3047a55315a92401c0610bf526844/eb_hooks.py#L343-L358 This easyblock for BLIS was implemented to also take into account building on A64FX cpu architecture where additional configure opts are needed.

@wwweert123 wwweert123 mentioned this pull request Jul 8, 2024
Open
@boegel boegel added the new label Jul 31, 2024
@boegel boegel added this to the release after 4.9.2 milestone Jul 31, 2024
@boegel boegel changed the title new easyblock for blis add custom easyblock for BLIS Jul 31, 2024
boegel
boegel requested changes Jul 31, 2024
View reviewed changes
Copy link
Member

@boegel boegel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for the contribution @wwweert123!

Do you mind also opening a companion PR for the recent BLIS easyconfigs, so clean them up so the custom easyblock for BLIS is being used?

Of course we'll make sure that this PR gets merged first...

easybuild/easyblocks/b/blis.py Outdated Show resolved Hide resolved
@wwweert123
Copy link
Author

Thanks a lot for the contribution @wwweert123!

Do you mind also opening a companion PR for the recent BLIS easyconfigs, so clean them up so the custom easyblock for BLIS is being used?

Of course we'll make sure that this PR gets merged first...

Oh yes, I have created a companion PR BLIS easyconfig that makes use of this custom easyblock. I had forgotten to mention it here in this PR.

easybuilders/easybuild-easyconfigs#20973

@boegel boegel modified the milestones: 4.9.3, release after 4.9.3 Sep 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@boegel boegel boegel requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
new
Projects
None yet
Milestone
release after 4.9.4
Development

Successfully merging this pull request may close these issues.
2 participants
@wwweert123 @boegel