Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

deprecate unknown configure args in ConfigureMake easyblock #3026

Open
wants to merge 3 commits into
base: develop
Choose a base branch
from
Open

deprecate unknown configure args in ConfigureMake easyblock #3026

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
bccf25b
deprecate unknown configure args in `ConfigureMake` easyblock
Flamefire Oct 25, 2023
1172219
Change to issue an error
Flamefire Mar 8, 2024
70a582e
Revert "Change to issue an error"
Flamefire Mar 11, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions easybuild/easyblocks/generic/configuremake.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,12 +44,12 @@
from easybuild.easyblocks import VERSION as EASYBLOCKS_VERSION
from easybuild.framework.easyblock import EasyBlock
from easybuild.framework.easyconfig import CUSTOM
from easybuild.tools.build_log import print_warning
from easybuild.tools.build_log import print_warning, EasyBuildError
from easybuild.tools.config import source_paths, build_option
from easybuild.tools.filetools import CHECKSUM_TYPE_SHA256, adjust_permissions, compute_checksum, download_file
from easybuild.tools.filetools import read_file, remove_file
from easybuild.tools.py2vs3 import string_type
from easybuild.tools.run import run_cmd
from easybuild.tools.run import check_log_for_errors, run_cmd

# string that indicates that a configure script was generated by Autoconf
# note: bytes string since this constant is used to check the contents of 'configure' which is read as bytes
Expand Down Expand Up @@ -324,6 +324,11 @@ def configure_step(self, cmd_prefix=''):
)

(out, _) = run_cmd(cmd, log_all=True, simple=False)
try:
check_log_for_errors(out, ['configure: WARNING: unrecognized options:'])
except EasyBuildError as err:
self.log.deprecated("Unknown arguments for configure used: %s" % err, '5.0')
print_warning("Unknown arguments for configure detected: %s" % err)

return out

Expand Down
Loading