Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds Marketplace link to README #2

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

Stanzilla
Copy link

@Stanzilla Stanzilla commented Jun 3, 2020

Thank you for taking the time to contribute to TypeScript + Webpack Problem Matchers! ♥

🚨 IMPORTANT 🚨

  • Please create an issue before creating a Pull Request
  • Please ensure to use the master branch as the base for all PRs
  • Please use the following Git commit message style
    • Use the future tense ("Adds feature" not "Added feature")
    • Use a "Fixes #xxx -" or "Closes #xxx -" prefix to auto-close the issue that your PR addresses
    • Limit the first line to 72 characters or less
    • Reference issues and pull requests liberally after the first line

Description

Checklist

  • I have followed the guidelines in the Contributing document
  • My changes are based off of the master branch
  • My changes follow the coding style of this project
  • My changes build without any errors or warnings
  • My changes have been formatted and linted
  • My changes include any required corresponding changes to the documentation
  • My changes have been rebased and squashed to the minimal number (typically 1) of relevant commits
  • My changes have a descriptive commit message with a short title, including a Fixes $XXX - or Closes #XXX - prefix to auto-close the issue that your PR addresses

@Stanzilla Stanzilla changed the title Add Marketplace link to README Adds Marketplace link to README Jun 3, 2020
Base automatically changed from master to main March 1, 2021 06:44
Copy link

@SethFalco SethFalco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey! Just wanted to bump this and say it's probably a good call to add it to the README.
I wasn't sure if the extension was still being published or not until I saw this. ^-^'

Edit: Ahh, whoops, wasn't meant to approve. The extension name/ID was renamed, so this PR just needs to be updated to reflect that. ^-^'

README.md Outdated Show resolved Hide resolved
Co-authored-by: Seth Falco <[email protected]>
@SethFalco
Copy link

(Also has conflicts btw!)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants