[21703] Add a python backend node with orchestrator #54
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: eProsima <[email protected]>
Signed-off-by: eProsima <[email protected]>
Signed-off-by: eProsima <[email protected]>
Signed-off-by: eProsima <[email protected]>
Signed-off-by: eProsima <[email protected]>
JesusPoderoso
force-pushed
the
feature/21703
branch
from
f04bde9
to
dbf2f06
Compare
Signed-off-by: eProsima <[email protected]>
JesusPoderoso
force-pushed
the
feature/21703
branch
from
dbf2f06
to
e6a335f
Compare
Mario-DL
requested changes
Oct 8, 2024
sustainml_cpp/include/sustainml_cpp/orchestrator/OrchestratorNode.hpp
Outdated
Show resolved
Hide resolved
JesusPoderoso
force-pushed
the
feature/21703
branch
from
119538d
to
8eacde6
Compare
Signed-off-by: eProsima <[email protected]>
JesusPoderoso
force-pushed
the
feature/21703
branch
from
8eacde6
to
893ee88
Compare
Mario-DL
reviewed
Oct 14, 2024
| @@ -199,7 +214,7 @@ class OrchestratorNode | |||
|
|
|||
| uint32_t domain_; | |||
|
|
|||
| std::shared_ptr<OrchestratorNodeHandle> handler_; | |||
| OrchestratorNodeHandle* handler_; | |||
There was a problem hiding this comment.
We may add a comment here stating that the deletion of the handler_ is managed by the user. Also we may include it in the destroy() method and in the descriptiof of the OrchestratorNodeHandle inside a @note
Signed-off-by: eProsima <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This performs the necessary changes to launch the orchestrator as a backend node in python.