Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix microcontroller no real bool type issue #387

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix microcontroller no real bool type issue #387

wants to merge 1 commit into from

Conversation

clippinglee
Copy link

fix issue eProsima/Micro-XRCE-DDS#173
SOC need real bool type,But MCU does not have real bool type.
in MCU,bool = uint8

@richiprosima
Copy link
Contributor

Build status:

  • Linux Build Status
  • Windows Build Status

@richiprosima
Copy link
Contributor

Build status:

  • Linux Build Status
  • Windows Build Status

@pablogs9
Copy link
Member

pablogs9 commented Jun 3, 2024

I would prefer to have some kind of check in ucdr_serialize_bool that serializes an 0x01 when arg != 0, is that possible to modify this PR to that approach?

@clippinglee
Copy link
Author

yes , but i would prefer to change ucdr_serialize_bool when this function defined,look:eProsima/Micro-CDR#75
Whether or not the caller makes an arg!=0 judgment, we can avoid this problem

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@clippinglee @richiprosima @pablogs9