-
Notifications
You must be signed in to change notification settings - Fork 775
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[20508] TCP first message loss (backport #4454) #4562
Conversation
Cherry-pick of 8103cf0 has failed:
To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally |
@jepemi could you address the conflicts, please? (If you don't mind, try to remove the |
e7ca164
to
4e08209
Compare
4e08209
to
bf8ad84
Compare
@richiprosima Please test this |
@Mergifyio rebase |
Signed-off-by: Jesus Perez <[email protected]>
bf8ad84
to
5729baa
Compare
✅ Branch has been successfully rebased |
@jepemi Test |
Signed-off-by: Jesus Perez <[email protected]>
@richiprosima Please test this |
Description
In the initial TCP logical port negotiation some logical port requests were missing. This would not prevent communication as those remaining requests would be sent on the first data sent to that logical port. However, that data would be discarded.
With this PR all discovered logical ports are requested on initialization and the first data would not need to be discarded.
@Mergifyio backport 2.13.x 2.12.x 2.10.x 2.6.x
Contributor Checklist
versions.md
file (if applicable).Related documentation PR: [20508] TCP first message loss Fast-DDS-docs#699
Reviewer Checklist
This is an automatic backport of pull request #4454 done by [Mergify](https://mergify.com).