[19377] Add ThreadSettings to Qos #3848

EduPonz · 2023-09-13T14:58:35Z

Description

This PR adds Qos support for configuring the various Fast DDS threads

Contributor Checklist

Commit messages follow the project guidelines.
The code follows the style guidelines of this project.
Tests that thoroughly check the new feature have been added/Regression tests checking the bug and its fix have been added; the added tests pass locally
Any new/modified methods have been properly documented using Doxygen.
Changes are ABI compatible.
Changes are API compatible.
New feature has been added to the versions.md file (if applicable).
New feature has been documented/Current behavior is correctly described in the documentation.
N/A: Applicable backports have been included in the description.

Reviewer Checklist

The PR has a milestone assigned.
Check contributor checklist is correct.
Check CI results: changes do not issue any warning.
Check CI results: failing tests are unrelated with the changes.

EduPonz · 2023-09-13T18:21:02Z

@richiprosima please test this

test/unittest/rtps/attributes/CMakeLists.txt

include/fastdds/dds/domain/qos/DomainParticipantQos.hpp

src/cpp/fastdds/domain/DomainParticipantImpl.cpp

test/unittest/dds/participant/ParticipantTests.cpp

include/fastdds/rtps/transport/TransportDescriptorInterface.h

src/cpp/fastdds/subscriber/DataReaderImpl.cpp

include/fastdds/dds/domain/qos/DomainParticipantQos.hpp

src/cpp/fastdds/utils/QosConverters.cpp

Signed-off-by: Eduardo Ponz <[email protected]>

…ow controllers Signed-off-by: Eduardo Ponz <[email protected]>

Signed-off-by: EduPonz <[email protected]>

EduPonz · 2023-09-21T19:41:43Z

@richiprosima please test this

test/unittest/dds/subscriber/DataReaderTests.cpp

include/fastdds/rtps/attributes/RTPSParticipantAttributes.h

include/fastdds/rtps/transport/PortBasedTransportDescriptor.hpp

include/fastdds/rtps/transport/TransportDescriptorInterface.h

…ParticipantQos Signed-off-by: EduPonz <[email protected]>

Signed-off-by: EduPonz <[email protected]>

EduPonz · 2023-09-22T15:15:58Z

@richiprosima please test this

Signed-off-by: EduPonz <[email protected]>

MiguelCompany

LGTM

MiguelCompany · 2023-09-25T07:02:12Z

@richiprosima Please test this

include/fastdds/dds/subscriber/qos/DataReaderQos.hpp

Signed-off-by: EduPonz <[email protected]>

EduPonz · 2023-09-25T14:30:02Z

@richiprosima please test this

Signed-off-by: EduPonz <[email protected]>

EduPonz · 2023-09-26T06:41:25Z

@richiprosima please test mac

EduPonz · 2023-09-26T07:57:17Z

@richiprosima please test this

EduPonz · 2023-09-26T08:35:32Z

@richiprosima please test mac

* Refs #19377: Add ThreadSettings struct Signed-off-by: Eduardo Ponz <[email protected]> * Refs #19377: Add ThreadSetting to Log API Signed-off-by: Eduardo Ponz <[email protected]> * Refs #19377: Add ThreadSetting to DomainParticipantFactoryQos Signed-off-by: Eduardo Ponz <[email protected]> * Refs #19377: Add ThreadSetting to DomainParticipantQos Signed-off-by: Eduardo Ponz <[email protected]> * Refs #19377: Add ThreadSetting to TransportConfigQos Signed-off-by: Eduardo Ponz <[email protected]> * Refs #19377: Add ThreadSetting to TransportDescriptorInterface Signed-off-by: Eduardo Ponz <[email protected]> * Refs #19377: Add ThreadSetting to SharedMemTransportDescriptor Signed-off-by: Eduardo Ponz <[email protected]> * Refs #19377: Add ThreadSetting to FlowControllerDescriptor Signed-off-by: Eduardo Ponz <[email protected]> * Refs #19377: Add ThreadSetting to DataReaderQos Signed-off-by: Eduardo Ponz <[email protected]> * Refs #19377: Add ThreadSetting to DomainParticipantQos for builtin flow controllers Signed-off-by: Eduardo Ponz <[email protected]> * Refs #19377: Address Miguel's comments in DomainParticipant Signed-off-by: EduPonz <[email protected]> * Refs #19377: Address Miguel's comments in DataReader Signed-off-by: EduPonz <[email protected]> * Refs #19377: Address Miguel's comments in ParticipantTests Signed-off-by: EduPonz <[email protected]> * Refs #19377: Address Miguel's comments in QosConverters Signed-off-by: EduPonz <[email protected]> * Refs #19377: Address Miguel's comments in Transport descriptors Signed-off-by: EduPonz <[email protected]> * Refs #19377: Address Miguel's comments in DataReaderTests Signed-off-by: EduPonz <[email protected]> * Refs #19377: Address Miguel's comments in RTPSParticipantAttibutes Signed-off-by: EduPonz <[email protected]> * Refs #19377: Address Miguel's comments in PortBasedTransportDescriptor Signed-off-by: EduPonz <[email protected]> * Refs #19377: Add builtin_controllers_sender_thread to UpdatableDomainParticipantQos Signed-off-by: EduPonz <[email protected]> * Refs #19377: Refactor PortBasedTransportDescriptor accessors Signed-off-by: EduPonz <[email protected]> * Refs #19377: Add TCP related thread settings Signed-off-by: EduPonz <[email protected]> * Refs #19377: Add data_sharing_listener_thread to ReaderAttributes Signed-off-by: EduPonz <[email protected]> * Refs #19377: Fix windows warning Signed-off-by: EduPonz <[email protected]> --------- Signed-off-by: Eduardo Ponz <[email protected]> Signed-off-by: EduPonz <[email protected]>

* Setting infraestructure for naming threads (#3821) * Refs #19375. Added internal header for threading utilities. Signed-off-by: Miguel Company <[email protected]> * Refs #19375. Added empty implementation for set_name_to_current_thread. Signed-off-by: Miguel Company <[email protected]> * Refs #19375. Added name on Log thread. Signed-off-by: Miguel Company <[email protected]> * Refs #19375. Added name on shm watchdog thread. Signed-off-by: Miguel Company <[email protected]> * Refs #19375. Added name for filewatch threads. Signed-off-by: Miguel Company <[email protected]> * Refs #19375. Added name on ResourceEvent threads. Signed-off-by: Miguel Company <[email protected]> * Refs #19375. Added name on udp reception thread. Signed-off-by: Miguel Company <[email protected]> * Refs #19375. Added name on shm reception thread. Signed-off-by: Miguel Company <[email protected]> * Refs #19375. Added name on data-sharing reception thread. Signed-off-by: Miguel Company <[email protected]> * Refs #19375. Added name for TCP threads. Signed-off-by: Miguel Company <[email protected]> * Refs #19375. Added name on FlowController thread. Signed-off-by: Miguel Company <[email protected]> * Refs #19375. Added name for SHM dump threads. Signed-off-by: Miguel Company <[email protected]> * Refs #19375. Added initialization callback to LogTopic. Signed-off-by: Miguel Company <[email protected]> * Refs #19375. SecurityManager refactor to receive plugin factory by dependency injection. Signed-off-by: Miguel Company <[email protected]> * Refs #19375. Allow easy overload of creation of builtin plugins. Signed-off-by: Miguel Company <[email protected]> * Refs #19375. RTPSParticipantImpl configures the logging thread. Signed-off-by: Miguel Company <[email protected]> * Refs #19375. Uncrustify. Signed-off-by: Miguel Company <[email protected]> --------- Signed-off-by: Miguel Company <[email protected]> * Platform implementations for set_name_to_current_thread (#3823) * Refs #17492. Added pthread implementation for set_name_to_current_thread Signed-off-by: Miguel Company <[email protected]> * Refs #17492. Added implementation for Windows. Signed-off-by: Miguel Company <[email protected]> * Refs #17492. Added implementation for Mac. Signed-off-by: Miguel Company <[email protected]> * Refs #17492. Added doxygen to threading.hpp Signed-off-by: Miguel Company <[email protected]> * Refs #17492. Using pthread implementation for Android. Signed-off-by: Miguel Company <[email protected]> * Refs #17492. Fix build error on snprintf. Signed-off-by: Miguel Company <[email protected]> --------- Signed-off-by: Miguel Company <[email protected]> * Add ThreadSettings to Qos (#3848) * Refs #19377: Add ThreadSettings struct Signed-off-by: Eduardo Ponz <[email protected]> * Refs #19377: Add ThreadSetting to Log API Signed-off-by: Eduardo Ponz <[email protected]> * Refs #19377: Add ThreadSetting to DomainParticipantFactoryQos Signed-off-by: Eduardo Ponz <[email protected]> * Refs #19377: Add ThreadSetting to DomainParticipantQos Signed-off-by: Eduardo Ponz <[email protected]> * Refs #19377: Add ThreadSetting to TransportConfigQos Signed-off-by: Eduardo Ponz <[email protected]> * Refs #19377: Add ThreadSetting to TransportDescriptorInterface Signed-off-by: Eduardo Ponz <[email protected]> * Refs #19377: Add ThreadSetting to SharedMemTransportDescriptor Signed-off-by: Eduardo Ponz <[email protected]> * Refs #19377: Add ThreadSetting to FlowControllerDescriptor Signed-off-by: Eduardo Ponz <[email protected]> * Refs #19377: Add ThreadSetting to DataReaderQos Signed-off-by: Eduardo Ponz <[email protected]> * Refs #19377: Add ThreadSetting to DomainParticipantQos for builtin flow controllers Signed-off-by: Eduardo Ponz <[email protected]> * Refs #19377: Address Miguel's comments in DomainParticipant Signed-off-by: EduPonz <[email protected]> * Refs #19377: Address Miguel's comments in DataReader Signed-off-by: EduPonz <[email protected]> * Refs #19377: Address Miguel's comments in ParticipantTests Signed-off-by: EduPonz <[email protected]> * Refs #19377: Address Miguel's comments in QosConverters Signed-off-by: EduPonz <[email protected]> * Refs #19377: Address Miguel's comments in Transport descriptors Signed-off-by: EduPonz <[email protected]> * Refs #19377: Address Miguel's comments in DataReaderTests Signed-off-by: EduPonz <[email protected]> * Refs #19377: Address Miguel's comments in RTPSParticipantAttibutes Signed-off-by: EduPonz <[email protected]> * Refs #19377: Address Miguel's comments in PortBasedTransportDescriptor Signed-off-by: EduPonz <[email protected]> * Refs #19377: Add builtin_controllers_sender_thread to UpdatableDomainParticipantQos Signed-off-by: EduPonz <[email protected]> * Refs #19377: Refactor PortBasedTransportDescriptor accessors Signed-off-by: EduPonz <[email protected]> * Refs #19377: Add TCP related thread settings Signed-off-by: EduPonz <[email protected]> * Refs #19377: Add data_sharing_listener_thread to ReaderAttributes Signed-off-by: EduPonz <[email protected]> * Refs #19377: Fix windows warning Signed-off-by: EduPonz <[email protected]> --------- Signed-off-by: Eduardo Ponz <[email protected]> Signed-off-by: EduPonz <[email protected]> * Apply thread settings (#3874) * Refs #19436. Added thread creation wrapper infrastructure. Signed-off-by: Miguel Company <[email protected]> * Refs #19436. Added empty implementation for apply_thread_settings_to_current_thread. Signed-off-by: Miguel Company <[email protected]> * Refs #19436. Refactor on Log.cpp Signed-off-by: Miguel Company <[email protected]> * Refs #19436. Add implementation for setting scheduler and priority. Signed-off-by: Miguel Company <[email protected]> * Refs #19436. Add implementation for setting cpu affinity. Signed-off-by: Miguel Company <[email protected]> * Refs #19436. Add test setting config for Log thread. Signed-off-by: Miguel Company <[email protected]> * Refs #19436. Fix SystemInfoTests link issue. Signed-off-by: Miguel Company <[email protected]> * Refs #19436. Changes on ResourceEvent. Signed-off-by: Miguel Company <[email protected]> * Refs #19436. Changes on DataSharingListener. Signed-off-by: Miguel Company <[email protected]> * Refs #19436. Changes on FlowControllerImpl. Signed-off-by: Miguel Company <[email protected]> * Refs #19436. Changes on security LogTopic. Signed-off-by: Miguel Company <[email protected]> * Refs #19436. Apply settings on SharedMemWatchdog. Signed-off-by: Miguel Company <[email protected]> * Refs #19436. Apply settings on SharedMem reception threads. Signed-off-by: Miguel Company <[email protected]> * Refs #19436. Apply settings on SharedMem packet dump threads. Signed-off-by: Miguel Company <[email protected]> * Refs #19436. Apply settings on UDP reception threads. Signed-off-by: Miguel Company <[email protected]> * Refs #19436. Apply settings on TCP accept and keep_alive threads. Signed-off-by: Miguel Company <[email protected]> * Refs #19436. Apply settings on TCP reception threads. Signed-off-by: Miguel Company <[email protected]> * Refs #19436. Include what you use. Signed-off-by: Miguel Company <[email protected]> * Refs #19436. Add MacOS implementation for setting scheduler and priority. Signed-off-by: Miguel Company <[email protected]> * Refs #19436. Add MacOS implementation for setting thread affinity. Signed-off-by: Miguel Company <[email protected]> * Refs #19437. Member cpu_mask changed to affinity and made it 64 bits. Signed-off-by: Miguel Company <[email protected]> * Refs #19437. Windows implementation for thread affinity. Signed-off-by: Miguel Company <[email protected]> * Refs #19437. Windows implementation for thread priority. Signed-off-by: Miguel Company <[email protected]> * Refs #19436. Made `get_thread_config_for_port` a const method. Signed-off-by: Miguel Company <[email protected]> * Refs #19436. Apply suggestions from code review. Signed-off-by: Miguel Company <[email protected]> Co-authored-by: Eduardo Ponz Segrelles <[email protected]> * Refs #19435. Some refactors on FileWatch: - Namespace moved to eprosima::filewatch - Constructor receives thread settings - Copy constructors deleted Signed-off-by: Miguel Company <[email protected]> * Refs #19435. SystemInfo::watch_file receives thread settings. Signed-off-by: Miguel Company <[email protected]> * Refs #19435. Added RTPSDomain::set_filewatch_thread_config Signed-off-by: Miguel Company <[email protected]> * Refs #19435. Call RTPSDomain::set_filewatch_thread_config inside DomainParticipantFactory::create_participant Signed-off-by: Miguel Company <[email protected]> * Refs #19435. Change priority default value. Signed-off-by: Miguel Company <[email protected]> * Refs #19435. Account for default values in threading_pthread Signed-off-by: Miguel Company <[email protected]> * Refs #19435. Account for default values in threading_osx Signed-off-by: Miguel Company <[email protected]> * Refs #19435. Account for default values in threading_win32 Signed-off-by: Miguel Company <[email protected]> * Refs #19435. Linters. Signed-off-by: Miguel Company <[email protected]> * Refs #19435. Use C++ headers. Signed-off-by: Miguel Company <[email protected]> * Refs #19435. Documentation updates. Signed-off-by: Miguel Company <[email protected]> * Refs #19435. Suggestions on Log test. Signed-off-by: Miguel Company <[email protected]> * Refs #19435. Removed unused overload of create_thread. Signed-off-by: Miguel Company <[email protected]> --------- Signed-off-by: Miguel Company <[email protected]> Co-authored-by: Eduardo Ponz Segrelles <[email protected]> * Add XML support for ThreadSettings (#3922) * Refs #19378: Add threadSettingsTypes to XSD schema Signed-off-by: EduPonz <[email protected]> * Refs #19378: Add unit test for parsing thread_settings XML elements Signed-off-by: EduPonz <[email protected]> * Refs #19378: Add getXMLThreadSettings to XMLElementParser Signed-off-by: EduPonz <[email protected]> * Refs #19378: Add Log test cases to XMLProfileParserBasicTests.thread_settings_qos test Signed-off-by: EduPonz <[email protected]> * Refs #19378: Add XML ThreadSettings config to Log Signed-off-by: EduPonz <[email protected]> * Refs #19378: Add domainparticipant_factory XML tag tests Signed-off-by: EduPonz <[email protected]> * Refs #19378: Add domainparticipant_factory XSD Signed-off-by: EduPonz <[email protected]> * Refs #19378: Add XML ThreadSettings config to DomainParticipantFactory Signed-off-by: EduPonz <[email protected]> * Refs #19378: Add getXMLEntityFactoryQos unit test Signed-off-by: EduPonz <[email protected]> * Refs #19378: Add domainparticipant XML thread settings tests Signed-off-by: EduPonz <[email protected]> * Refs #19378: Add XML ThreadSettings config to DomainParticipant Signed-off-by: EduPonz <[email protected]> * Refs #19378: Uncrustify Signed-off-by: EduPonz <[email protected]> * Refs #19378: Add parseXMLReceptionThreads API & unit test Signed-off-by: EduPonz <[email protected]> * Refs #19378: Add transport descriptor XML thread settings tests Signed-off-by: EduPonz <[email protected]> * Refs #19378: Add parseXMLReceptionThreads implementation Signed-off-by: EduPonz <[email protected]> * Refs #19378: Add transport descriptor XML thread settings config Signed-off-by: EduPonz <[email protected]> * Refs #19378: Add datareader XML thread settings tests Signed-off-by: EduPonz <[email protected]> * Refs #19378: Add datareader XML thread settings Signed-off-by: EduPonz <[email protected]> * Refs #19378: Add builtin_transports_reception_threads to domainparticipant XML test Signed-off-by: EduPonz <[email protected]> * Refs #19378: Add builtin_transports_reception_threads to domainparticipant XML Signed-off-by: EduPonz <[email protected]> * Refs #19378: Fix Windows warning regarding sscanf Signed-off-by: EduPonz <[email protected]> * Refs #19378: Fix flow controllers unittests build when using Fast CDR as thirdparty Signed-off-by: EduPonz <[email protected]> * Refs #19378: Apply Miguel's suggestions Signed-off-by: EduPonz <[email protected]> * Refs #19378: Apply some other suggestions Signed-off-by: EduPonz <[email protected]> * Refs #19378. OSx has neither `SCHED_BATCH` nor `SCHED_IDLE` Signed-off-by: Miguel Company <[email protected]> * Refs #19378. Check result on pthread_setschedparam Signed-off-by: Miguel Company <[email protected]> * Refs #19378. Add include on `threading_osx.ipp` Signed-off-by: Miguel Company <[email protected]> * Refs #19378. Avoid using gettid on `threading_osx.ipp` Signed-off-by: Miguel Company <[email protected]> * Refs #19378: Fix mac warning Signed-off-by: EduPonz <[email protected]> --------- Signed-off-by: EduPonz <[email protected]> Signed-off-by: Miguel Company <[email protected]> Co-authored-by: Miguel Company <[email protected]> * Fix doxygen (#3987) Signed-off-by: EduPonz <[email protected]> * Parse missing TCPTransportDescriptor XML elements (#4001) * Refs #19378: Set DomainParticipantFactoryQos when loading profiles Signed-off-by: EduPonz <[email protected]> * Refs #19378: Parse missing TCPTransportDescriptor XML elements Signed-off-by: EduPonz <[email protected]> --------- Signed-off-by: EduPonz <[email protected]> * Custom eprosima::thread class that allows setting the stack size (#4000) * Refs #19797. Initial refactor. eprosima::thread inherits from std::thread. Signed-off-by: Miguel Company <[email protected]> * Refs #19797. Update code in ResourceEvent. Signed-off-by: Miguel Company <[email protected]> * Refs #19797. Using eprosima::thread instead of std::thread. Signed-off-by: Miguel Company <[email protected]> * Refs #19797. Include `<thread>` where `std::this_thread` is used. Signed-off-by: Miguel Company <[email protected]> * Refs #19797. Copy basic eprosima::thread implementation into ipp files. Signed-off-by: Miguel Company <[email protected]> * Refs #19797. Select ipp file depending on platform. Signed-off-by: Miguel Company <[email protected]> * Refs #19797. Copy windows implementation on `thread_impl_win32.ipp` Signed-off-by: Miguel Company <[email protected]> * Refs #19797. Added `is_calling_thread method`. Signed-off-by: Miguel Company <[email protected]> * Refs #19797. Using `is_calling_thread` instead of comparing ids. Signed-off-by: Miguel Company <[email protected]> * Refs #19797. Using stack size argument. Signed-off-by: Miguel Company <[email protected]> * Refs #19797. Update test. Signed-off-by: Miguel Company <[email protected]> * Refs #19797. Implementation for pthread based platforms. Signed-off-by: Miguel Company <[email protected]> * Refs #19797. Use pthread based implementation on Mac. Signed-off-by: Miguel Company <[email protected]> * Refs #19797. Change windows implementation approach. Signed-off-by: Miguel Company <[email protected]> * Refs #19797. Factor out common code. Signed-off-by: Miguel Company <[email protected]> * Refs #19797. Linter Signed-off-by: Miguel Company <[email protected]> * Refs #19797. Use local `swap` method. Signed-off-by: Miguel Company <[email protected]> * Refs #19797. Pass 0 value to `pthread_attr_setstacksize`. Signed-off-by: Miguel Company <[email protected]> * Refs #19797. Linter Signed-off-by: Miguel Company <[email protected]> * Refs #19797. Improve include what you use. Signed-off-by: Miguel Company <[email protected]> * Refs #19797. Add missing includes Signed-off-by: EduPonz <[email protected]> * Refs #19797. Fix thread settings on dds unit test xml profiles. Signed-off-by: Miguel Company <[email protected]> --------- Signed-off-by: Miguel Company <[email protected]> Signed-off-by: EduPonz <[email protected]> Co-authored-by: EduPonz <[email protected]> * Refs #19907: Add feature to versions.md Signed-off-by: EduPonz <[email protected]> --------- Signed-off-by: Miguel Company <[email protected]> Signed-off-by: Eduardo Ponz <[email protected]> Signed-off-by: EduPonz <[email protected]> Co-authored-by: Miguel Company <[email protected]>

* Setting infraestructure for naming threads (#3821) * Refs #19375. Added internal header for threading utilities. Signed-off-by: Miguel Company <[email protected]> * Refs #19375. Added empty implementation for set_name_to_current_thread. Signed-off-by: Miguel Company <[email protected]> * Refs #19375. Added name on Log thread. Signed-off-by: Miguel Company <[email protected]> * Refs #19375. Added name on shm watchdog thread. Signed-off-by: Miguel Company <[email protected]> * Refs #19375. Added name for filewatch threads. Signed-off-by: Miguel Company <[email protected]> * Refs #19375. Added name on ResourceEvent threads. Signed-off-by: Miguel Company <[email protected]> * Refs #19375. Added name on udp reception thread. Signed-off-by: Miguel Company <[email protected]> * Refs #19375. Added name on shm reception thread. Signed-off-by: Miguel Company <[email protected]> * Refs #19375. Added name on data-sharing reception thread. Signed-off-by: Miguel Company <[email protected]> * Refs #19375. Added name for TCP threads. Signed-off-by: Miguel Company <[email protected]> * Refs #19375. Added name on FlowController thread. Signed-off-by: Miguel Company <[email protected]> * Refs #19375. Added name for SHM dump threads. Signed-off-by: Miguel Company <[email protected]> * Refs #19375. Added initialization callback to LogTopic. Signed-off-by: Miguel Company <[email protected]> * Refs #19375. SecurityManager refactor to receive plugin factory by dependency injection. Signed-off-by: Miguel Company <[email protected]> * Refs #19375. Allow easy overload of creation of builtin plugins. Signed-off-by: Miguel Company <[email protected]> * Refs #19375. RTPSParticipantImpl configures the logging thread. Signed-off-by: Miguel Company <[email protected]> * Refs #19375. Uncrustify. Signed-off-by: Miguel Company <[email protected]> --------- Signed-off-by: Miguel Company <[email protected]> * Platform implementations for set_name_to_current_thread (#3823) * Refs #17492. Added pthread implementation for set_name_to_current_thread Signed-off-by: Miguel Company <[email protected]> * Refs #17492. Added implementation for Windows. Signed-off-by: Miguel Company <[email protected]> * Refs #17492. Added implementation for Mac. Signed-off-by: Miguel Company <[email protected]> * Refs #17492. Added doxygen to threading.hpp Signed-off-by: Miguel Company <[email protected]> * Refs #17492. Using pthread implementation for Android. Signed-off-by: Miguel Company <[email protected]> * Refs #17492. Fix build error on snprintf. Signed-off-by: Miguel Company <[email protected]> --------- Signed-off-by: Miguel Company <[email protected]> * Add ThreadSettings to Qos (#3848) * Refs #19377: Add ThreadSettings struct Signed-off-by: Eduardo Ponz <[email protected]> * Refs #19377: Add ThreadSetting to Log API Signed-off-by: Eduardo Ponz <[email protected]> * Refs #19377: Add ThreadSetting to DomainParticipantFactoryQos Signed-off-by: Eduardo Ponz <[email protected]> * Refs #19377: Add ThreadSetting to DomainParticipantQos Signed-off-by: Eduardo Ponz <[email protected]> * Refs #19377: Add ThreadSetting to TransportConfigQos Signed-off-by: Eduardo Ponz <[email protected]> * Refs #19377: Add ThreadSetting to TransportDescriptorInterface Signed-off-by: Eduardo Ponz <[email protected]> * Refs #19377: Add ThreadSetting to SharedMemTransportDescriptor Signed-off-by: Eduardo Ponz <[email protected]> * Refs #19377: Add ThreadSetting to FlowControllerDescriptor Signed-off-by: Eduardo Ponz <[email protected]> * Refs #19377: Add ThreadSetting to DataReaderQos Signed-off-by: Eduardo Ponz <[email protected]> * Refs #19377: Add ThreadSetting to DomainParticipantQos for builtin flow controllers Signed-off-by: Eduardo Ponz <[email protected]> * Refs #19377: Address Miguel's comments in DomainParticipant Signed-off-by: EduPonz <[email protected]> * Refs #19377: Address Miguel's comments in DataReader Signed-off-by: EduPonz <[email protected]> * Refs #19377: Address Miguel's comments in ParticipantTests Signed-off-by: EduPonz <[email protected]> * Refs #19377: Address Miguel's comments in QosConverters Signed-off-by: EduPonz <[email protected]> * Refs #19377: Address Miguel's comments in Transport descriptors Signed-off-by: EduPonz <[email protected]> * Refs #19377: Address Miguel's comments in DataReaderTests Signed-off-by: EduPonz <[email protected]> * Refs #19377: Address Miguel's comments in RTPSParticipantAttibutes Signed-off-by: EduPonz <[email protected]> * Refs #19377: Address Miguel's comments in PortBasedTransportDescriptor Signed-off-by: EduPonz <[email protected]> * Refs #19377: Add builtin_controllers_sender_thread to UpdatableDomainParticipantQos Signed-off-by: EduPonz <[email protected]> * Refs #19377: Refactor PortBasedTransportDescriptor accessors Signed-off-by: EduPonz <[email protected]> * Refs #19377: Add TCP related thread settings Signed-off-by: EduPonz <[email protected]> * Refs #19377: Add data_sharing_listener_thread to ReaderAttributes Signed-off-by: EduPonz <[email protected]> * Refs #19377: Fix windows warning Signed-off-by: EduPonz <[email protected]> --------- Signed-off-by: Eduardo Ponz <[email protected]> Signed-off-by: EduPonz <[email protected]> * Apply thread settings (#3874) * Refs #19436. Added thread creation wrapper infrastructure. Signed-off-by: Miguel Company <[email protected]> * Refs #19436. Added empty implementation for apply_thread_settings_to_current_thread. Signed-off-by: Miguel Company <[email protected]> * Refs #19436. Refactor on Log.cpp Signed-off-by: Miguel Company <[email protected]> * Refs #19436. Add implementation for setting scheduler and priority. Signed-off-by: Miguel Company <[email protected]> * Refs #19436. Add implementation for setting cpu affinity. Signed-off-by: Miguel Company <[email protected]> * Refs #19436. Add test setting config for Log thread. Signed-off-by: Miguel Company <[email protected]> * Refs #19436. Fix SystemInfoTests link issue. Signed-off-by: Miguel Company <[email protected]> * Refs #19436. Changes on ResourceEvent. Signed-off-by: Miguel Company <[email protected]> * Refs #19436. Changes on DataSharingListener. Signed-off-by: Miguel Company <[email protected]> * Refs #19436. Changes on FlowControllerImpl. Signed-off-by: Miguel Company <[email protected]> * Refs #19436. Changes on security LogTopic. Signed-off-by: Miguel Company <[email protected]> * Refs #19436. Apply settings on SharedMemWatchdog. Signed-off-by: Miguel Company <[email protected]> * Refs #19436. Apply settings on SharedMem reception threads. Signed-off-by: Miguel Company <[email protected]> * Refs #19436. Apply settings on SharedMem packet dump threads. Signed-off-by: Miguel Company <[email protected]> * Refs #19436. Apply settings on UDP reception threads. Signed-off-by: Miguel Company <[email protected]> * Refs #19436. Apply settings on TCP accept and keep_alive threads. Signed-off-by: Miguel Company <[email protected]> * Refs #19436. Apply settings on TCP reception threads. Signed-off-by: Miguel Company <[email protected]> * Refs #19436. Include what you use. Signed-off-by: Miguel Company <[email protected]> * Refs #19436. Add MacOS implementation for setting scheduler and priority. Signed-off-by: Miguel Company <[email protected]> * Refs #19436. Add MacOS implementation for setting thread affinity. Signed-off-by: Miguel Company <[email protected]> * Refs #19437. Member cpu_mask changed to affinity and made it 64 bits. Signed-off-by: Miguel Company <[email protected]> * Refs #19437. Windows implementation for thread affinity. Signed-off-by: Miguel Company <[email protected]> * Refs #19437. Windows implementation for thread priority. Signed-off-by: Miguel Company <[email protected]> * Refs #19436. Made `get_thread_config_for_port` a const method. Signed-off-by: Miguel Company <[email protected]> * Refs #19436. Apply suggestions from code review. Signed-off-by: Miguel Company <[email protected]> Co-authored-by: Eduardo Ponz Segrelles <[email protected]> * Refs #19435. Some refactors on FileWatch: - Namespace moved to eprosima::filewatch - Constructor receives thread settings - Copy constructors deleted Signed-off-by: Miguel Company <[email protected]> * Refs #19435. SystemInfo::watch_file receives thread settings. Signed-off-by: Miguel Company <[email protected]> * Refs #19435. Added RTPSDomain::set_filewatch_thread_config Signed-off-by: Miguel Company <[email protected]> * Refs #19435. Call RTPSDomain::set_filewatch_thread_config inside DomainParticipantFactory::create_participant Signed-off-by: Miguel Company <[email protected]> * Refs #19435. Change priority default value. Signed-off-by: Miguel Company <[email protected]> * Refs #19435. Account for default values in threading_pthread Signed-off-by: Miguel Company <[email protected]> * Refs #19435. Account for default values in threading_osx Signed-off-by: Miguel Company <[email protected]> * Refs #19435. Account for default values in threading_win32 Signed-off-by: Miguel Company <[email protected]> * Refs #19435. Linters. Signed-off-by: Miguel Company <[email protected]> * Refs #19435. Use C++ headers. Signed-off-by: Miguel Company <[email protected]> * Refs #19435. Documentation updates. Signed-off-by: Miguel Company <[email protected]> * Refs #19435. Suggestions on Log test. Signed-off-by: Miguel Company <[email protected]> * Refs #19435. Removed unused overload of create_thread. Signed-off-by: Miguel Company <[email protected]> --------- Signed-off-by: Miguel Company <[email protected]> Co-authored-by: Eduardo Ponz Segrelles <[email protected]> * Add XML support for ThreadSettings (#3922) * Refs #19378: Add threadSettingsTypes to XSD schema Signed-off-by: EduPonz <[email protected]> * Refs #19378: Add unit test for parsing thread_settings XML elements Signed-off-by: EduPonz <[email protected]> * Refs #19378: Add getXMLThreadSettings to XMLElementParser Signed-off-by: EduPonz <[email protected]> * Refs #19378: Add Log test cases to XMLProfileParserBasicTests.thread_settings_qos test Signed-off-by: EduPonz <[email protected]> * Refs #19378: Add XML ThreadSettings config to Log Signed-off-by: EduPonz <[email protected]> * Refs #19378: Add domainparticipant_factory XML tag tests Signed-off-by: EduPonz <[email protected]> * Refs #19378: Add domainparticipant_factory XSD Signed-off-by: EduPonz <[email protected]> * Refs #19378: Add XML ThreadSettings config to DomainParticipantFactory Signed-off-by: EduPonz <[email protected]> * Refs #19378: Add getXMLEntityFactoryQos unit test Signed-off-by: EduPonz <[email protected]> * Refs #19378: Add domainparticipant XML thread settings tests Signed-off-by: EduPonz <[email protected]> * Refs #19378: Add XML ThreadSettings config to DomainParticipant Signed-off-by: EduPonz <[email protected]> * Refs #19378: Uncrustify Signed-off-by: EduPonz <[email protected]> * Refs #19378: Add parseXMLReceptionThreads API & unit test Signed-off-by: EduPonz <[email protected]> * Refs #19378: Add transport descriptor XML thread settings tests Signed-off-by: EduPonz <[email protected]> * Refs #19378: Add parseXMLReceptionThreads implementation Signed-off-by: EduPonz <[email protected]> * Refs #19378: Add transport descriptor XML thread settings config Signed-off-by: EduPonz <[email protected]> * Refs #19378: Add datareader XML thread settings tests Signed-off-by: EduPonz <[email protected]> * Refs #19378: Add datareader XML thread settings Signed-off-by: EduPonz <[email protected]> * Refs #19378: Add builtin_transports_reception_threads to domainparticipant XML test Signed-off-by: EduPonz <[email protected]> * Refs #19378: Add builtin_transports_reception_threads to domainparticipant XML Signed-off-by: EduPonz <[email protected]> * Refs #19378: Fix Windows warning regarding sscanf Signed-off-by: EduPonz <[email protected]> * Refs #19378: Fix flow controllers unittests build when using Fast CDR as thirdparty Signed-off-by: EduPonz <[email protected]> * Refs #19378: Apply Miguel's suggestions Signed-off-by: EduPonz <[email protected]> * Refs #19378: Apply some other suggestions Signed-off-by: EduPonz <[email protected]> * Refs #19378. OSx has neither `SCHED_BATCH` nor `SCHED_IDLE` Signed-off-by: Miguel Company <[email protected]> * Refs #19378. Check result on pthread_setschedparam Signed-off-by: Miguel Company <[email protected]> * Refs #19378. Add include on `threading_osx.ipp` Signed-off-by: Miguel Company <[email protected]> * Refs #19378. Avoid using gettid on `threading_osx.ipp` Signed-off-by: Miguel Company <[email protected]> * Refs #19378: Fix mac warning Signed-off-by: EduPonz <[email protected]> --------- Signed-off-by: EduPonz <[email protected]> Signed-off-by: Miguel Company <[email protected]> Co-authored-by: Miguel Company <[email protected]> * Fix doxygen (#3987) Signed-off-by: EduPonz <[email protected]> * Parse missing TCPTransportDescriptor XML elements (#4001) * Refs #19378: Set DomainParticipantFactoryQos when loading profiles Signed-off-by: EduPonz <[email protected]> * Refs #19378: Parse missing TCPTransportDescriptor XML elements Signed-off-by: EduPonz <[email protected]> --------- Signed-off-by: EduPonz <[email protected]> * Custom eprosima::thread class that allows setting the stack size (#4000) * Refs #19797. Initial refactor. eprosima::thread inherits from std::thread. Signed-off-by: Miguel Company <[email protected]> * Refs #19797. Update code in ResourceEvent. Signed-off-by: Miguel Company <[email protected]> * Refs #19797. Using eprosima::thread instead of std::thread. Signed-off-by: Miguel Company <[email protected]> * Refs #19797. Include `<thread>` where `std::this_thread` is used. Signed-off-by: Miguel Company <[email protected]> * Refs #19797. Copy basic eprosima::thread implementation into ipp files. Signed-off-by: Miguel Company <[email protected]> * Refs #19797. Select ipp file depending on platform. Signed-off-by: Miguel Company <[email protected]> * Refs #19797. Copy windows implementation on `thread_impl_win32.ipp` Signed-off-by: Miguel Company <[email protected]> * Refs #19797. Added `is_calling_thread method`. Signed-off-by: Miguel Company <[email protected]> * Refs #19797. Using `is_calling_thread` instead of comparing ids. Signed-off-by: Miguel Company <[email protected]> * Refs #19797. Using stack size argument. Signed-off-by: Miguel Company <[email protected]> * Refs #19797. Update test. Signed-off-by: Miguel Company <[email protected]> * Refs #19797. Implementation for pthread based platforms. Signed-off-by: Miguel Company <[email protected]> * Refs #19797. Use pthread based implementation on Mac. Signed-off-by: Miguel Company <[email protected]> * Refs #19797. Change windows implementation approach. Signed-off-by: Miguel Company <[email protected]> * Refs #19797. Factor out common code. Signed-off-by: Miguel Company <[email protected]> * Refs #19797. Linter Signed-off-by: Miguel Company <[email protected]> * Refs #19797. Use local `swap` method. Signed-off-by: Miguel Company <[email protected]> * Refs #19797. Pass 0 value to `pthread_attr_setstacksize`. Signed-off-by: Miguel Company <[email protected]> * Refs #19797. Linter Signed-off-by: Miguel Company <[email protected]> * Refs #19797. Improve include what you use. Signed-off-by: Miguel Company <[email protected]> * Refs #19797. Add missing includes Signed-off-by: EduPonz <[email protected]> * Refs #19797. Fix thread settings on dds unit test xml profiles. Signed-off-by: Miguel Company <[email protected]> --------- Signed-off-by: Miguel Company <[email protected]> Signed-off-by: EduPonz <[email protected]> Co-authored-by: EduPonz <[email protected]> * Refs #19907: Add feature to versions.md Signed-off-by: EduPonz <[email protected]> --------- Signed-off-by: Miguel Company <[email protected]> Signed-off-by: Eduardo Ponz <[email protected]> Signed-off-by: EduPonz <[email protected]> Co-authored-by: Miguel Company <[email protected]> Signed-off-by: adriancampo <[email protected]>

EduPonz added the needs-review PR that is ready to be reviewed label Sep 13, 2023

EduPonz added this to the v2.13.0 milestone Sep 13, 2023

EduPonz force-pushed the feature/thread-config/qos branch from ab74a2c to a906d6d Compare September 13, 2023 18:16

EduPonz force-pushed the feature/thread-config/main branch from 7d8daaf to bc43719 Compare September 13, 2023 18:17

EduPonz force-pushed the feature/thread-config/qos branch from a906d6d to 6d54ec4 Compare September 13, 2023 18:19

EduPonz added the ci-pending PR which CI is running label Sep 13, 2023

EduPonz force-pushed the feature/thread-config/qos branch from 6d54ec4 to 86af233 Compare September 14, 2023 09:00

MiguelCompany requested changes Sep 18, 2023

View reviewed changes

MiguelCompany changed the title ~~[1937] Add ThreadSettings to Qos~~ [19377] Add ThreadSettings to Qos Sep 18, 2023

EduPonz added 10 commits September 21, 2023 12:21

Refs #19377: Add ThreadSettings struct

b0d66d5

Signed-off-by: Eduardo Ponz <[email protected]>

Refs #19377: Add ThreadSetting to Log API

81d0ee6

Signed-off-by: Eduardo Ponz <[email protected]>

Refs #19377: Add ThreadSetting to DomainParticipantFactoryQos

18ed969

Signed-off-by: Eduardo Ponz <[email protected]>

Refs #19377: Add ThreadSetting to DomainParticipantQos

cc7598a

Signed-off-by: Eduardo Ponz <[email protected]>

Refs #19377: Add ThreadSetting to TransportConfigQos

88ea706

Signed-off-by: Eduardo Ponz <[email protected]>

Refs #19377: Add ThreadSetting to TransportDescriptorInterface

685676d

Signed-off-by: Eduardo Ponz <[email protected]>

Refs #19377: Add ThreadSetting to SharedMemTransportDescriptor

ccec7e1

Signed-off-by: Eduardo Ponz <[email protected]>

Refs #19377: Add ThreadSetting to FlowControllerDescriptor

a1761a1

Signed-off-by: Eduardo Ponz <[email protected]>

Refs #19377: Add ThreadSetting to DataReaderQos

5b4b305

Signed-off-by: Eduardo Ponz <[email protected]>

Refs #19377: Add ThreadSetting to DomainParticipantQos for builtin fl…

f82f4fa

…ow controllers Signed-off-by: Eduardo Ponz <[email protected]>

EduPonz force-pushed the feature/thread-config/main branch from bc43719 to 65f9cc1 Compare September 21, 2023 10:26

EduPonz force-pushed the feature/thread-config/qos branch from 86af233 to f82f4fa Compare September 21, 2023 10:26

EduPonz added 5 commits September 21, 2023 21:37

Refs #19377: Address Miguel's comments in DomainParticipant

889e062

Signed-off-by: EduPonz <[email protected]>

Refs #19377: Address Miguel's comments in DataReader

0a3eb53

Signed-off-by: EduPonz <[email protected]>

Refs #19377: Address Miguel's comments in ParticipantTests

134fafe

Signed-off-by: EduPonz <[email protected]>

Refs #19377: Address Miguel's comments in QosConverters

b582bef

Signed-off-by: EduPonz <[email protected]>

Refs #19377: Address Miguel's comments in Transport descriptors

f29daf8

Signed-off-by: EduPonz <[email protected]>

EduPonz force-pushed the feature/thread-config/qos branch from d0f05ab to f29daf8 Compare September 21, 2023 19:39

MiguelCompany requested changes Sep 22, 2023

View reviewed changes

EduPonz added 2 commits September 22, 2023 14:22

Refs #19377: Add builtin_controllers_sender_thread to UpdatableDomain…

354fb2e

…ParticipantQos Signed-off-by: EduPonz <[email protected]>

Refs #19377: Refactor PortBasedTransportDescriptor accessors

43be267

Signed-off-by: EduPonz <[email protected]>

MiguelCompany approved these changes Sep 22, 2023

View reviewed changes

Refs #19377: Add TCP related thread settings

4b2bb7a

Signed-off-by: EduPonz <[email protected]>

MiguelCompany approved these changes Sep 25, 2023

View reviewed changes

MiguelCompany removed the needs-review PR that is ready to be reviewed label Sep 25, 2023

MiguelCompany requested changes Sep 25, 2023

View reviewed changes

include/fastdds/dds/subscriber/qos/DataReaderQos.hpp Show resolved Hide resolved

Refs #19377: Add data_sharing_listener_thread to ReaderAttributes

d278ba0

Signed-off-by: EduPonz <[email protected]>

MiguelCompany approved these changes Sep 25, 2023

View reviewed changes

Refs #19377: Fix windows warning

e55db30

Signed-off-by: EduPonz <[email protected]>

EduPonz merged this pull request into feature/thread-config/main Sep 27, 2023
8 of 12 checks passed

EduPonz deleted the feature/thread-config/qos branch September 27, 2023 05:16

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[19377] Add ThreadSettings to Qos #3848

[19377] Add ThreadSettings to Qos #3848

EduPonz commented Sep 13, 2023 •

edited by MiguelCompany

Loading

EduPonz commented Sep 13, 2023

EduPonz commented Sep 21, 2023

EduPonz commented Sep 22, 2023

MiguelCompany left a comment

MiguelCompany commented Sep 25, 2023

EduPonz commented Sep 25, 2023

EduPonz commented Sep 26, 2023

EduPonz commented Sep 26, 2023

EduPonz commented Sep 26, 2023

[19377] Add ThreadSettings to Qos #3848

[19377] Add ThreadSettings to Qos #3848

Conversation

EduPonz commented Sep 13, 2023 • edited by MiguelCompany Loading

Description

Contributor Checklist

Reviewer Checklist

EduPonz commented Sep 13, 2023

EduPonz commented Sep 21, 2023

EduPonz commented Sep 22, 2023

MiguelCompany left a comment

Choose a reason for hiding this comment

MiguelCompany commented Sep 25, 2023

EduPonz commented Sep 25, 2023

EduPonz commented Sep 26, 2023

EduPonz commented Sep 26, 2023

EduPonz commented Sep 26, 2023

EduPonz commented Sep 13, 2023 •

edited by MiguelCompany

Loading