Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix script used to generate source from idl files [19187] #3707

Closed
wants to merge 1 commit into from
Closed

Fix script used to generate source from idl files [19187] #3707

wants to merge 1 commit into from

Conversation

richiware
Copy link
Member

@richiware richiware commented Jul 12, 2023 •
edited by JesusPoderoso
Loading

Description

Contributor Checklist

  • Commit messages follow the project guidelines.
  • The code follows the style guidelines of this project.
  • N/A Tests that thoroughly check the new feature have been added/Regression tests checking the bug and its fix have been added; the added tests pass locally
  • N/A Any new/modified methods have been properly documented using Doxygen.
  • N/A Changes are ABI compatible.
  • N/A Changes are API compatible.
  • N/A New feature has been added to the versions.md file (if applicable).
  • N/A New feature has been documented/Current behavior is correctly described in the documentation.
  • N/A Applicable backports have been included in the description.

Reviewer Checklist

  • The PR has a milestone assigned.
  • Check contributor checklist is correct.
  • Check CI results: changes do not issue any warning.
  • Check CI results: failing tests are unrelated with the changes.

@richiware
Refs #19186. Fix not generated code
3b8f340 
Signed-off-by: Ricardo González Moreno <[email protected]>
@richiware richiware changed the title Fix script used to generate source from idl files Fix script used to generate source from idl files [19187] Jul 12, 2023
JLBuenoLopez
JLBuenoLopez approved these changes Jul 12, 2023
View reviewed changes
Copy link
Contributor

@JLBuenoLopez JLBuenoLopez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@richiware richiware added this to the v2.12.0 milestone Jul 18, 2023
@JesusPoderoso JesusPoderoso added the ready-to-merge Ready to be merged. CI and changes have been reviewed and approved. label Aug 18, 2023
@richiware
Copy link
Member Author

Closed in favour of #3828

@richiware
Copy link
Member Author

Closed in favour of #3828

@richiware richiware closed this Sep 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JLBuenoLopez JLBuenoLopez JLBuenoLopez approved these changes

Assignees
No one assigned
Labels
ready-to-merge Ready to be merged. CI and changes have been reviewed and approved.
Projects
None yet
Milestone
v2.12.0
Development

Successfully merging this pull request may close these issues.
3 participants
@richiware @JLBuenoLopez @JesusPoderoso