-
Notifications
You must be signed in to change notification settings - Fork 774
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add XSD for static discovery [17842] #3404
Conversation
287245b
to
a3dc386
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It would be desirable to have the following milestones to merge this pull request:
- Install this schema as the profiles XSD done in
src/fastrtps/CMakeLists.txt
line 542 - Include system test as the profiles XSD done in
src/fastrtps/test/system/tools/fastdds/CMakeLists.txt
with all xml documents with the sufix*_static_disc.xml
, and include it in thetests.py
file
Note: the CLI command fastdds xml validate
would be used. It automatically uses the profiles schema, but adding -x path/to/installed/static_discovery/schema.xsd
would validate the given *_static_disc.xml
files against the given schema.
a3dc386
to
736d7de
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Blackbox tests include some XML files that require a previous CMake configuration (for instance test/blackbox/PubSubreader_static_disc.xml.in
). It would be nice to configure and validate them as well.
6579321
to
d39407a
Compare
@richiprosima please test this |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM with green CI
@richiprosima Please test windows |
Signed-off-by: Ricardo González Moreno <[email protected]>
Signed-off-by: JesusPoderoso <[email protected]>
Signed-off-by: JesusPoderoso <[email protected]>
Signed-off-by: JesusPoderoso <[email protected]>
Signed-off-by: JesusPoderoso <[email protected]>
b3f8b13
d39407a
to
b3f8b13
Compare
Description
This PR adds a new resources: an XSD file to validates static discovery XML files.
Contributor Checklist
versions.md
file (if applicable).Reviewer Checklist