Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[17628] Add Windows CI workflow #3367

Merged
merged 23 commits into from
Jun 22, 2023
Merged

[17628] Add Windows CI workflow #3367

merged 23 commits into from
Jun 22, 2023

Conversation

EduPonz
Copy link

@EduPonz EduPonz commented Mar 15, 2023 •
edited
Loading

Description

This PR takes the Windows related work done by @MiguelBarro in #2755 to create:

  1. A Windows reusable workflow to run CI
  2. A manually runnable workflow which is also triggered on PRs and pushes to all maintained branches
  3. A nightly workflow to dispatch CI with and without security once a day

Contributor Checklist

  • Commit messages follow the project guidelines.
  • The code follows the style guidelines of this project.
  • N/A: Tests that thoroughly check the new feature have been added/Regression tests checking the bug and its fix have been added; the added tests pass locally
  • N/A: Any new/modified methods have been properly documented using Doxygen.
  • N/A: Changes are ABI compatible.
  • N/A: Changes are API compatible.
  • N/A: New feature has been added to the versions.md file (if applicable).
  • N/A: New feature has been documented/Current behavior is correctly described in the documentation.
  • N/A: Applicable backports have been included in the description.

Reviewer Checklist

  • The PR has a milestone assigned.
  • Check contributor checklist is correct.
  • Check CI results: changes do not issue any warning.
  • Check CI results: failing tests are unrelated with the changes.

@EduPonz EduPonz added this to the v2.10.0 milestone Mar 15, 2023
jsan-rt
jsan-rt suggested changes Mar 26, 2023
View reviewed changes
.github/workflows/windows-ci.yml Outdated Show resolved Hide resolved
.github/workflows/reusable-windows-ci.yml Outdated Show resolved Hide resolved
.github/workflows/reusable-windows-ci.yml Outdated Show resolved Hide resolved
.github/workflows/reusable-windows-ci.yml Outdated Show resolved Hide resolved
.github/workflows/reusable-windows-ci.yml Outdated Show resolved Hide resolved
.github/workflows/windows-ci.yml Outdated Show resolved Hide resolved
@MiguelCompany MiguelCompany modified the milestones: v2.10.0, v2.10.2 Apr 1, 2023
@EduPonz
Refs #17628: Add Windows CI workflow
d09dba2 
Signed-off-by: Eduardo Ponz <[email protected]>
@EduPonz
Refs #17628: Avoid concurrent redundant workflows
e4520ab 
Signed-off-by: Eduardo Ponz <[email protected]>
@EduPonz
Refs #17628: Do not try to create src dir again
c7e7cb7 
Signed-off-by: Eduardo Ponz <[email protected]>
@EduPonz
Refs #17628: Add --no-warn-unused-cli as cmake-arg
d5f2209 
Signed-off-by: Eduardo Ponz <[email protected]>
@EduPonz
Refs #17628: Check build step outcome before testing
7ac7e9c 
Signed-off-by: Eduardo Ponz <[email protected]>
@EduPonz
Refs #17628: Add --merge-install to colcon test command
7f29680 
Signed-off-by: Eduardo Ponz <[email protected]>
@EduPonz
Refs #17628: Repeat until pass 3
0740115 
Signed-off-by: Eduardo Ponz <[email protected]>
@EduPonz
Refs #17628: Also upload command.log
e2c56d0 
Signed-off-by: Eduardo Ponz <[email protected]>
@EduPonz
Refs #17628: Apply suggestions
05a7777 
Signed-off-by: Eduardo Ponz <[email protected]>
@EduPonz
Refs #17628: Re run failed tests with colcon instead of with Ctest
7b827f5 
Signed-off-by: Eduardo Ponz <[email protected]>
@EduPonz
Refs #17628: Install xmlschema
918a6d6 
Signed-off-by: Eduardo Ponz <[email protected]>
@EduPonz
Refs #17628: Fix summary generation
dbce032 
Signed-off-by: Eduardo Ponz <[email protected]>
@EduPonz
Refs #17628: Add .repos & .metas for different jobs in the repo
cbbd902 
Signed-off-by: Eduardo Ponz <[email protected]>
jsan-rt
jsan-rt suggested changes May 8, 2023
View reviewed changes
.github/workflows/nightly-windows-ci.yml Outdated Show resolved Hide resolved
@JLBuenoLopez JLBuenoLopez modified the milestones: v2.10.2, v2.11.0 Jun 12, 2023
@jsan-rt jsan-rt force-pushed the feature/windows-ci-github branch 3 times, most recently from 14ceb3f to e5f08f1 Compare June 19, 2023 06:37
@jsan-rt jsan-rt force-pushed the feature/windows-ci-github branch 7 times, most recently from 1d13ab8 to 573dd7a Compare June 19, 2023 09:39
@jsan-rt
Refs 17628: Remove debug traces
737d65d 
Signed-off-by: Javier Santiago <[email protected]>
@Mario-DL
Copy link
Member

Friendly pinging @jsantiago-eProsima @EduPonz

@Mario-DL Mario-DL added the ci-pending PR which CI is running label Jun 20, 2023
EduPonz
EduPonz commented Jun 20, 2023
View reviewed changes
Copy link
Author

@EduPonz EduPonz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

jsan-rt
jsan-rt previously approved these changes Jun 20, 2023
View reviewed changes
@EduPonz
Copy link
Author

EduPonz commented Jun 21, 2023

It'd be good if the names of the failed tests where visible in the summary

@EduPonz EduPonz added ready-to-merge Ready to be merged. CI and changes have been reviewed and approved. and removed ci-pending PR which CI is running labels Jun 22, 2023
@EduPonz
Copy link
Author

EduPonz commented Jun 22, 2023

LGTM

@EduPonz EduPonz merged commit 536fc71 into master Jun 22, 2023
5 of 8 checks passed
@EduPonz EduPonz deleted the feature/windows-ci-github branch June 22, 2023 07:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jsan-rt jsan-rt jsan-rt left review comments

@MiguelBarro MiguelBarro Awaiting requested review from MiguelBarro

Assignees
No one assigned
Labels
ready-to-merge Ready to be merged. CI and changes have been reviewed and approved.
Projects
None yet
Milestone
v2.11.0
Development

Successfully merging this pull request may close these issues.
5 participants
@EduPonz @Mario-DL @jsan-rt @MiguelCompany @JLBuenoLopez