Fix load profiles TSAN issue [17162]

[jparisu]

Signed-off-by: jparisu [email protected]

load_profiles() method is called in a singleton without guards, and this could lead to multiple threads loading files at the same time.
TSAN fails in most tests for this (every time a DomainParticipant is created).

Description

Contributor Checklist

• Commit messages follow the project guidelines.
• The code follows the style guidelines of this project.
• N/A Tests that thoroughly check the new feature have been added/Regression tests checking the bug and its fix have been added; the added tests pass locally
• Any new/modified methods have been properly documented using Doxygen.
• ¿? Changes are ABI compatible.
• Changes are API compatible.
• Documentation builds and tests pass locally.
• New feature has been added to the versions.md file (if applicable).
• N/A New feature has been documented/Current behavior is correctly described in the documentation.

• Applicable backports have been included in the description.

Reviewer Checklist

• Check contributor checklist is correct.
• Check CI results: changes do not issue any warning.
• Check CI results: failing tests are unrelated with the changes.

[MiguelCompany]

This needs a regression test.

    PubSubWriter<HelloWorldPubSubType> participant_1(TEST_TOPIC_NAME);
    participant_1.init();

    auto second_participant_creation = []()
            {
                PubSubReader<HelloWorldPubSubType> participant_2(TEST_TOPIC_NAME);
                participant_2.init();
                participant_2.wait_discovery();
            };

    // Start thread creating second participant
    std::thread thr(second_participant_creation);

    participant_1.wait_discovery();
    thr.join();

[MiguelCompany]

@richiprosima Please test this

[EduPonz]

@jparisu the new test is failing in both windows pipelines, please take a look whenever you have time

[jparisu]

Some issues have been encountered adding this test:

1. ASAN fails randomly because of Dynamic Types
2. Windows fails randomly with this error Assertion failed: open_or_created && winapi::get_last_error() != winapi::error_already_exists, file C:\Users\eProsima\paris_release_debug\src\fastdds\thirdparty\boost\include\boost/interprocess/sync/windows/mutex.hpp, line 65

These errors are not introduced (at least it does not look like) but this PR, but they arise because there weren't previous tests with parallel creation of Domain Participants

[jparisu]

@richiprosima please test windows

[JLBuenoLopez]

@richiprosima please test windows

[JLBuenoLopez]

@jparisu uncrustify job is failing in this PR

[jparisu]

@jparisu uncrustify job is failing in this PR

@JLBuenoLopez-eProsima test introduce in this PR produces several ASAN errors due to not related issues. Do you still want to merge it?

[JLBuenoLopez]

@jparisu, as far as I understand the test introduced in this PR is flaky because the strategy followed in the test has not been used previously. So the test is surfacing some other issue that will have to be deal with at some point. As the CI runs several times the failing tests to check if they are flaky, I am not really concerned about the test failing randomly. @EduPonz, what do you think?

[EduPonz]

@jparisu, as far as I understand the test introduced in this PR is flaky because the strategy followed in the test has not been used previously. So the test is surfacing some other issue that will have to be deal with at some point. As the CI runs several times the failing tests to check if they are flaky, I am not really concerned about the test failing randomly. @EduPonz, what do you think?

We may merge this if we exclude this new test from the TSAN analysis until we fix it

[jparisu]

We may merge this if we exclude this new test from the TSAN analysis until we fix it

It produces ASAN errors, not TSAN errors (that are also produced, but not new ones).

[JLBuenoLopez]

@jparisu, it has been decided that this is going to be merged and afterwards the ASAN errors will be fixed. Can you please fix the uncrustify job so we can proceed? Thanks!

[Mario-DL]

Friendly pinging @jparisu

[Mario-DL]

@richiprosima please test this

[MiguelCompany]

@richiprosima Please test windows

[MiguelCompany]

LGTM with green CI

[MiguelCompany]

@Mergifyio rebase

[mergify]

rebase

✅ Branch has been successfully rebased

[SunnyNetX]

@jparisu Have you solved this problem?how？

Some issues have been encountered adding this test:

1. ASAN fails randomly because of Dynamic Types
2. Windows fails randomly with this error Assertion failed: open_or_created && winapi::get_last_error() != winapi::error_already_exists, file C:\Users\eProsima\paris_release_debug\src\fastdds\thirdparty\boost\include\boost/interprocess/sync/windows/mutex.hpp, line 65

These errors are not introduced (at least it does not look like) but this PR, but they arise because there weren't previous tests with parallel creation of Domain Participants