Skip to content

Commit

Permalink
Refs #21077: Make Endpoints Properties unmutable
Browse files Browse the repository at this point in the history
Signed-off-by: cferreiragonz <[email protected]>
  • Loading branch information
cferreiragonz committed Jun 14, 2024
1 parent a1a12a1 commit e46d809
Show file tree
Hide file tree
Showing 2 changed files with 12 additions and 1 deletion.
6 changes: 6 additions & 0 deletions src/cpp/fastdds/publisher/DataWriterImpl.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -1998,6 +1998,12 @@ bool DataWriterImpl::can_qos_be_updated(
EPROSIMA_LOG_WARNING(RTPS_QOS_CHECK,
"Only the period of Positive ACKs can be changed after the creation of a DataWriter.");
}
if (!(to.properties() == from.properties()))
{
updatable = false;
EPROSIMA_LOG_WARNING(RTPS_QOS_CHECK, "PropertyPolicyQos cannot be changed after the DataWriter is enabled.");
}

return updatable;
}

Expand Down
7 changes: 6 additions & 1 deletion src/cpp/fastdds/subscriber/DataReaderImpl.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -1644,7 +1644,12 @@ bool DataReaderImpl::can_qos_be_updated(
{
updatable = false;
EPROSIMA_LOG_WARNING(RTPS_QOS_CHECK,
"data_sharing_listener_thread cannot be changed after the DataReader is enabled");
"data_sharing_listener_thread cannot be changed after the DataReader is enabled.");
}
if (!(to.properties() == from.properties()))
{
updatable = false;
EPROSIMA_LOG_WARNING(RTPS_QOS_CHECK, "PropertyPolicyQos cannot be changed after the DataReader is enabled.");
}
return updatable;
}
Expand Down

0 comments on commit e46d809

Please sign in to comment.