-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[21416] Enhance Fast DDS docs with a FAQs section covering every subsection #902
Open
depink5
wants to merge
4
commits into
master
Choose a base branch
from
feature/faq
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+2,450
−6
Open
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change | ||||
---|---|---|---|---|---|---|
|
@@ -47,8 +47,7 @@ def download_css(html_css_dir): | |||||
False if not. | ||||||
""" | ||||||
url = ( | ||||||
'https://raw.githubusercontent.com/eProsima/all-docs/' | ||||||
'master/source/_static/css/fiware_readthedocs.css') | ||||||
'https://raw.githubusercontent.com/eProsima/all-docs/master/source/_static/css/fiware_readthedocs.css') | ||||||
try: | ||||||
req = requests.get(url, allow_redirects=True, timeout=10) | ||||||
except requests.RequestException as e: | ||||||
|
@@ -343,7 +342,8 @@ def configure_doxyfile( | |||||
'breathe', | ||||||
'sphinxcontrib.plantuml', | ||||||
'sphinx.ext.autodoc', # Document Pydoc documentation from Python bindings. | ||||||
'sphinx_tabs.tabs' | ||||||
'sphinx_tabs.tabs', | ||||||
'sphinx_toolbox.collapse' | ||||||
] | ||||||
|
||||||
sphinx_tabs_disable_css_loading = False | ||||||
|
@@ -366,6 +366,7 @@ def configure_doxyfile( | |||||
except ImportError: | ||||||
pass | ||||||
|
||||||
|
||||||
# Default behaviour for `autodoc`: always show documented members. | ||||||
autodoc_default_options = { | ||||||
'members': True, | ||||||
|
@@ -461,7 +462,7 @@ def configure_doxyfile( | |||||
|
||||||
suppress_warnings = [ | ||||||
'cpp.duplicate_declaration', | ||||||
'cpp.parse_function_declaration' | ||||||
'cpp.parse_function_declaration', | ||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. restore?
Suggested change
|
||||||
] | ||||||
|
||||||
# Check if we are checking the spelling. In this case... | ||||||
|
@@ -471,6 +472,7 @@ def configure_doxyfile( | |||||
# Avoid the warning of a wrong reference in the TOC entries, | ||||||
# because fails the Python API Reference reference. | ||||||
suppress_warnings.append('toc.excluded') | ||||||
suppress_warnings.append('config.cache') | ||||||
|
||||||
# If true, `todo` and `todoList` produce output, else they produce nothing. | ||||||
todo_include_todos = False | ||||||
|
2 changes: 1 addition & 1 deletion
2
...erence/rtps/participant/participantdiscoveryinfo/ParticipantDiscoveryStatus.rst
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,7 +1,7 @@ | ||
.. rst-class:: api-ref | ||
|
||
ParticipantDiscoveryStatus | ||
---------------------------- | ||
-------------------------- | ||
|
||
.. doxygenenum:: eprosima::fastdds::rtps::ParticipantDiscoveryStatus | ||
:project: FastDDS |
LuciaEchevarria99 marked this conversation as resolved.
Show resolved
Hide resolved
|
Large diffs are not rendered by default.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,140 @@ | ||
.. include:: ../../../03-exports/aliases.include | ||
.. include:: ../../../03-exports/aliases-api.include | ||
.. include:: ../../../03-exports/roles.include | ||
|
||
.. _freq_discovery_questions: | ||
|
||
Discovery Frequently Asked Questions | ||
==================================== | ||
|
||
|
||
.. collapse:: What are the two main phases involved in the discovery process of Fast DDS? | ||
|
||
|
||
|
||
|
||
|br| | ||
|
||
The two main phases involved in the discovery process of Fast DDS are the Participant Discovery Phase (PDP) and the Endpoint Discovery Phase (EDP). | ||
The Participant Discovery Phase (PDP) involves |DomainParticipants-api| recognizing each other by sending periodic announcement messages with their unicast addresses. Matching occurs when they are in the same DDS Domain, using multicast by default, though unicast and announcement frequency can be customized. In the Endpoint Discovery Phase (EDP), DataWriters and DataReaders acknowledge each other by sharing information about topics and data types over the established channels. Matching endpoints with the same topic and data type are then ready to exchange user data. For further information, go to :ref:`disc_phases`. | ||
|
||
------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------- | ||
|
||
.. collapse:: What discovery mechanisms does FastDDS provide? | ||
|
||
|
||
|
||
|
||
|br| | ||
|
||
There are four discovery mechanisms in DDS: Simple Discovery, which follows the RTPS standard for both PDP and EDP, ensuring compatibility with other DDS implementations; Static Discovery, which uses the Simple Participant Discovery Protocol (SPDP) but skips the Endpoint Discovery phase if endpoint details are pre-known; Discovery Server, which employs a centralized server for meta traffic discovery; and Manual Discovery, which disables the PDP and requires users to manually match RTPS participants and endpoints using external meta-information channels. For further information, go to :ref:`disc_mechanisms`. | ||
|
||
------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------- | ||
LuciaEchevarria99 marked this conversation as resolved.
Show resolved
Hide resolved
|
||
|
||
.. collapse:: How can you improve the chances of successful participant discovery when using the SIMPLE discovery protocol, and what role do initial announcements play in this process? | ||
|
||
|
||
|br| | ||
|
||
To improve the chances of successful participant discovery when using the SIMPLE discovery protocol, you can configure initial announcements to send multiple discovery messages at short intervals. This increases the likelihood that DomainParticipants will detect each other despite potential network disruptions or message loss. By adjusting the |InitialAnnouncementConfig::count-api| (number of announcements) and |InitialAnnouncementConfig::period-api| (interval between announcements), you can optimize discovery reliability during startup. For further information, go to :ref:`simple_disc_settings`. | ||
|
||
------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------- | ||
|
||
.. collapse:: What is an initial peer list? | ||
|
||
|
||
|
||
|
||
|br| | ||
|
||
An initial peer list contains one or more IP-port address pairs corresponding to remote DomainParticipants PDP discovery listening resources, so that the local DomainParticipant will not only send its PDP traffic to the default multicast address-port specified by its domain, but also to all the IP-port address pairs specified in the initial peers list. For further information, go to :ref:`simple_disc_settings`. | ||
|
||
------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------- | ||
|
||
.. collapse:: When could a static configuration of peers be used? | ||
|
||
|
||
|
||
|
||
|br| | ||
|
||
When all DataWriters and DataReaders, and their Topics and data types, are known beforehand, the EDP phase can be replaced with a static configuration of peers. For further information, go to :ref:`discovery_static`. | ||
|
||
------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------- | ||
|
||
.. collapse:: What is the primary difference between the Discovery Server mechanism and Simple discovery mechanism in terms of managing metatraffic? | ||
|
||
|
||
|
||
|
||
|br| | ||
|
||
The Discovery Server mechanism is based on a client-server discovery paradigm, the metatraffic is managed by one or several server DomainParticipants, as opposed to simple discovery, where metatraffic is exchanged using a message broadcast mechanism like an IP multicast protocol. For further information, go to :ref:`discovery_server`. | ||
|
||
------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------- | ||
|
||
.. collapse:: What is the primary function of a Discovery Server in the DDS architecture? | ||
|
||
|
||
|
||
|
||
|br| | ||
|
||
The primary function of a Discovery Server in the DDS architecture is to centralize and redistribute discovery information among DomainParticipants, ensuring efficient communication between clients and servers. The server collects discovery data from clients (and other servers) and redistributes it to relevant participants, running a "matching" algorithm to provide only the necessary information for DataWriters and DataReaders to establish communication. It also facilitates server-to-server connections, enabling a more scalable discovery process across the network. For further information, go to :ref:`discovery_server`. | ||
|
||
------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------- | ||
|
||
.. collapse:: What is the primary purpose of a "BACKUP" server in the Discovery Server mechanism? | ||
|
||
|
||
|
||
|
||
|br| | ||
|
||
A ``BACKUP`` server is a server that persists its discovery database into a file. This type of server can load the network graph from a file on start-up without the need of receiving any client's information. For further information, go to :ref:`discovery_server`. | ||
|
||
------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------- | ||
|
||
.. collapse:: What is a client in this context? | ||
|
||
|
||
|
||
|
||
|br| | ||
|
||
A ``CLIENT`` is a participant that connects to one or more servers from which it receives only the discovery information they require to establish communication with matching endpoints. For further information, go to :ref:`discovery_server`. | ||
|
||
------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------- | ||
|
||
.. collapse:: What is the difference between a CLIENT and a SUPER_CLIENT? | ||
|
||
|
||
|
||
|
||
|br| | ||
|
||
A ``SUPER_CLIENT`` is a client that receives the discovery information known by the server, in opposition to clients, which only receive the information they need. For further information, go to :ref:`discovery_server`. | ||
|
||
------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------- | ||
|
||
.. collapse:: What is the purpose of each server specifying its own locator list in the context of discovery configuration? | ||
|
||
|
||
|
||
|
||
|br| | ||
|
||
Each client must keep a list of locators associated to the servers to which it wants to link. Each server specifies its own locator list which must be populated with ``RemoteServerAttributes`` objects with a valid ``metatrafficUnicastLocatorList`` or ``metatrafficMulticastLocatorList``. In XML the server list and its elements are simultaneously specified. For further information, go to :ref:`discovery_server`. | ||
|
||
------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------- | ||
|
||
.. collapse:: What is the typical interval of time between discovery messages sent by clients to servers, as described in the text? | ||
|
||
|
||
|
||
|
||
|br| | ||
|
||
As explained above the clients send discovery messages to the servers at regular intervals (ping period) until they receive message reception acknowledgement. The default value for this period is 450 ms. For further information, go to :ref:`discovery_server`. | ||
|
||
| |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.