Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add custom forwarding routes feature [19249] #56

Merged
merged 8 commits into from
Sep 26, 2023
Merged

Add custom forwarding routes feature [19249] #56

merged 8 commits into from
Sep 26, 2023

Conversation

juanlofer-eprosima
Copy link
Contributor

@juanlofer-eprosima juanlofer-eprosima commented Aug 1, 2023 •
edited
Loading

Pending tasks:

  • YAML tests
  • Revision

@juanlofer-eprosima juanlofer-eprosima mentioned this pull request Aug 1, 2023
Merged
@Tempate Tempate self-requested a review September 1, 2023 09:48
@rsanchez15 rsanchez15 mentioned this pull request Sep 1, 2023
Merged
Tempate
Tempate suggested changes Sep 4, 2023
View reviewed changes
ddspipe_core/src/cpp/communication/dds/DdsBridge.cpp Outdated Show resolved Hide resolved
ddspipe_core/src/cpp/communication/dds/DdsBridge.cpp Outdated Show resolved Hide resolved
ddspipe_core/src/cpp/communication/dds/DdsBridge.cpp Outdated Show resolved Hide resolved
ddspipe_core/src/cpp/core/DdsPipe.cpp Outdated Show resolved Hide resolved
ddspipe_core/include/ddspipe_core/configuration/RoutesConfiguration.hpp Outdated Show resolved Hide resolved
ddspipe_core/include/ddspipe_core/configuration/TopicRoutesConfiguration.hpp Outdated Show resolved Hide resolved
ddspipe_core/src/cpp/communication/dds/DdsBridge.cpp Outdated Show resolved Hide resolved
ddspipe_yaml/src/cpp/YamlReader_features.cpp Show resolved Hide resolved
ddspipe_core/include/ddspipe_core/configuration/RoutesConfiguration.hpp Show resolved Hide resolved
ddspipe_core/include/ddspipe_core/configuration/TopicRoutesConfiguration.hpp Show resolved Hide resolved
@juanlofer-eprosima juanlofer-eprosima changed the title Add custom forwarding routes feature Add custom forwarding routes feature [19249] Sep 25, 2023
@juanlofer-eprosima
Add custom forwarding routes feature
9a7a5cf 
Signed-off-by: Juan López Fernández <[email protected]>
@Tempate @juanlofer-eprosima
Unittests for the routes' configuration YamlReader
343110d 
Signed-off-by: tempate <[email protected]>
@juanlofer-eprosima
Fix compilation warning
9aa26b8 
Signed-off-by: Juan Lopez Fernandez <[email protected]>
@Tempate @juanlofer-eprosima
Uncrustify
cdfee06 
Signed-off-by: tempate <[email protected]>
@juanlofer-eprosima
Apply suggestions
02f506c 
Signed-off-by: Juan Lopez Fernandez <[email protected]>
@juanlofer-eprosima
NIT changes
d0cbaea 
Signed-off-by: Juan Lopez Fernandez <[email protected]>
@juanlofer-eprosima
Do TODOs
25612ab 
Signed-off-by: Juan Lopez Fernandez <[email protected]>
@juanlofer-eprosima
Apply suggestion
deff96f 
Signed-off-by: Juan Lopez Fernandez <[email protected]>
Tempate
Tempate approved these changes Sep 26, 2023
View reviewed changes
Copy link
Contributor

@Tempate Tempate left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Tempate Tempate merged commit 8af9525 into main Sep 26, 2023
12 checks passed
@Tempate Tempate deleted the feature/forwarding-routes branch September 26, 2023 07:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Tempate Tempate Tempate approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@juanlofer-eprosima @Tempate