Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor DiscoveryServerParticipant #127

Open
wants to merge 9 commits into
base: main
Choose a base branch
from
Open

Refactor DiscoveryServerParticipant #127

wants to merge 9 commits into from

Conversation

irenebm
Copy link
Member

@irenebm irenebm commented Sep 2, 2024 •
edited
Loading

@irenebm irenebm changed the base branch from main to integration/bump-3.0.0 September 2, 2024 14:47
@irenebm irenebm marked this pull request as ready for review September 2, 2024 14:54
@irenebm irenebm mentioned this pull request Sep 2, 2024
Draft
@codecov-commenter
Copy link

codecov-commenter commented Sep 2, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 13.68421% with 82 lines in your changes missing coverage. Please review.

Project coverage is 37.74%. Comparing base (4b19122) to head (2b0b750).

Files with missing lines Patch % Lines
...pp/participant/rtps/DiscoveryServerParticipant.cpp 13.68% 75 Missing and 7 partials ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #127      +/-   ##
==========================================
+ Coverage   36.51%   37.74%   +1.22%     
==========================================
  Files         169      152      -17     
  Lines       11542     6976    -4566     
  Branches     5277     2759    -2518     
==========================================
- Hits         4215     2633    -1582     
+ Misses       4582     2966    -1616     
+ Partials     2745     1377    -1368

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Base automatically changed from integration/bump-3.0.0 to main September 10, 2024 14:00
@irenebm
Add listener port to Discovery Server Client TCP Descriptor
d299bf7 
Signed-off-by: Irene Bandera <[email protected]>
@irenebm
Refactor names for clarity
971103d 
Signed-off-by: Irene Bandera <[email protected]>
@irenebm
Separate listening and connection locators to avoid overwrite ports
3565f53 
Signed-off-by: Irene Bandera <[email protected]>
@irenebm
Configure logical port in Discovery Server Client only for TCP
562add3 
Signed-off-by: Irene Bandera <[email protected]>
@irenebm
Refactor code for clarity and separation of concerns
d5e8e59 
Signed-off-by: Irene Bandera <[email protected]>
@irenebm
Add Server IP to Discovery Server Client TCPv6 whitelist
ecf5d94 
Signed-off-by: Irene Bandera <[email protected]>
@irenebm
Uncrustify
1b78b53 
Signed-off-by: Irene Bandera <[email protected]>
@irenebm
Remove unnecessary whitelist and listener port
72e78d0 
Signed-off-by: Irene Bandera <[email protected]>
@irenebm irenebm force-pushed the feature/discovery_server_participant branch from a62ed36 to 72e78d0 Compare September 17, 2024 15:26
@irenebm
Uncrustify
2b0b750 
Signed-off-by: Irene Bandera <[email protected]>
@irenebm irenebm force-pushed the feature/discovery_server_participant branch from 352c8e8 to 2b0b750 Compare September 19, 2024 14:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@irenebm @codecov-commenter