Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removing models related files #40

Merged
merged 3 commits into from
Dec 12, 2023

Conversation

humbleOldSage
Copy link
Contributor

This commit removes the following files as they have been relocated to e-mission-server :

  1. models.py
  2. clustering.py
  3. data_wrangling.py
  4. mapping.py

The move is part of reorganization to keep all the models in the server repo and the evaluation code and notebook in this repository.

The changes where these 4 files are received on e-mission-server is covered by e-mission/e-mission-server#945 .

This commit removes the following files as they have been relocated to e-mission-server :

1. models.py
2.clustering.py
3.data_wrangling.py
4.mapping.py
Updating imports and dependencies after moving four files to e-mission-server.
@humbleOldSage
Copy link
Contributor Author

Partially Tested because even though all the files which had changes were tested successfully, not all the notebooks and python files in the repository were tested.

@humbleOldSage humbleOldSage marked this pull request as ready for review December 1, 2023 05:09
@shankari
Copy link
Contributor

shankari commented Dec 3, 2023

@humbleOldSage when do you plan to be done with all the testing.
Since this PR is marked as "open" (not "draft"), I would assume that it is ready to merge...

@shankari
Copy link
Contributor

shankari commented Dec 3, 2023

This seems fairly straightforward, and I am happy to merge once I see the testing results.

@humbleOldSage
Copy link
Contributor Author

Successfully Tested.

Screenshot 2023-12-05 at 12 57 45 AM

Screenshot 2023-12-05 at 12 59 59 AM

Screenshot 2023-12-05 at 1 00 36 AM

@shankari
Copy link
Contributor

shankari commented Dec 5, 2023

@humbleOldSage these are the new results - can you have them side by side with the old results to make it easier to compare and confirm no regressions?

@humbleOldSage
Copy link
Contributor Author

Sure. With the results below, I can confirm no changes in results.

Successfully Tested.

From Recent run :
Screenshot 2023-12-05 at 12 57 45 AM

From past runs :

Screenshot 2023-11-16 at 5 53 00 PM

From Recent run :
Screenshot 2023-12-05 at 12 59 59 AM

From the paper:
Screenshot 2023-12-11 at 11 27 16 PM

From Recent run :
Screenshot 2023-12-05 at 1 00 36 AM

From the paper:

Screenshot 2023-12-11 at 11 26 57 PM

@shankari shankari merged commit 4662e56 into e-mission:master Dec 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants