PCLOUDS-4901: User labels as groupings to fetch metrics, in order to later add them as dimensions. #536
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
joaquinfilipic-dynatrace
commented
Sep 4, 2024
•
joaquinfilipic-dynatrace
commented
- User defined labels can be retrieved from the timeSeries response API only if they are included in the groupBy query param. So, its behavior depends on the regular way Google Monitor Explorer handles it. User needs to take care of correctly using this feature.
- More info and potential combinations are linked in the Jira ticket.
- Things like reading this specific new parameter only once at the beginning of run_docker were considered, but I didn't think it's worth to start moving params everywhere or adding more load on context. I prefer simplicity here.
- Any other thing, I can correct.
nikita-paskal-dynatrace
previously approved these changes
Sep 10, 2024
joaquinfilipic-dynatrace
force-pushed
the
PCLOUDS-4901-Labels_as_dimensions
branch
from
3fd95b4
to
9905d04
Compare
…ace-oss/dynatrace-gcp-monitor into PCLOUDS-4901-Labels_as_dimensions
|
nikita-paskal-dynatrace
approved these changes
Sep 24, 2024
nikita-paskal-dynatrace
approved these changes
Sep 24, 2024
mateuszadamczakDynatrace
approved these changes
Sep 24, 2024
joaquinfilipic-dynatrace
deleted the
PCLOUDS-4901-Labels_as_dimensions
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.