Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(rollapp): DRS versions #1223

Merged
merged 10 commits into from
Sep 23, 2024
Merged

feat(rollapp): DRS versions #1223

merged 10 commits into from
Sep 23, 2024

Conversation

keruch
Copy link
Contributor

@keruch keruch commented Sep 13, 2024

Description

This PR implements https://www.notion.so/dymension/DRS-Vulnerability-Recovery-5b42195818264165aa72718e0e173f5b


Closes #1207

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow-up issues.

PR review checkboxes:

I have...

  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Targeted PR against the correct branch
  • included the correct type prefix in the PR title
  • Linked to the GitHub issue with discussion and accepted design
  • Targets only one GitHub issue
  • Wrote unit and integration tests
  • Wrote relevant migration scripts if necessary
  • All CI checks have passed
  • Added relevant godoc comments
  • Updated the scripts for local run, e.g genesis_config_commands.sh if the PR changes parameters
  • Add an issue in the e2e-tests repo if necessary

SDK Checklist

  • Import/Export Genesis
  • Registered Invariants
  • Registered Events
  • Updated openapi.yaml
  • No usage of go map
  • No usage of time.Now()
  • Used fixed point arithmetic and not float arithmetic
  • Avoid panicking in Begin/End block as much as possible
  • No unexpected math Overflow
  • Used sendCoin and not SendCoins
  • Out-of-block compute is bounded
  • No serialized ID at the end of store keys
  • UInt to byte conversion should use BigEndian

Full security checklist here


For Reviewer:

  • Confirmed the correct type prefix in the PR title
  • Reviewers assigned
  • Confirmed all author checklist items have been addressed

After reviewer approval:

  • In case the PR targets the main branch, PR should not be squash merge in order to keep meaningful git history.
  • In case the PR targets a release branch, PR must be rebased.

@keruch keruch self-assigned this Sep 16, 2024
@keruch keruch marked this pull request as ready for review September 16, 2024 21:31
@keruch keruch requested a review from a team as a code owner September 16, 2024 21:31
x/rollapp/keeper/msg_server_update_state.go Show resolved Hide resolved
x/rollapp/keeper/rollapp_suite_test.go Outdated Show resolved Hide resolved
x/rollapp/keeper/msg_server_mark_vulnerable_rollapps.go Outdated Show resolved Hide resolved
x/rollapp/keeper/rollapp.go Show resolved Hide resolved
x/rollapp/keeper/rollapp.go Outdated Show resolved Hide resolved
x/rollapp/keeper/rollapp.go Outdated Show resolved Hide resolved
x/rollapp/keeper/msg_server_update_state.go Show resolved Hide resolved
Copy link
Contributor

@danwt danwt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, couple q's

utils/fp/slices/slices.go Outdated Show resolved Hide resolved
utils/fp/slices/slices.go Outdated Show resolved Hide resolved
x/rollapp/keeper/msg_server_mark_vulnerable_rollapps.go Outdated Show resolved Hide resolved
x/rollapp/keeper/fraud_handler.go Show resolved Hide resolved
x/rollapp/types/rollapp.go Show resolved Hide resolved
x/rollapp/types/message_update_state.go Outdated Show resolved Hide resolved
x/rollapp/keeper/rollapp.go Show resolved Hide resolved
x/rollapp/keeper/rollapp.go Show resolved Hide resolved
x/rollapp/keeper/msg_server_update_state.go Outdated Show resolved Hide resolved
@keruch keruch requested a review from danwt September 19, 2024 09:43
danwt
danwt previously approved these changes Sep 19, 2024
Copy link
Contributor

@danwt danwt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great

x/rollapp/keeper/rollapp.go Show resolved Hide resolved
@omritoptix omritoptix changed the title feat(rollapp): added DRS versions feat(rollapp): DRS versions Sep 19, 2024
x/rollapp/keeper/rollapp.go Outdated Show resolved Hide resolved
x/rollapp/keeper/msg_server_mark_vulnerable_rollapps.go Outdated Show resolved Hide resolved
x/rollapp/keeper/msg_server_update_state.go Outdated Show resolved Hide resolved
@mtsitrin mtsitrin merged commit 05e445c into main Sep 23, 2024
47 of 124 checks passed
@mtsitrin mtsitrin deleted the kirill/1207-drs-version branch September 23, 2024 17:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DRS Vulnerability recovery at scale - Impl
3 participants