New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mark empty DRS version vulnerable #1233

Open

keruch opened this issue Sep 18, 2024 · 0 comments

Labels

Contributor

keruch commented Sep 18, 2024

Links to #1207

Currently we support empty DRS versions due to the backward compatibility. In the future, this field will become mandatory. The upgrade plan is:

first support empty DrsVersion
wait for a while until the majority of sequencers update to the new version
mark empty "" DrsVersion vulnerable
add DrsVersion != "" validation: x/rollapp/types/message_update_state.go:ValidateBasic
delete DrsVersion == "" conditions: x/rollapp/keeper/msg_server_mark_vulnerable_rollapps.go:MarkVulnerableRollapps

The text was updated successfully, but these errors were encountered:

keruch mentioned this issue

feat(rollapp): DRS versions #1223

Open

29 tasks

danwt added the security label

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment