feat: observe api c++ bindings / improve observe api c bindings #165
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* namespace imports and give them `n` suffix to signify length param * use stronger typing on imports to type issues at compile time * rename observe_api_metric to observe_api_statsd * add observe_api_metric taking a format param * add observe_api_statsd_n * rename observe_api_write_log to observe_api_log for consistency
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
observe_api(Fixes Observe API C++ SDK #139)Spanclass to observe api cpp bindingsNote: The observe api was never implemented in the js sdk.