Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More initial docs #557

Merged
merged 1 commit into from
Oct 3, 2024
Merged

More initial docs #557

merged 1 commit into from
Oct 3, 2024

Conversation

andreaTP
Copy link
Collaborator

@andreaTP andreaTP commented Oct 3, 2024

Here:

  • a little more structure
  • started porting a couple of section of the Readme (with jbang checks etc.)
  • ported the initial Blog we wrote for Java Advent

Next:

  • more structure
  • a more scalable way to test the docs
  • port the rest of the Readme

@bhelx
Copy link
Contributor

bhelx commented Oct 3, 2024

Going to see why cloudflare didn't build this preview branch. I suspect because because this is a fork.

@andreaTP
Copy link
Collaborator Author

andreaTP commented Oct 3, 2024

Probably the preview doesn't work on PRs from forks.
I think you can trust me this time as it's really an in progress work, I'll push to the main repo next time.

@andreaTP andreaTP merged commit eea6e02 into dylibso:main Oct 3, 2024
13 checks passed
@andreaTP
Copy link
Collaborator Author

andreaTP commented Oct 3, 2024

I don't see the site being updated after the merge, @bhelx I think I need your intervention here 🙏

@bhelx
Copy link
Contributor

bhelx commented Oct 3, 2024

Seems that the build failed because some updates to yarn.lock weren't checked in. will see if i can fix:


15:55:49.937 | ➤ YN0000: └ Completed in 0s 241ms
-- | --
15:55:50.000 | ➤ YN0000: ┌ Post-resolution validation
15:55:50.000 | ➤ YN0028: │ The lockfile would have been modified by this install, which is explicitly forbidden.
15:55:50.000 | ➤ YN0000: └ Completed
15:55:50.000 | ➤ YN0000: Failed with errors in 0s 313ms
15:55:50.021 | Error: Exit with error code: 1
15:55:50.021 | at ChildProcess.<anonymous> (/snapshot/dist/run-build.js)
15:55:50.022 | at Object.onceWrapper (node:events:652:26)
15:55:50.022 | at ChildProcess.emit (node:events:537:28)
15:55:50.022 | at ChildProcess._handle.onexit (node:internal/child_process:291:12)
15:55:50.030 | Failed: build command exited with code: 1
15:55:51.490 | Failed: error occurred while running build command


@bhelx
Copy link
Contributor

bhelx commented Oct 3, 2024

I had to delete yarn.lock. should be deployed and working again.

@andreaTP
Copy link
Collaborator Author

andreaTP commented Oct 3, 2024

Looks good! Thanks for looking into this quickly and sorry for the noise.
We should put yarn.lock in the .gitignore file, I'll follow up tomorrow.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants