Fix issue 401 #443
Merged
Fix issue 401 #443
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is great! Reads a lot better too. I think I have a bug I can test this on today. |
|
The SNES emulator was crashing after 100 frames or so on the interpreter. Now working on this PR! 
I think this PR fixed the stack effect bug :) |
|
FWIW I tested Doom on this PR (the real DDD) and it looks much more solid than before. |
bhelx
approved these changes
Jul 26, 2024
electrum
approved these changes
Jul 29, 2024
There was a problem hiding this comment.
This could be trimmed as we only use fac-ssa
| } | ||
|
|
||
| public static void doControlTransfer(CtrlFrame ctrlFrame, MStack stack) { | ||
| var endResults = ctrlFrame.startValues + ctrlFrame.endValues; // fix 401 |
mariofusco
approved these changes
Jul 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I ended up rewriting the entire control flow in a way that maps closely to the
TypeValidatorimplementation.Fix #401